Pending stickers status maintains after app restart #9965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (9)
|
|
Tested on ios that stickers can be purchased and pending status remains between app restarts. |
rasom
reviewed
Feb 4, 2020
| @@ -31,6 +31,9 @@ | |||
| {} | |||
| stickers-packs)) | |||
|
|
|||
| (defn rpc->pending-packs [pending-packs] | |||
rasom
reviewed
Feb 4, 2020
src/status_im/stickers/core.cljs
Outdated
Comment on lines
92
to
98
| (fx/merge cofx | ||
| {:db (assoc db | ||
| :stickers/packs-installed sticker-packs | ||
| :stickers/packs sticker-packs | ||
| :stickers/packs-pending pending-packs)} | ||
| #(when (not-empty pending-packs) | ||
| {:stickers/set-pending-timeout-fx nil})))) |
There was a problem hiding this comment.
It could be just
(cond-> {:db (assoc db
:stickers/packs-installed sticker-packs
:stickers/packs sticker-packs
:stickers/packs-pending pending-packs)}
(not-empty pending-packs)
(assoc :stickers/set-pending-timeout-fx nil))
|
i think it will be better to implement saving pending transactions, in that case we could just check that we have pending transaction for stickers |
|
@rasom, thanks for your notes, addressed. |
|
@flexsurfer, yesterday we discussed that it is possible to commit this PR and create a separate issue to support pending transactions. If you still don't mind to make it this way, could you please comment/review? Thanks. |
flexsurfer
approved these changes
Feb 5, 2020
vkjr
force-pushed
the
fix/stickers_pending
branch
from
0bdd791
to
d166ea7
Compare
25% of end-end tests have passedFailed tests (73)Click to expand
Passed tests (24)Click to expand |
vkjr
force-pushed
the
fix/stickers_pending
branch
from
d166ea7
to
a0275f3
Compare
vkjr
force-pushed
the
fix/stickers_pending
branch
from
a0275f3
to
add9ce2
Compare
|
@Serhy, thank you for testing! |
Signed-off-by: Volodymyr Kozieiev <vkjr.sp@gmail.com>
vkjr
force-pushed
the
fix/stickers_pending
branch
from
add9ce2
to
e6c859d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9754
Summary
If stickers purchase wasn't confirmed yet, user will see waiting spinner even after restart
NOTE:
status-goPR should be merged first andstatus-go-version.jsonupdated before merge of this one.Review notes
When user purchases a stickerpack, new
pending-stickersrecord added to multiaccount to survive restart (Related changes in status-go: status-im/status-go#1830).After app start we run
set-pending-timeout-fxagain to make sure that pending stickers will be processedPlatforms
Areas that maybe impacted
Stickers purchasing
Steps to test
status: ready