Skip to content

[#9575] Make sure status supports EIP 1102 and EIP 1193 #9629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2019
Merged

[#9575] Make sure status supports EIP 1102 and EIP 1193 #9629

merged 2 commits into from
Dec 11, 2019

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Dec 10, 2019 •
edited by StatusWrike
Loading

fixes #9575

tested : CK, airswap, uniswap

for QA: test all most popular dapps from dap.ps

@flexsurfer flexsurfer requested review from vitvly and yenda December 10, 2019 10:58
@flexsurfer flexsurfer requested a review from a team as a code owner December 10, 2019 10:58
@flexsurfer flexsurfer self-assigned this Dec 10, 2019
@auto-assign auto-assign bot removed the request for review from a team December 10, 2019 10:58
@ghost
Copy link

ghost commented Dec 10, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Dec 10, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 10d6771 #1 2019-12-10 11:08:03 ~9 min ios 📦ipa 📲
✔️ 10d6771 #1 2019-12-10 11:15:32 ~16 min android-e2e 📦apk 📲
✔️ 10d6771 #1 2019-12-10 11:18:55 ~20 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ed1a0a0 #2 2019-12-11 13:33:47 ~9 min ios 📦ipa 📲
✔️ ed1a0a0 #2 2019-12-11 13:43:37 ~18 min android-e2e 📦apk 📲
✔️ ed1a0a0 #2 2019-12-11 13:44:09 ~19 min android 📦apk 📲
✔️ abbe349 #3 2019-12-11 15:27:34 ~8 min ios 📦ipa 📲
✔️ abbe349 #3 2019-12-11 15:34:35 ~16 min android-e2e 📦apk 📲
✔️ abbe349 #3 2019-12-11 15:34:39 ~16 min android 📦apk 📲

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 99
Failed tests: 2
Passed tests: 97

Failed tests (2)

Click to expand
1. test_sign_typed_message

Device 1: Wait for AllowButton
Device 1: Tap on TransactionsButton

Device 1: 'SignTypedMessageButton' is not found on the screen

Device sessions

2. test_always_allow_web3_permissions

Device 1: =========================================================================
Device 1: check that can enable "Always allow" and Dapp will not ask for permissions

Device 1: 'AlwaysAllowRadioButton' is not found on the screen

Device sessions

Passed tests (97)

Click to expand
1. test_search_chat_on_home
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_install_pack_and_send_sticker
Device sessions

4. test_send_message_in_group_chat
Device sessions

5. test_login_with_new_account
Device sessions

6. test_clear_history_of_group_chat_via_group_view
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_user_can_switch_network
Device sessions

17. test_mobile_data_usage_popup_continue_syncing
Device sessions

18. test_set_profile_picture
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_send_message_to_newly_added_contact
Device sessions

22. test_share_contact_code_and_wallet_address
Device sessions

23. test_make_admin_member_of_group_chat
Device sessions

24. test_connection_is_secure
Device sessions

25. test_add_to_contacts
Device sessions

26. test_add_account_to_multiaccount_instance
Device sessions

27. test_can_open_dapp_from_dapp_store
Device sessions

28. test_user_can_remove_profile_picture
Device sessions

29. test_refresh_button_browsing_app_webview
Device sessions

30. test_long_press_to_delete_1_1_chat
Device sessions

31. test_can_add_existing_ens
Device sessions

32. test_transaction_wrong_password_wallet
Device sessions

33. test_public_chat_messaging
Device sessions

34. test_unread_messages_counter_public_chat
Device sessions

35. test_delete_one_to_one_chat_via_delete_button
Device sessions

36. test_long_press_to_delete_public_chat
Device sessions

37. test_text_message_1_1_chat
Device sessions

38. test_delete_public_chat_via_delete_button
Device sessions

39. test_can_use_purchased_stickers_on_recovered_account
Device sessions

40. test_open_transaction_on_etherscan
Device sessions

41. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

42. test_unread_messages_counter_1_1_chat
Device sessions

43. test_contact_profile_view
Device sessions

44. test_logcat_backup_recovery_phrase
Device sessions

45. test_delete_group_chat_via_delete_button
Device sessions

46. test_start_chat_with_ens
Device sessions

47. test_open_blocked_site
Device sessions

48. test_open_chat_by_pasting_public_key
Device sessions

49. test_ens_username_recipient
Device sessions

50. test_fetch_more_history_in_empty_chat
Device sessions

51. test_open_public_chat_using_deep_link
Device sessions

52. test_switch_users_and_add_new_account
Device sessions

53. test_copy_contact_code_and_wallet_address
Device sessions

54. test_send_transaction_from_daap
Device sessions

55. test_send_two_transactions_one_after_another_in_dapp
Device sessions

56. test_message_marked_as_sent_in_1_1_chat
Device sessions

57. test_long_press_delete_clear_all_dapps
Device sessions

58. test_copy_and_paste_messages
Device sessions

59. test_deploy_contract_from_daap
Device sessions

60. test_password_in_logcat_creating_account
Device sessions

61. test_add_custom_token
Device sessions

62. test_sign_message_from_daap
Device sessions

63. test_group_chat_system_messages
Device sessions

64. test_dapps_permissions
Device sessions

65. test_request_public_key_status_test_daap
Device sessions

66. test_logcat_send_transaction_from_wallet
Device sessions

67. test_pair_devices_sync_name_photo_public_group_chats
Device sessions

68. test_log_level_and_fleet
Device sessions

69. test_recover_account_from_new_user_seedphrase
Device sessions

70. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

71. test_send_two_transactions_in_batch_in_dapp
Device sessions

72. test_ens_in_public_and_1_1_chats
Device sessions

73. test_block_user_from_public_chat
Device sessions

74. test_fetching_balance_after_offline
Device sessions

75. test_logcat_sign_message_from_daap
Device sessions

76. test_offline_status
Device sessions

77. test_wallet_set_up
Device sessions

78. test_manage_assets
Device sessions

79. test_add_new_group_chat_member
Device sessions

80. test_offline_messaging_1_1_chat
Device sessions

81. test_decline_invitation_to_group_chat
Device sessions

82. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

83. test_send_token_with_7_decimals
Device sessions

84. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

85. test_pass_phrase_validation
Device sessions

86. test_send_emoji
Device sessions

87. test_filters_from_daap
Device sessions

88. test_redirect_to_public_chat_tapping_tag_message
Device sessions

89. test_pair_devices_sync_one_to_one_contacts
Device sessions

90. test_logcat_send_transaction_from_daap
Device sessions

91. test_send_funds_between_accounts_in_multiaccount_instance
Device sessions

92. test_add_contact_from_public_chat
Device sessions

93. test_remove_member_from_group_chat
Device sessions

94. test_send_eth_from_wallet_to_address
Device sessions

95. test_send_stt_from_wallet
Device sessions

96. test_messaging_in_different_networks
Device sessions

97. test_collectible_from_wallet_opens_in_browser_view
Device sessions

@flexsurfer flexsurfer requested review from rasom, yenda and vitvly and removed request for vitvly and yenda December 11, 2019 09:05
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_sign_typed_message
Device sessions

@churik
Copy link
Member

churik commented Dec 11, 2019

Tested (mostly just refused transactions, testing is too expensive in these apps):

  • Total swap
  • Dragonereum
  • Maker Dao
  • Ethereum name service
  • Yang Dao
  • dap.ps (upvoting)
  • all possible actions in Status Test Dapp (on Ropsten)
  • revoking access for dapps manually
  • switching accounts in dapps

@flexsurfer please, take my commit while squashing

@flexsurfer flexsurfer force-pushed the feature/browser-privacy-mode branch from ed1a0a0 to abbe349 Compare December 11, 2019 15:18
@churik @flexsurfer
removed web allow permissions test
5da40ca 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer force-pushed the feature/browser-privacy-mode branch from abbe349 to 5da40ca Compare December 11, 2019 15:34
@flexsurfer flexsurfer merged commit 5da40ca into develop Dec 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/browser-privacy-mode branch December 11, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@yenda yenda Awaiting requested review from yenda

@vitvly vitvly Awaiting requested review from vitvly

@antdanchenko antdanchenko Awaiting requested review from antdanchenko

@churik churik Awaiting requested review from churik churik is a code owner

Assignees
No one assigned
Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure status supports EIP 1102 and EIP 1193
5 participants
@flexsurfer @status-im-auto @statustestbot @churik @rasom