Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7915] fix - Text for empty chat state is shown upside down... by upgrading RN to 0.59.3 #7924

Merged
merged 1 commit into from
Apr 8, 2019
Merged

[#7915] fix - Text for empty chat state is shown upside down... by upgrading RN to 0.59.3 #7924

merged 1 commit into from
Apr 8, 2019

Conversation

bitsikka
Copy link
Contributor

@bitsikka bitsikka commented Apr 5, 2019 •
edited by 0xc1c4da
Loading

fixes #7915

Summary:

Fixes by upgrading RN from 0.59.2 to 0.59.3

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Apr 5, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a013e0f #1 2019-04-05 19:43:07 ~14 min macos 📦 dmg
✔️ a013e0f #1 2019-04-05 19:46:30 ~18 min ios 📦 ipa
✔️ a013e0f #1 2019-04-05 19:51:33 ~23 min android 📦 apk
✔️ a013e0f #1 2019-04-05 19:52:12 ~24 min windows 📦 exe
✔️ a013e0f #1 2019-04-05 19:53:08 ~25 min linux 📦 App
✔️ a013e0f #1 2019-04-05 19:56:39 ~28 min android-e2e 📦 apk
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a4dd7d2 #2 2019-04-07 10:55:29 ~50 sec android 📄 log
✔️ a4dd7d2 #2 2019-04-07 11:08:04 ~13 min macos 📦 dmg
✔️ a4dd7d2 #2 2019-04-07 11:12:01 ~17 min ios 📦 ipa
✔️ a4dd7d2 #2 2019-04-07 11:15:15 ~20 min windows 📦 exe
✔️ a4dd7d2 #2 2019-04-07 11:16:42 ~21 min linux 📦 App
✔️ a4dd7d2 #2 2019-04-07 11:18:54 ~24 min android-e2e 📦 apk
✔️ a4dd7d2 #3 2019-04-08 08:18:56 ~27 min android 📦 apk
✔️ 747ca2b #3 2019-04-08 12:06:07 ~17 min ios 📦 ipa

rasom
rasom suggested changes Apr 7, 2019
View reviewed changes
mobile_files/package.json.orig Outdated Show resolved Hide resolved
@churik
Copy link
Member

churik commented Apr 8, 2019

@bitsikka thanks for your fix!

There are several issues.

1) No label is shown if you open chat via valid deep link

Steps:

Expected result: can see icon \ label for empty screen state
Actual result:
photo_2019-04-08 12 07 10
If you tap back and again open chat, you can see the label. On nightly you can see label right after you open chat via deep link.

2) Username (chat name) is not centered when it contains > 1 row

I expect that username should be aligned on center.
For now:
dsfdsf

@rasom
Copy link
Contributor

rasom commented Apr 8, 2019

@churik can't 1) be reproduced in develop?

2) is certainly presented in develop, so I would fix this in a separate issue

@churik
Copy link
Member

churik commented Apr 8, 2019 •
edited
Loading

@rasom

  1. is not in develop
  2. yes, it is in develop. Will create separate issue for it.

@rasom
Copy link
Contributor

rasom commented Apr 8, 2019

1) can be reproduced in nightly if another chat was opened before opening the link

@rasom
Copy link
Contributor

rasom commented Apr 8, 2019 •
edited
Loading

@churik it seems that both 1) and 2) are not introduced in this PR

@churik
Copy link
Member

churik commented Apr 8, 2019

@rasom yes, agree, steps a bit different.
Will create separate issue for them.

@bitsikka
Copy link
Contributor Author

bitsikka commented Apr 8, 2019

On it, 1) might have to do with a bug in #7454 I'm submitting the PR for 2) is something different (should be a simple fix)

Investigate both right away

@churik
Copy link
Member

churik commented Apr 8, 2019

Thank you @bitsikka !
I'll create separate issues for them.

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 46
Failed tests: 0
Passed tests: 46

Passed tests (46)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_request_and_receive_tokens_in_1_1_chat
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_text_message_1_1_chat
Device sessions

9. test_add_to_contacts
Device sessions

10. test_unread_messages_counter_1_1_chat
Device sessions

11. test_logcat_send_transaction_from_daap
Device sessions

12. test_send_message_in_group_chat
Device sessions

13. test_logcat_send_transaction_from_wallet
Device sessions

14. test_send_token_with_7_decimals
Device sessions

15. test_modify_transaction_fee_values
Device sessions

16. test_send_eth_from_wallet_to_address
Device sessions

17. test_manage_assets
Device sessions

18. test_logcat_send_transaction_in_1_1_chat
Device sessions

19. test_request_and_receive_eth_in_1_1_chat
Device sessions

20. test_swipe_to_delete_public_chat
Device sessions

21. test_send_emoji
Device sessions

22. test_search_chat_on_home
Device sessions

23. test_logcat_recovering_account
Device sessions

24. test_messaging_in_different_networks
Device sessions

25. test_send_tokens_in_1_1_chat
Device sessions

26. test_network_mismatch_for_send_request_commands
Device sessions

27. test_logcat_sign_message_from_daap
Device sessions

28. test_swipe_to_delete_1_1_chat
Device sessions

29. test_switch_users_and_add_new_account
Device sessions

30. test_send_stt_from_wallet
Device sessions

31. test_send_eth_in_1_1_chat
Device sessions

32. test_login_with_new_account
Device sessions

33. test_send_eth_from_wallet_to_contact
Device sessions

34. test_add_contact_from_public_chat
Device sessions

35. test_send_two_transactions_one_after_another_in_dapp
Device sessions

36. test_password_in_logcat_creating_account
Device sessions

37. test_backup_recovery_phrase
Device sessions

38. test_offline_status
Device sessions

39. test_open_google_com_via_open_dapp
Device sessions

40. test_unread_messages_counter_public_chat
Device sessions

41. test_sign_message_from_daap
Device sessions

42. test_user_can_remove_profile_picture
Device sessions

43. test_share_contact_code_and_wallet_address
Device sessions

44. test_request_eth_in_wallet
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

46. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@rasom
Copy link
Contributor

rasom commented Apr 8, 2019 •
edited
Loading

@bitsikka please consider filing separate PRs for these issues, I would prefer to merge this one asap :)

@bitsikka
Copy link
Contributor Author

bitsikka commented Apr 8, 2019

@bitsikka please consider filing separate PRs for these issue, I would prefer to merge this one asap :)

definitely

separate PRs for 1) and 2) comping up

@churik
Copy link
Member

churik commented Apr 8, 2019

@bitsikka
Issues:

Tested:

  • empty state for public chats opened: via deep link, via link inside app, via "Join public chat"
  • empty state for group chat: when it is created as result of sync, via "Create group chat", as a member and as admin
  • empty state for 1-1 chat: when scanning QR, pasting valid key, starting chat with ENS username, via deep link, via user's profile -> Send message

@rasom rasom merged commit 747ca2b into status-im:develop Apr 8, 2019
@bitsikka bitsikka deleted the fix/#7915 branch April 8, 2019 17:54
@dependency-lockfile-snitch
Copy link

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@mandrigin mandrigin mandrigin approved these changes

Assignees
No one assigned
Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text for empty chat state is shown upside down and text direction is strange
6 participants
@bitsikka @status-im-auto @churik @rasom @statustestbot @mandrigin