upgrade android ndk to r17c #7698

jakubgs · 2019-03-08T08:06:15Z

Required by #7666
I've pushed the image and it's already up:
https://cloud.docker.com/u/statusteam/repository/docker/statusteam/status-build-android/tags

status-github-bot · 2019-03-08T08:06:20Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-im-auto · 2019-03-08T08:11:10Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`2398343`	#2	2019-03-08 08:11:09	~2 min	`android`	📄 log
❌	`2398343`	#2	2019-03-08 08:11:21	~2 min	`android-e2e`	📄 log
✔️	`2398343`	#1	2019-03-08 08:23:01	~16 min	`ios`	📦 ipa
✔️	`2398343`	#1	2019-03-08 08:25:19	~18 min	`windows`	📦 exe
✔️	`2398343`	#1	2019-03-08 08:26:27	~20 min	`linux`	📦 App
✔️	`2398343`	#1	2019-03-08 08:27:22	~20 min	`macos`	📦 dmg

❌	`70ef9b6`	#3	2019-03-11 10:22:35	~2 min	`android-e2e`	📄 log
❌	`70ef9b6`	#3	2019-03-11 10:22:35	~2 min	`android`	📄 log
✔️	`70ef9b6`	#2	2019-03-11 10:35:40	~15 min	`macos`	📦 dmg
✔️	`70ef9b6`	#2	2019-03-11 10:37:14	~17 min	`ios`	📦 ipa
✔️	`70ef9b6`	#2	2019-03-11 10:38:00	~18 min	`windows`	📦 exe
✔️	`70ef9b6`	#2	2019-03-11 10:38:45	~18 min	`linux`	📦 App

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`bdb9243`	#4	2019-03-11 11:19:35	~1 min	`android`	📄 log
❌	`bdb9243`	#4	2019-03-11 11:19:44	~1 min	`android-e2e`	📄 log
✔️	`bdb9243`	#3	2019-03-11 11:33:59	~16 min	`macos`	📦 dmg
✔️	`bdb9243`	#3	2019-03-11 11:35:18	~17 min	`ios`	📦 ipa
✔️	`bdb9243`	#3	2019-03-11 11:35:39	~17 min	`windows`	📦 exe
✔️	`bdb9243`	#3	2019-03-11 11:37:15	~19 min	`linux`	📦 App

❌	`3b92545`	#5	2019-03-11 13:55:30	~2 min	`android`	📄 log
❌	`3b92545`	#5	2019-03-11 13:55:30	~2 min	`android-e2e`	📄 log
❌	`3b92545`	#4	2019-03-11 14:05:24	~12 min	`macos`	📄 log
✔️	`3b92545`	#4	2019-03-11 14:10:16	~17 min	`ios`	📦 ipa
✔️	`3b92545`	#4	2019-03-11 14:11:46	~18 min	`windows`	📦 exe
✔️	`3b92545`	#4	2019-03-11 14:13:01	~19 min	`linux`	📦 App

jakubgs · 2019-03-08T09:02:50Z

Doesn't seem the codebase likes the upgrade:

:react-native-android:buildReactNdkLib
A problem was found with the configuration of task ':react-native-android:buildReactNdkLib'. Registering invalid inputs and outputs via TaskInputs and TaskOutputs methods has been deprecated and is scheduled to be removed in Gradle 5.0.
 - File '/home/jenkins/workspace/status-react_prs_android_PR-7698/node_modules/react-native/ReactAndroid/src/main/jni/react' specified for property '$1' is not a file.
/usr/lib/android-ndk/build/core/setup-app-platform.mk:135: *** Android NDK: Aborting    .  Stop.
Android NDK: APP_PLATFORM set to unknown platform: android-16.    
make[1]: Entering directory `/home/jenkins/workspace/status-react_prs_android_PR-7698/node_modules/react-native/ReactAndroid/src/main/jni/react/jni'
make[1]: Leaving directory `/home/jenkins/workspace/status-react_prs_android_PR-7698/node_modules/react-native/ReactAndroid/src/main/jni/react/jni'
:react-native-android:buildReactNdkLib FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-android:buildReactNdkLib'.
> Process 'command '/usr/lib/android-ndk/ndk-build'' finished with non-zero exit value 2

Not sure what APP_PLATFORM does but we set it to android-18:
https://github.com/status-im/status-react/blob/38aca129cd65216078381d10abb7fb7347fce427/android/app/jni/Application.mk#L1-L4

pedropombeiro · 2019-03-11T10:39:13Z

Wondering if we should do this after we've merged the feature/nix branch

rasom · 2019-03-11T11:16:59Z

@pombeirp why?

Signed-off-by: Jakub Sokołowski <jakub@status.im>

rasom · 2019-03-11T11:41:45Z

.TOOLVERSIONS

-android-ndk;r10e;070be287539e3e7706f8dabfb6bf9879
-android-sdk-build-tools;28.0.1;
+android-ndk;r17c;a4b6b8281e7d101efd994d31e64af746
+android-sdk-build-tools;28.0.3;
 android-sdk-platform;android-27;


@pombeirp we also need to use android-28, can we change this as well? Or this config doesn't have effect on docker image?

OK, I'll push a new image with that change too. In your #status-core message you mentioned

we need to upgrade android-sdk-build-tools to 28.0.3 and android-sdk-platform to android-27

that's why I didn't change it

oh I see, that was a mistake, sorry

pedropombeiro · 2019-03-11T12:27:31Z

@pombeirp why?

Because all these dockerfiles disappear in that branch, so we'll need to redo this work in Nix before merging to develop.

rasom · 2019-03-11T13:38:44Z

so we'll need to redo this work in Nix before merging to develop

ok, I see. The problem here is that it probably will be a bit hard to maintain this PR because it's quite big, so if we switch to Nix soon then no problem to merge it after. Otherwise it might be a bit tricky with conflicts, already rebased it twice (though without huge difficulties).

rasom · 2019-03-11T14:21:25Z

to maintain this PR because it's quite big

I mean another PR #7666 :)

rasom · 2019-03-11T16:41:45Z

.TOOLVERSIONS

-android-sdk-platform;android-27;
+android-ndk;r17c;a4b6b8281e7d101efd994d31e64af746
+android-sdk-build-tools;28.0.3;
+android-sdk-platform;android-28;
 android-sdk;4333796;aa190cfd7299cd6a1c687355bb2764e4


should this line be changed? how do we manage this file btw? is this some docker related stuff?

This file is read when generating the Dockerfile to figure out which files to incorporate in it. It is also used to tag the Docker image with a different hash, depending on the values we put here.

ok, understood

rasom · 2019-03-11T16:46:05Z

.TOOLVERSIONS

-android-sdk-platform;android-27;
+android-ndk;r17c;a4b6b8281e7d101efd994d31e64af746
+android-sdk-build-tools;28.0.3;
+android-sdk-platform;android-28;


btw it seems that android-26 is hardcoded here https://github.com/status-im/status-react/blob/6d3211de46f302ab1a92eb3bb711733dd9cb8d9f/docker/android/Dockerfile#L13

I'm not too familiar with the Android SDK dependencies, I assume that we need this baseline 26 platform for some reason.

Yeah, it is, that's kinda how sdkmanager works, the packages included are named after the version of sdk. I guess it could be parametrized.

Ah wait, it actually already is parametrized right below it:
https://github.com/status-im/status-react/blob/6d3211de46f302ab1a92eb3bb711733dd9cb8d9f/docker/android/Dockerfile#L14
So my guess would be that when I was building this it wouldn't work if also platform:android-26 was not installed.

pedropombeiro · 2019-03-18T15:39:04Z

When I build the app locally, I do see this:

Configuration 'compile' in project ':react-native-image-crop-picker' is deprecated. Use 'implementation' instead.
WARNING: The specified Android SDK Build Tools version (26.0.1) is ignored, as it is below the minimum supported version (26.0.2) for Android Gradle Plugin 3.0.1.
Android SDK Build Tools 26.0.2 will be used.
To suppress this warning, remove "buildToolsVersion '26.0.1'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

The buildToolsVersion "26.0.1" directive is in node_modules/react-native-image-crop-picker/android./build.gradle

Maybe we should just update that module. cc @jeluard

jakubgs · 2019-03-22T08:18:56Z

Considering we've merged the Nix branch and the way to manage NDK is this file now:
https://github.com/status-im/status-react/blob/develop/scripts/lib/setup/nix/mobile/android-ndk/default.nix
This PR is no obsolete.

jakubgs added the android label Mar 8, 2019

jakubgs self-assigned this Mar 8, 2019

jakubgs requested review from pedropombeiro and rasom March 8, 2019 08:06

rasom approved these changes Mar 8, 2019

View reviewed changes

upgrade android ndk to r17c

8ff0ac9

Signed-off-by: Jakub Sokołowski <jakub@status.im>

rasom force-pushed the add-android-ndk-r17c branch from 70ef9b6 to bdb9243 Compare March 11, 2019 11:17

rasom reviewed Mar 11, 2019

View reviewed changes

fixup! upgrade android ndk to r17c

3b92545

pedropombeiro force-pushed the add-android-ndk-r17c branch from bdb9243 to 3b92545 Compare March 11, 2019 13:52

rasom reviewed Mar 11, 2019

View reviewed changes

jakubgs closed this Mar 22, 2019

jakubgs deleted the add-android-ndk-r17c branch March 22, 2019 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade android ndk to r17c #7698

upgrade android ndk to r17c #7698

jakubgs commented Mar 8, 2019

status-github-bot bot commented Mar 8, 2019

status-im-auto commented Mar 8, 2019 •

edited

Loading

jakubgs commented Mar 8, 2019 •

edited

Loading

pedropombeiro commented Mar 11, 2019

rasom commented Mar 11, 2019

rasom Mar 11, 2019

pedropombeiro Mar 11, 2019

rasom Mar 11, 2019

pedropombeiro commented Mar 11, 2019

rasom commented Mar 11, 2019

rasom commented Mar 11, 2019

rasom Mar 11, 2019

pedropombeiro Mar 11, 2019

rasom Mar 11, 2019

rasom Mar 11, 2019

pedropombeiro Mar 11, 2019

jakubgs Mar 18, 2019

jakubgs Mar 18, 2019

pedropombeiro commented Mar 18, 2019 •

edited

Loading

jakubgs commented Mar 22, 2019

upgrade android ndk to r17c #7698

upgrade android ndk to r17c #7698

Conversation

jakubgs commented Mar 8, 2019

status-github-bot bot commented Mar 8, 2019

Pull Request Checklist

status-im-auto commented Mar 8, 2019 • edited Loading

Jenkins Builds

jakubgs commented Mar 8, 2019 • edited Loading

pedropombeiro commented Mar 11, 2019

rasom commented Mar 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedropombeiro commented Mar 11, 2019

rasom commented Mar 11, 2019

rasom commented Mar 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedropombeiro commented Mar 18, 2019 • edited Loading

jakubgs commented Mar 22, 2019

status-im-auto commented Mar 8, 2019 •

edited

Loading

jakubgs commented Mar 8, 2019 •

edited

Loading

pedropombeiro commented Mar 18, 2019 •

edited

Loading