test_: bump go-waku with filter loop fix #21386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (32)
|
|
There seems to be a diff issue in the CI this time. Let's see what up |
|
Taking a look now |
|
should be fixed after #21390 is merged |
richard-ramos
force-pushed
the
fix/filter-loop
branch
from
c850ddb
to
cdd4702
Compare
|
thank you, @siddarthkay. In the meantime while we wait for that to be merged, I rebased this PR against that so it can be tested! |
16% of end-end tests have passedFailed tests (43)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (8)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestDeepLinksOneDevice:
|
|
@chaitanyaprem @richard-ramos thank you for the PR. Our e2e run has failed because contact request sent by User A has not been delivered to receiver User B. Please check the logs below |
18% of end-end tests have passedFailed tests (42)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (9)Click to expandClass TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
|
@chaitanyaprem I see the same issues in second run. Here are new logs |
chaitanyaprem
force-pushed
the
fix/filter-loop
branch
from
9883af8
to
06b901e
Compare
jakubgs
reviewed
Oct 8, 2024
you mean peerID in staging ams3 node? no idea, but i was noticing peerID mismatch errors in the mobile-CI logs which means it changed.
|
|
Wait, why is this fleet called |
jakubgs
reviewed
Oct 8, 2024
|
I've reverted that change, but the fleets file here is way outdated since it's using wrong hostnames. |
you mean the peerID is again back to the old one now? iirc the older hostnames should still resolve isn't it? |
53% of end-end tests have passedFailed tests (24)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Passed tests (27)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
Possibly, not sure if I got the right one, I just reverted to previous value. Renaming introduced some chaos.
In theory, yes, but in practice we should be using new ones. |
|
I switched the node key back to previous one since we can't actually determine what was the correct old one. Please update the fleets file. |
|
@richard-ramos is it required for having that in 2.31? |
cc: @chaitanyaprem as he is the author of the PR in status-go status-im/status-go#5909 |
|
As discussed in https://discord.com/channels/1110799176264056863/1184582858099150958/1293562297465180190 we do need it for 2.31 since getting this PR merged will also make available a lot of prev. fixes/features developed on go-waku merged on status-go |
chaitanyaprem
force-pushed
the
fix/filter-loop
branch
from
d6a1f71
to
4d130ae
Compare
98% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (53)Click to expandClass TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
|
96% of end-end tests have passedFailed tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Passed tests (52)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
|
@chaitanyaprem recent e2e runs look good. But still, one of them has a failed test due to community has not been fetched. Maybe it is not PR related. Could you check the logs? Steps:
Actual result: community has failed to be fetched. |
|
@chaitanyaprem in case the above issue in not PR related it is ready for merge. Thank you. |
chaitanyaprem
force-pushed
the
fix/filter-loop
branch
from
4d130ae
to
eb93e5f
Compare
37% of end-end tests have passedFailed tests (34)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestFallbackMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Passed tests (20)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestFallbackMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
|
|
@chaitanyaprem large part of e2e has failed. Part of tests have failed because of our session provider but big part because of failed community fetching and not delivered contact requests. Please take a look at the logs and details below: ISSUE 1 Communities are not fetchedSteps:
Actual result: community has failed to be fetched. User_A_community_admin.log ISSUE 2 Contact requests are not deliveredSteps:
Actual result: contact request has not been delivered User_A_sender_of_contact_request.log |
59% of end-end tests have passedFailed tests (22)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Passed tests (32)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestFallbackMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
chaitanyaprem
force-pushed
the
fix/filter-loop
branch
from
c7daf6c
to
850af6d
Compare
…nd updates from status-go status-im/status-go@12c4e86...0f4f2f4
qfrank
force-pushed
the
fix/filter-loop
branch
from
850af6d
to
f548662
Compare
|
ISSUE 1 and ISSUE 2 seem to be not PR related. Community fetching failure should potentially be fixed by this PR status-im/infra-status#48 Regarding contact request delivery failure - it is probably related to #21151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
cc: @chaitanyaprem @pavloburykh