Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include Xcode 15.2 in allowed versions list #20021

Merged
merged 1 commit into from
May 15, 2024

Conversation

siddarthkay
Copy link
Contributor

Summary

As reported by @ajayesivan and @seanstrom
Xcode 15.2 worked in their local environments and I then tried to use that version and found no issues with it.

This PR adds Xcode 15.2 to versions list in Xcode Wrapper nix derivation.

Testing notes

not needed.

Platforms

  • iOS

status: ready

@siddarthkay siddarthkay self-assigned this May 14, 2024
@siddarthkay siddarthkay requested a review from jakubgs as a code owner May 14, 2024 15:51
@siddarthkay siddarthkay requested review from seanstrom, ajayesivan and a team May 14, 2024 15:51
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddarthkay thank you!

@status-im-auto
Copy link
Member

status-im-auto commented May 14, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
54682de #1 2024-05-14 15:56:16 ~4 min tests 📄log
✔️ 54682de #1 2024-05-14 15:59:10 ~7 min android-e2e 🤖apk 📲
✔️ 54682de #1 2024-05-14 15:59:18 ~7 min android 🤖apk 📲
✔️ 54682de #1 2024-05-14 16:01:55 ~10 min ios 📱ipa 📲
✔️ 9c6dd90 #2 2024-05-15 07:25:43 ~5 min tests 📄log
✔️ 9c6dd90 #2 2024-05-15 07:27:50 ~7 min android-e2e 🤖apk 📲
✔️ 9c6dd90 #2 2024-05-15 07:31:06 ~10 min android 🤖apk 📲
✔️ 9c6dd90 #2 2024-05-15 07:31:36 ~10 min ios 📱ipa 📲

@ajayesivan
Copy link
Contributor

I was blindly running make run-ios without adding '15.2' to the overlay file, under the impression that this PR was merged 🤦‍♂️

@siddarthkay
Copy link
Contributor Author

There is some issue with Linux-06 host and probably that's why the test failed. I'll rebase and try to get this merged ASAP

@siddarthkay siddarthkay force-pushed the update-xcode-wrapper-versions branch from 54682de to 9c6dd90 Compare May 15, 2024 07:20
@siddarthkay siddarthkay merged commit 91c347f into develop May 15, 2024
6 checks passed
@siddarthkay siddarthkay deleted the update-xcode-wrapper-versions branch May 15, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants