-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wallet send navigation flow #20008
Conversation
@@ -67,6 +67,7 @@ | |||
(rf/dispatch [:wallet/clean-selected-token]) | |||
(rf/dispatch [:wallet/clean-selected-collectible]) | |||
(rf/dispatch [:navigate-back]))] | |||
(rn/use-unmount #(rf/dispatch [:wallet/clean-selected-token])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When going back from the select asset screen we need to clean the selected token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep this is the main thing! 🙏
Jenkins BuildsClick to see older builds (18)
|
79% of end-end tests have passed
Failed tests (9)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (41)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
6ff19d4
to
edde147
Compare
Hi @OmarBasem ! Thanks for your navigation fix! Failed e2e are not related. |
cb2e34c
to
2ed8b0b
Compare
2ed8b0b
to
9f5fb28
Compare
fixes: #19697
Summary
This PR fixes the send navigation flow where the asset select screen or the input amount screen gets skipped after reaching the transaction page then pressing back, then going through the flow again.
Demo
Screen_Recording_20240514_091651_Status.mp4