Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated invite friends banner image #19863

Merged
merged 1 commit into from
May 7, 2024
Merged

updated invite friends banner image #19863

merged 1 commit into from
May 7, 2024

Conversation

jo-mut
Copy link
Contributor

@jo-mut jo-mut commented May 1, 2024 •
edited
Loading

fixes #19260

Summary

Simple pr to update the invite friends banner image on message home screen

Before and after screenshots comparison

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented May 1, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1b1b4d2 #1 2024-05-01 23:02:34 ~4 min tests 📄log
✔️ 1b1b4d2 #1 2024-05-01 23:04:15 ~5 min android-e2e 🤖apk 📲
✔️ 1b1b4d2 #1 2024-05-01 23:05:33 ~7 min android 🤖apk 📲
✔️ 1b1b4d2 #1 2024-05-01 23:07:02 ~8 min ios 📱ipa 📲
✔️ f097d85 #2 2024-05-02 11:21:11 ~5 min tests 📄log
✔️ f097d85 #2 2024-05-02 11:22:40 ~6 min android 🤖apk 📲
✔️ f097d85 #2 2024-05-02 11:22:53 ~6 min android-e2e 🤖apk 📲
✔️ f097d85 #2 2024-05-02 11:24:59 ~8 min ios 📱ipa 📲
✔️ ab26615 #3 2024-05-03 10:28:33 ~4 min tests 📄log
✔️ ab26615 #3 2024-05-03 10:30:25 ~6 min android-e2e 🤖apk 📲
✔️ ab26615 #3 2024-05-03 10:30:26 ~6 min android 🤖apk 📲
✔️ ab26615 #3 2024-05-03 10:32:47 ~8 min ios 📱ipa 📲
✔️ aa57fc7 #4 2024-05-06 13:42:50 ~4 min tests 📄log
✔️ aa57fc7 #4 2024-05-06 13:46:12 ~7 min android-e2e 🤖apk 📲
✔️ aa57fc7 #4 2024-05-06 13:50:47 ~12 min ios 📱ipa 📲
✔️ aa57fc7 #4 2024-05-06 13:51:11 ~12 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 98f192b #5 2024-05-07 13:17:42 ~2 min tests 📄log
✔️ 98f192b #5 2024-05-07 13:21:54 ~7 min android-e2e 🤖apk 📲
✔️ 98f192b #5 2024-05-07 13:23:03 ~8 min android 🤖apk 📲
✔️ 98f192b #5 2024-05-07 13:23:59 ~9 min ios 📱ipa 📲
✔️ 5f68d56 #6 2024-05-07 13:43:43 ~4 min tests 📄log
✔️ 5f68d56 #6 2024-05-07 13:45:39 ~6 min android-e2e 🤖apk 📲
✔️ 5f68d56 #6 2024-05-07 13:45:47 ~6 min android 🤖apk 📲
✔️ 5f68d56 #6 2024-05-07 13:47:17 ~8 min ios 📱ipa 📲

@jo-mut jo-mut self-assigned this May 1, 2024
@jo-mut jo-mut marked this pull request as ready for review May 2, 2024 11:02
@jo-mut jo-mut requested a review from ibrkhalil May 2, 2024 11:15
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 2
Passed tests: 47

IDs of failed tests: 727230,727229,703391 

IDs of expected to fail tests: 703495,703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find `Button` by `accessibility id`: `image-0`
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Long press on AssetElement
    Device 1: Find EditBox by accessibility id: address-text-input 

    critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer
    self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether',
../views/wallet_view.py:104: in send_asset_from_drawer
    self.address_text_input.send_keys(address)
../views/base_element.py:377: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.0334 ETH 

    critical/test_wallet.py:112: in test_wallet_send_eth
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:98: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the senders wallet is 0.0372 but should be 0.0371
E    Eth amount in the receivers wallet is 0.0334 but should be 0.0335



    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (47)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @jo-mut
    Copy link
    Contributor Author

    jo-mut commented May 2, 2024

    @mohsen-ghafouri just checking with you that its okay to skip manual qa as this is just replacing the banner. I added the label skip-manual-qa

    @mohsen-ghafouri
    Copy link
    Contributor

    @jo-mut I believe so

    @yevh-berdnyk
    Copy link
    Contributor

    hi @jo-mut , thanks for the PR! E2E failures are known and not related

    Francesca-G
    Francesca-G approved these changes May 7, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good to me 👍

    @jo-mut jo-mut merged commit 90e5774 into develop May 7, 2024
    6 checks passed
    @jo-mut jo-mut deleted the bug/message-home-issues branch May 7, 2024 13:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @ajayesivan ajayesivan Awaiting requested review from ajayesivan

    Assignees

    @jo-mut jo-mut

    Labels
    design-review-required skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Messages - Messages home issues
    6 participants
    @jo-mut @status-im-auto @mohsen-ghafouri @yevh-berdnyk @ibrkhalil @Francesca-G