Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: account screen jump to #19732

Merged
merged 5 commits into from
May 1, 2024
Merged

Wallet: account screen jump to #19732

merged 5 commits into from
May 1, 2024

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented Apr 19, 2024 •
edited
Loading

fixes: #19731

Summary

This PR adds jump to button to the wallet account screen

Demo

Screen_Recording_20240419_161016_Status.mp4

@OmarBasem OmarBasem self-assigned this Apr 19, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 19, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f1500a5 #1 2024-04-19 12:12:56 ~2 min tests 📄log
✔️ f1500a5 #1 2024-04-19 12:18:22 ~8 min android-e2e 🤖apk 📲
✔️ f1500a5 #1 2024-04-19 12:18:25 ~8 min android 🤖apk 📲
✔️ f1500a5 #1 2024-04-19 12:19:53 ~9 min ios 📱ipa 📲
❌ 04e1746 #2 2024-04-24 09:57:37 ~2 min tests 📄log
✔️ 04e1746 #2 2024-04-24 10:02:16 ~7 min android 🤖apk 📲
✔️ 04e1746 #2 2024-04-24 10:03:29 ~8 min ios 📱ipa 📲
✔️ 04e1746 #2 2024-04-24 10:03:37 ~8 min android-e2e 🤖apk 📲
❌ 011e1cd #4 2024-05-01 11:53:26 ~3 min tests 📄log
✔️ 011e1cd #4 2024-05-01 11:55:06 ~5 min android-e2e 🤖apk 📲
✔️ 011e1cd #4 2024-05-01 11:57:50 ~8 min ios 📱ipa 📲
✔️ 011e1cd #4 2024-05-01 11:58:51 ~9 min android 🤖apk 📲
✔️ bb69c49 #5 2024-05-01 16:00:13 ~4 min tests 📄log
✔️ bb69c49 #5 2024-05-01 16:02:22 ~6 min android-e2e 🤖apk 📲
✔️ bb69c49 #5 2024-05-01 16:02:24 ~6 min android 🤖apk 📲
✔️ bb69c49 #5 2024-05-01 16:04:09 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9d033ec #6 2024-05-01 16:13:10 ~4 min tests 📄log
✔️ 9d033ec #6 2024-05-01 16:16:44 ~7 min android-e2e 🤖apk 📲
✔️ 9d033ec #6 2024-05-01 16:16:51 ~8 min android 🤖apk 📲
✔️ 9d033ec #6 2024-05-01 16:17:14 ~8 min ios 📱ipa 📲
✔️ 7fac65b #7 2024-05-01 17:08:52 ~4 min tests 📄log
✔️ 7fac65b #7 2024-05-01 17:12:35 ~8 min android-e2e 🤖apk 📲
✔️ 7fac65b #7 2024-05-01 17:12:36 ~8 min android 🤖apk 📲
✔️ 7fac65b #7 2024-05-01 17:15:45 ~11 min ios 📱ipa 📲

@OmarBasem
Copy link
Contributor Author

Hey @Parveshdhull, I think you are well experienced in the jump to component.

Do you know if the above animation is correct (jumping from a wallet-account screen to jump-to page) ?

@Parveshdhull
Copy link
Member

Parveshdhull commented Apr 22, 2024 •
edited
Loading

Do you know if the above animation is correct (jumping from a wallet-account screen to jump-to page) ?

Hi @OmarBasem, thank you for the PR.
I think for the initial implementation it looks ok. But eventually, we probably want to have a switcher card for the wallet account and an animation of the collapsing screen on that card. (Better to confirm with the design team)

J-Son89
J-Son89 previously approved these changes Apr 22, 2024
View reviewed changes
@OmarBasem OmarBasem marked this pull request as ready for review April 24, 2024 09:52
@OmarBasem
Copy link
Contributor Author

Hey @Parveshdhull, could you please review this PR.

In addition to adding the jump-to button, this PR also fixes the jump-to button colliding with the assets list items

Screen_Recording_20240501_154344_Status.mp4

Parveshdhull
Parveshdhull approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@Parveshdhull Parveshdhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @OmarBasem

src/status_im/contexts/wallet/account/tabs/assets/style.cljs

(def list-container-style
{:padding-horizontal 8
:padding-bottom constants/floating-shell-button-height})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 52
Failed tests: 2
Expected to fail tests: 2
Passed tests: 48

IDs of failed tests: 727230,703391 

IDs of expected to fail tests: 703495,703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find `Button` by `accessibility id`: `image-0`
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Long press on AssetElement
    Device 1: Find EditBox by accessibility id: address-text-input 

    critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer
    self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether',
../views/wallet_view.py:104: in send_asset_from_drawer
    self.address_text_input.send_keys(address)
../views/base_element.py:377: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Passed tests (48)

    Click to expand

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    @OmarBasem OmarBasem merged commit a094d21 into develop May 1, 2024
    6 checks passed
    @OmarBasem OmarBasem deleted the wallet/jump-to branch May 1, 2024 17:25
    @pavloburykh pavloburykh mentioned this pull request May 10, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @J-Son89 J-Son89 J-Son89 left review comments

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    @vkjr vkjr Awaiting requested review from vkjr

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Wallet account screen jump to button
    4 participants
    @OmarBasem @status-im-auto @Parveshdhull @J-Son89