Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Identity Verification tab in Activity Center #19667

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Remove Identity Verification tab in Activity Center #19667

merged 3 commits into from
Apr 19, 2024

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Apr 16, 2024 •
edited
Loading

fixes #19643

Summary

  • This PR attempts to remove the "Identity Verification" tab from the Activity Center.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Activity Center tabs

Steps to test

  • Open Status
  • Open the Activity Center
  • Scroll through the tabs inside the Activity Center

Before and after screenshots comparison

Before

Screen.Recording.2024-04-16.at.14.50.02.mov

After

Screen.Recording.2024-04-16.at.14.41.52.mov

status: ready

@seanstrom seanstrom self-assigned this Apr 16, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 16, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (25)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7831fb0 #1 2024-04-16 12:46:20 ~4 min tests 📄log
✔️ 7831fb0 #1 2024-04-16 12:50:00 ~8 min android-e2e 🤖apk 📲
✔️ 7831fb0 #1 2024-04-16 12:50:12 ~8 min android 🤖apk 📲
✔️ 7831fb0 #1 2024-04-16 12:52:33 ~11 min ios 📱ipa 📲
✔️ 5141ac7 #2 2024-04-17 08:37:45 ~5 min tests 📄log
✔️ 5141ac7 #2 2024-04-17 08:40:13 ~7 min android-e2e 🤖apk 📲
✔️ 5141ac7 #2 2024-04-17 08:40:22 ~7 min android 🤖apk 📲
✔️ 5141ac7 #2 2024-04-17 08:43:41 ~10 min ios 📱ipa 📲
✔️ 3fe7d3b #3 2024-04-17 13:20:13 ~4 min tests 📄log
✔️ 3fe7d3b #3 2024-04-17 13:22:15 ~6 min android 🤖apk 📲
✔️ 3fe7d3b #3 2024-04-17 13:22:18 ~6 min android-e2e 🤖apk 📲
✔️ 3fe7d3b #3 2024-04-17 13:24:58 ~9 min ios 📱ipa 📲
❌ e13846c #5 2024-04-18 12:19:47 ~2 min tests 📄log
✔️ e13846c #5 2024-04-18 12:23:49 ~6 min android-e2e 🤖apk 📲
✔️ e13846c #5 2024-04-18 12:24:00 ~6 min android 🤖apk 📲
✔️ e13846c #5 2024-04-18 12:27:26 ~10 min ios 📱ipa 📲
✔️ 0c0db78 #6 2024-04-18 12:36:04 ~4 min tests 📄log
✔️ 0c0db78 #6 2024-04-18 12:38:34 ~6 min android-e2e 🤖apk 📲
✔️ 0c0db78 #6 2024-04-18 12:38:44 ~6 min android 🤖apk 📲
✔️ 0c0db78 #6 2024-04-18 12:41:16 ~9 min ios 📱ipa 📲
✔️ 0f826d4 #7 2024-04-18 15:11:39 ~4 min tests 📄log
✔️ 0f826d4 #7 2024-04-18 15:15:12 ~7 min android-e2e 🤖apk 📲
✔️ 0f826d4 #7 2024-04-18 15:15:19 ~7 min android 🤖apk 📲
❌ 0f826d4 #7 2024-04-18 15:16:50 ~9 min ios 📄log
❌ 0f826d4 #8 2024-04-18 15:26:20 ~7 min ios 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e4a715b #9 2024-04-19 07:19:09 ~3 min tests 📄log
✔️ e4a715b #9 2024-04-19 07:22:00 ~6 min android 🤖apk 📲
✔️ e4a715b #9 2024-04-19 07:22:01 ~6 min android-e2e 🤖apk 📲
✔️ e4a715b #10 2024-04-19 07:23:57 ~8 min ios 📱ipa 📲
✔️ 2eccb85 #10 2024-04-19 07:40:30 ~4 min tests 📄log
✔️ 2eccb85 #10 2024-04-19 07:44:22 ~8 min android-e2e 🤖apk 📲
✔️ 2eccb85 #10 2024-04-19 07:44:25 ~8 min android 🤖apk 📲
✔️ 2eccb85 #11 2024-04-19 07:44:53 ~8 min ios 📱ipa 📲

@seanstrom seanstrom force-pushed the seanstrom/hide-id-verification-tab-in-activity-center branch from 7831fb0 to 5141ac7 Compare April 17, 2024 08:32
FFFra
FFFra approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@FFFra FFFra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@FFFra FFFra mentioned this pull request Apr 17, 2024
Merged
@seanstrom seanstrom force-pushed the seanstrom/hide-id-verification-tab-in-activity-center branch from 5141ac7 to 3fe7d3b Compare April 17, 2024 13:15
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 2
Passed tests: 47

IDs of failed tests: 727230,702733,703391 

IDs of expected to fail tests: 703495,703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 1: Find `Button` by `accessibility id`: `jump-to` 

    critical/chats/test_1_1_public_chats.py:465: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:673: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:662: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 1: Tap on found: Button
    Device 1: Find BaseElement by accessibility id: toast-content 

    critical/chats/test_1_1_public_chats.py:440: in test_1_1_chat_send_image_save_and_share
    toast_element_text = toast_element.text
../views/base_element.py:237: in text
    return self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: BaseElement by accessibility id: `toast-content` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.93% 

    ../views/wallet_view.py:26: in get_amount
    return float(amount)
 could not convert string to float: '0.93%'

During handling of the above exception, another exception occurred:
critical/test_wallet.py:116: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:44: in _get_balances_before_tx
    eth_amount_receiver = self.wallet_2.get_asset(asset_name='Ether').get_amount()
../views/wallet_view.py:28: in get_amount
    pytest.fail("Cannot get %s amount" % self.asset_name)
E   Failed: Cannot get Ether amount



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (47)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    Hi @seanstrom thanks for the PR!
    I have two questions/comments about it:

    1. In Testing notes you mentioned:

    Please note that when testing this change that the SHOW_NOT_IMPLEMENTED_FEATURES feature-flag will need to be set to 0 or be undefined in the .env files.

    Could you clarify please, why the feature flag is not set yet here and needs to be set when testing? What's the point of the current PR state then?
    As far as I understood, the Identity Verification tab should be hidden eventually once this PR is merged, right? I might be missing something though.

    1. Skip-manual-qa case

    First of all, thanks for adding the Before and After videos! It makes completely clear what is expected here.
    And as I can see from the videos and the PR description this is actually a very small change and the PR just hides the tab behind a feature-flag. And in theory this should not cause any regression.

    According to the new process you can skip manual QA in such a case. It would be very helpful for us (QA) and also speed up the pipeline if such changes were tested by the developer and manual testing was skipped. Of course, if you think that it is safe enough (and other points from the document I added above have been completed).
    So WDYT about skipping manual testing for this PR?

    @seanstrom
    Copy link
    Member Author

    @qoqobolo yup these are good questions

    1. I think SHOW_NOT_IMPLEMENTED_FEATURES is a special feature flag that helps hide stuff, and at the moment the develop branch is configured to always show not-implemented features. I'm not sure why it's setup that way though, and it might be possible to make develop not show any not-implemented stuff by default. @flexsurfer is that okay?
    2. Yeah I think we can most likely skip-manual-qa, thanks for catching that 🙏

    @seanstrom seanstrom force-pushed the seanstrom/hide-id-verification-tab-in-activity-center branch 3 times, most recently from e13846c to 0c0db78 Compare April 18, 2024 12:31
    @seanstrom seanstrom changed the title Hide Identity Verification tab in Activity Center Remove Identity Verification tab in Activity Center Apr 18, 2024
    @seanstrom seanstrom force-pushed the seanstrom/hide-id-verification-tab-in-activity-center branch 2 times, most recently from 0f826d4 to 41244d0 Compare April 19, 2024 07:14
    @seanstrom seanstrom requested a review from jakubgs as a code owner April 19, 2024 07:14
    @seanstrom seanstrom force-pushed the seanstrom/hide-id-verification-tab-in-activity-center branch from 41244d0 to e4a715b Compare April 19, 2024 07:14
    @seanstrom seanstrom merged commit ca53bf7 into develop Apr 19, 2024
    6 checks passed
    @seanstrom seanstrom deleted the seanstrom/hide-id-verification-tab-in-activity-center branch April 19, 2024 08:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @FFFra FFFra FFFra approved these changes

    @jakubgs jakubgs Awaiting requested review from jakubgs jakubgs is a code owner

    Assignees

    @seanstrom seanstrom

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Hide "Identity Verification" tab inside activity center
    5 participants
    @seanstrom @status-im-auto @qoqobolo @FFFra @flexsurfer