Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply border radius on authentication bottom sheet #19663

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: apply border radius on authentication bottom sheet #19663

merged 1 commit into from
May 6, 2024

Conversation

jo-mut
Copy link
Contributor

@jo-mut jo-mut commented Apr 16, 2024 •
edited
Loading

fixes #19662

When the user is prompted to enter a password during the syncing, the bottom sheet does not seem to properly apply top border radius. This pr address that

Steps to test

  • Open Status
  • Navigate to setting screen
  • Navigate to syncing
  • Slide to enter your password
  • Notice the bottom sheet top border radius is not applied

Before and after screenshots comparison

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Apr 16, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0a37962 #1 2024-04-16 10:51:23 ~4 min tests 📄log
✔️ 0a37962 #1 2024-04-16 10:55:04 ~8 min android-e2e 🤖apk 📲
✔️ 0a37962 #1 2024-04-16 10:55:12 ~8 min android 🤖apk 📲
✔️ 0a37962 #1 2024-04-16 10:58:00 ~11 min ios 📱ipa 📲
✔️ 8b87d70 #3 2024-04-17 09:50:07 ~4 min tests 📄log
✔️ 8b87d70 #3 2024-04-17 09:52:57 ~7 min android-e2e 🤖apk 📲
✔️ 8b87d70 #3 2024-04-17 09:53:01 ~7 min android 🤖apk 📲
✔️ 8b87d70 #3 2024-04-17 09:56:10 ~10 min ios 📱ipa 📲
✔️ 0cd1203 #4 2024-04-17 12:51:00 ~4 min tests 📄log
✔️ 0cd1203 #4 2024-04-17 12:53:46 ~6 min android-e2e 🤖apk 📲
✔️ 0cd1203 #4 2024-04-17 12:53:52 ~6 min android 🤖apk 📲
✔️ 0cd1203 #4 2024-04-17 12:59:11 ~12 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b727c03 #5 2024-05-02 22:22:30 ~7 min tests 📄log
✔️ b727c03 #5 2024-05-02 22:25:40 ~10 min ios 📱ipa 📲
✔️ b727c03 #5 2024-05-02 22:28:10 ~12 min android-e2e 🤖apk 📲
✔️ b727c03 #5 2024-05-02 22:28:18 ~12 min android 🤖apk 📲
✔️ 730ff37 #6 2024-05-06 13:43:24 ~4 min tests 📄log
✔️ 730ff37 #6 2024-05-06 13:46:59 ~7 min android-e2e 🤖apk 📲
✔️ 730ff37 #6 2024-05-06 13:51:14 ~12 min android 🤖apk 📲
✔️ 730ff37 #6 2024-05-06 13:51:19 ~12 min ios 📱ipa 📲

@jo-mut jo-mut force-pushed the bug/sheet-border-radius branch 2 times, most recently from ece0dc5 to 8b87d70 Compare April 17, 2024 09:44
@jo-mut jo-mut marked this pull request as ready for review April 17, 2024 12:45
@jo-mut jo-mut changed the title fix: apply border radius when on sheet shell background fix: apply border radius May 2, 2024
@jo-mut jo-mut changed the title fix: apply border radius fix: apply border radius on authentication bottom sheet during May 2, 2024
@jo-mut jo-mut changed the title fix: apply border radius on authentication bottom sheet during fix: apply border radius on authentication bottom sheet May 2, 2024
@jo-mut
Copy link
Contributor Author

jo-mut commented May 2, 2024 •
edited
Loading

@ajayesivan @yqrashawn its a simple change to properly apply the radius on the bottom sheet, I thought this does not require manual qa. I added skip-manual-qa label.

@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 4
Expected to fail tests: 2
Passed tests: 46

IDs of failed tests: 727230,702783,703391,702807 

IDs of expected to fail tests: 703495,703503

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find `Button` by `accessibility id`: `image-0`
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Long press on AssetElement
    Device 1: Find EditBox by accessibility id: address-text-input 

    critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer
    self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether',
../views/wallet_view.py:104: in send_asset_from_drawer
    self.address_text_input.send_keys(address)
../views/base_element.py:377: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:614: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @yevh-berdnyk
    Copy link
    Contributor

    e2e failures are known and not PR related, thanks!

    @jo-mut jo-mut merged commit 0d7c268 into develop May 6, 2024
    6 checks passed
    @jo-mut jo-mut deleted the bug/sheet-border-radius branch May 6, 2024 14:01
    yqrashawn added a commit that referenced this pull request May 10, 2024
    @yqrashawn
    fix: revert #19663 to show bottom sheet selected item
    19fdc1f
    yqrashawn added a commit that referenced this pull request May 13, 2024
    @yqrashawn
    fix: revert #19663 to show bottom sheet selected item
    fc6a06a
    yqrashawn added a commit that referenced this pull request May 13, 2024
    @yqrashawn
    fix: revert #19663 to show bottom sheet selected item
    5509c14
    yqrashawn added a commit that referenced this pull request May 13, 2024
    @yqrashawn
    fix: revert #19663 to show bottom sheet selected item
    54c5101
    yqrashawn added a commit that referenced this pull request May 15, 2024
    @yqrashawn
    fix: revert #19663 to show bottom sheet selected item
    d3cf4ff
    yqrashawn added a commit that referenced this pull request May 16, 2024
    @yqrashawn
    fix: revert #19663 to show bottom sheet selected item
    2d48bf9
    yqrashawn added a commit that referenced this pull request May 17, 2024
    @yqrashawn
    fix: revert #19663 to show bottom sheet selected item
    9d25aae
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @yqrashawn yqrashawn yqrashawn approved these changes

    Assignees

    @jo-mut jo-mut

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Border radius not applied
    6 participants
    @jo-mut @status-im-auto @yevh-berdnyk @yqrashawn @ajayesivan @ibrkhalil