Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#19406] fix: add min char validation for nickname #19517

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[#19406] fix: add min char validation for nickname #19517

merged 2 commits into from
Apr 5, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

fixes #19406

Summary

'Minimum 5 characters' validation message should be shown

Areas that maybe impacted

  • Add/Edit nickname

Steps to test

  1. UserA on the profile page of UserB
  2. Tap three dots -> tap 'add nickname'
  3. Enter less than 5 chars into nickname field

Result

Simulator.Screen.Recording.-.iPhone.13.-.2024-04-04.at.08.58.36.mp4

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Apr 4, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 4, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d5481e4 #1 2024-04-04 06:11:11 ~4 min tests 📄log
✔️ d5481e4 #1 2024-04-04 06:13:28 ~6 min android 🤖apk 📲
✔️ d5481e4 #1 2024-04-04 06:14:02 ~7 min android-e2e 🤖apk 📲
✔️ d5481e4 #1 2024-04-04 06:16:44 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ db519a8 #2 2024-04-04 14:19:15 ~7 min tests 📄log
✔️ db519a8 #2 2024-04-04 14:19:59 ~8 min android-e2e 🤖apk 📲
✔️ db519a8 #2 2024-04-04 14:21:10 ~9 min android 🤖apk 📲
❌ db519a8 #2 2024-04-04 14:25:17 ~13 min ios 📄log
✔️ db519a8 #3 2024-04-04 15:07:04 ~9 min ios 📱ipa 📲
✔️ d884324 #3 2024-04-05 05:20:54 ~4 min tests 📄log
✔️ d884324 #3 2024-04-05 05:22:51 ~6 min android 🤖apk 📲
✔️ d884324 #3 2024-04-05 05:23:47 ~7 min android-e2e 🤖apk 📲
✔️ d884324 #4 2024-04-05 05:26:25 ~9 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 703391,702839 

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find `Button` by `accessibility id`: `image-0`
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_delete, id: 702839

    Device 2: Looking for a message by text: delete for me
    Device 1: Looking for a message by text: delete for me 

    critical/chats/test_public_chat_browsing.py:384: in test_community_message_delete
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Deleted message is shown in channel



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @OmarBasem
    Copy link
    Contributor

    @mohsen-ghafouri displaying the red error "Minimum 5 characters" as soon as the user starts typing feels odd to me as the user have not yet tried to submit anything. I think simply having the button disabled until the user types 5 characters at least would get the message across. Maybe check with design team about this detail

    @J-Son89
    Copy link
    Contributor

    J-Son89 commented Apr 4, 2024

    @mohsen-ghafouri displaying the red error "Minimum 5 characters" as soon as the user starts typing feels odd to me as the user have not yet tried to submit anything. I think simply having the button disabled until the user types 5 characters at least would get the message across. Maybe check with design team about this detail

    We should have something like you described in create profile page? So probably should be consistent to that usage. Same for create wallet account

    @mohsen-ghafouri
    Copy link
    Contributor Author

    mohsen-ghafouri commented Apr 4, 2024 •
    edited
    Loading

    @OmarBasem @J-Son89 we have debounce and validation start after 300ms, the logic is the same as validation for bio and name in edit profile screen. please let me about any suggestion changes

    Simulator.Screen.Recording.-.iPhone.13.-.2024-04-04.at.14.50.37.mp4

    @pavloburykh pavloburykh self-assigned this Apr 4, 2024
    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Apr 4, 2024 •
    edited
    Loading

    @mohsen-ghafouri thank you for the fix.

    The issue below is not related to your changes but I am wondering if it can be handled in this PR. WDYT? If you consider that it should be logged separately that's okay.

    ISSUE 1 User is able to set invalid nickname

    'Update nickname' button appears enabled for a moment after user enters first symbol despite validation is failed. In such way user can set up invalid nickname: less than 5 chars / emoji / special symbols

    Steps:

    1. Start entering nickname
    2. See if you can save invalid nickname

    Actual result:

    telegram-cloud-document-2-5222116027852145681.mp4

    @mohsen-ghafouri
    Copy link
    Contributor Author

    Hey @pavloburykh, yes i will address it in the current PR

    @mohsen-ghafouri
    Copy link
    Contributor Author

    @pavloburykh could you please check again? thanks

    @pavloburykh
    Copy link
    Contributor

    @mohsen-ghafouri thanks a lot for your fixes. PR is ready to be merged.

    @mohsen-ghafouri mohsen-ghafouri merged commit aead730 into develop Apr 5, 2024
    6 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the fix/nickname-validation branch April 5, 2024 05:28
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @seanstrom seanstrom Awaiting requested review from seanstrom

    @OmarBasem OmarBasem Awaiting requested review from OmarBasem

    Assignees

    @mohsen-ghafouri mohsen-ghafouri

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Missing validation for minimum character requirement in nickname field
    5 participants
    @mohsen-ghafouri @status-im-auto @OmarBasem @J-Son89 @pavloburykh