kotlinify account, database, Log & Network Manager #19426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
siddarthkay
requested review from
alwx,
smohamedjavid,
jo-mut,
OmarBasem and
mohsen-ghafouri
Jenkins BuildsClick to see older builds (52)
|
81% of end-end tests have passedFailed tests (8)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
siddarthkay
force-pushed
the
kotlinify-account-db-log-network-manager
branch
2 times, most recently
from
404dc26
to
43de426
Compare
mohsen-ghafouri
approved these changes
Mar 29, 2024
siddarthkay
force-pushed
the
kotlinify-account-db-log-network-manager
branch
2 times, most recently
from
ff28188
to
a453690
Compare
siddarthkay
force-pushed
the
kotlinify-account-db-log-network-manager
branch
9 times, most recently
from
a33f4fc
to
c4a48b1
Compare
|
re-launched the tests, prioritizing the PR, thank you for patience! |
87% of end-end tests have passedFailed tests (6)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
siddarthkay
force-pushed
the
kotlinify-account-db-log-network-manager
branch
from
c4a48b1
to
775e345
Compare
67% of end-end tests have passedFailed tests (2)Click to expandClass TestDeepLinksOneDevice:
Passed tests (4)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
|
|
@siddarthkay thank you for the PR. No issues from my side. Ready for merge. |
siddarthkay
force-pushed
the
kotlinify-account-db-log-network-manager
branch
from
775e345
to
a9fc3b8
Compare
parent issue: #18310 This PR converts the following `Java` files to `Kotlin` : - modules/react-native-status/android/src/main/java/im/status/ethereum/module/AccountManager.java - modules/react-native-status/android/src/main/java/im/status/ethereum/module/DatabaseManager.java - modules/react-native-status/android/src/main/java/im/status/ethereum/module/LogManager.java - modules/react-native-status/android/src/main/java/im/status/ethereum/module/NetworkManager.java This PR converts Java code to `Kotlin` which involves methods like creating account, onboarding and local network stuff that impacts syncing code. In theory the logic should be same but please test those areas. - Android status: ready
siddarthkay
force-pushed
the
kotlinify-account-db-log-network-manager
branch
from
a9fc3b8
to
bb6b4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent issue: #18310
Summary
This PR converts the following
Javafiles toKotlin:Testing notes
This PR converts Java code to
Kotlinwhich involves methods like creating account, onboarding and local network stuff that impacts syncing code.In theory the logic should be same but please test those areas.
Platforms
status: ready