Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of Login/Create/Restore account #19420

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Update usage of Login/Create/Restore account #19420

merged 2 commits into from
Mar 28, 2024

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Mar 27, 2024 •
edited
Loading

fixes #19419

Summary

  • WIP

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Login of accounts
  • Creating accounts
  • Restoring Accounts

Steps to test

WIP

Before and after screenshots comparison

WIP

status: ready

@seanstrom seanstrom self-assigned this Mar 27, 2024
@seanstrom seanstrom changed the title Update restore-account-and-login requests Update usage of Login/Create/Restore account Mar 27, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 27, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e5d8dd6 #1 2024-03-27 17:02:34 ~5 min tests 📄log
✔️ e5d8dd6 #1 2024-03-27 17:03:37 ~6 min android-e2e 🤖apk 📲
✔️ e5d8dd6 #1 2024-03-27 17:06:15 ~9 min android 🤖apk 📲
✔️ e5d8dd6 #1 2024-03-27 17:08:24 ~11 min ios 📱ipa 📲
✔️ d598f84 #3 2024-03-28 14:45:44 ~4 min tests 📄log
✔️ d598f84 #3 2024-03-28 14:47:57 ~6 min android-e2e 🤖apk 📲
✔️ d598f84 #3 2024-03-28 14:48:58 ~7 min android 🤖apk 📲
✔️ d598f84 #3 2024-03-28 14:50:55 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 97a4168 #5 2024-03-28 16:13:38 ~4 min tests 📄log
✔️ 97a4168 #5 2024-03-28 16:15:36 ~6 min android-e2e 🤖apk 📲
✔️ 97a4168 #5 2024-03-28 16:17:05 ~7 min android 🤖apk 📲
✔️ 97a4168 #5 2024-03-28 16:21:15 ~11 min ios 📱ipa 📲
✔️ 44d4189 #6 2024-03-28 16:38:45 ~4 min tests 📄log
✔️ 44d4189 #6 2024-03-28 16:41:49 ~7 min android-e2e 🤖apk 📲
✔️ 44d4189 #6 2024-03-28 16:41:50 ~7 min android 🤖apk 📲
✔️ 44d4189 #6 2024-03-28 16:46:34 ~11 min ios 📱ipa 📲

@qoqobolo qoqobolo mentioned this pull request Mar 28, 2024
Closed
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 702809,702777 

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/chats/test_public_chat_browsing.py:982: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in 1-1 chat for the recipient (device 2)



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777

    Device 1: Find Button by xpath: //*[@text="Paste"]
    Device 1: Tap on found: Button 

    activity_center/test_activity_center.py:237: in test_add_contact_field_validation
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Error message is not shown for value "cs3:X1cQV8s:Cfi:2BaqXryVis94oZxvLLHGGSw2zaf8UqehWp6bWYQmJnVrK:7pzTib3QkmBonVpqVGsHX9KqYig9YBr8VonwMsUciQWk"



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @smohamedjavid
    Copy link
    Member

    I don't know why this PR is in Draft state, but the code looks good to me 👍

    @qfrank
    Copy link
    Contributor

    qfrank commented Mar 28, 2024

    I don't know why this PR is in Draft state, but the code looks good to me 👍

    same feeling

    @qoqobolo
    Copy link
    Contributor

    @smohamedjavid @qfrank thanks for reviewing guys!
    This PR is created to test these go changes on the mobile side.

    But I see that this PR also contains some changes on our side. @seanstrom could you confirm if we're gonna merge this PR as well and clarify why it's in Draft state please?

    From the QA perspective: I tested the basic flows manually (creating a new profile, restoring from seed, login, logout, biometrics, sync, a new wallet account creation), e2e results also look good, so both this and go PR can be merged.
    cc @igor-sirotin

    @seanstrom seanstrom marked this pull request as ready for review March 28, 2024 14:25
    @seanstrom
    Copy link
    Member Author

    Yup yup we'll be ready to merge this PR once the status-go changes are merged and the status-go version is bumped and tagged in git.

    @seanstrom
    Copy link
    Member Author

    seanstrom commented Mar 28, 2024 •
    edited
    Loading

    Sorry for the draft state, I wasn't sure if this PR was going to be merged initially, I've made it ready for review now 👍.
    cc @qfrank @smohamedjavid

    @seanstrom seanstrom force-pushed the seanstrom/login-improvements branch from e5d8dd6 to 825e817 Compare March 28, 2024 14:39
    @seanstrom seanstrom force-pushed the seanstrom/login-improvements branch from 825e817 to d598f84 Compare March 28, 2024 14:40
    @qoqobolo
    Copy link
    Contributor

    Thanx for the clarification @seanstrom!
    Let's wait for the go PR then 👍

    @igor-sirotin
    Copy link
    Contributor

    Thanks everyone! I've merged the status-go PR now 🙌

    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Mar 28, 2024 •
    edited
    Loading

    @seanstrom PR is ready to be merged. In case this is your first time of merging PR containing go changes please ask devs how to bump status go version correctly when merging. Thank you!

    @seanstrom seanstrom force-pushed the seanstrom/login-improvements branch from d598f84 to 2fccd02 Compare March 28, 2024 16:06
    @seanstrom
    Copy link
    Member Author

    seanstrom commented Mar 28, 2024 •
    edited
    Loading

    I've updated the status-go version in this PR to the newly tagged version of status-go v0.178.0
    Let me know if this seems alright 🙏
    cc @qfrank @smohamedjavid @igor-sirotin

    @seanstrom seanstrom force-pushed the seanstrom/login-improvements branch from 2fccd02 to 97a4168 Compare March 28, 2024 16:09
    @seanstrom seanstrom force-pushed the seanstrom/login-improvements branch from 97a4168 to 44d4189 Compare March 28, 2024 16:34
    @seanstrom seanstrom merged commit 932fee2 into develop Mar 28, 2024
    6 checks passed
    @seanstrom seanstrom deleted the seanstrom/login-improvements branch March 28, 2024 16:51
    mmilad75 pushed a commit that referenced this pull request Apr 2, 2024
    @seanstrom @mmilad75
    Update usage of Login/Create/Restore account (#19420)
    1df6cf5 
    status-im/status-go@eb13459...eb13459

* update status-go version to v0.178.0

* chore: add fetchBackup as true when restoring account
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @qfrank qfrank qfrank approved these changes

    Assignees

    @seanstrom seanstrom

    Labels
    status-go Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Update usage of Login/Create/Restore account
    7 participants
    @seanstrom @status-im-auto @smohamedjavid @qfrank @qoqobolo @igor-sirotin @pavloburykh