-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kotlinify parts of status module, package & Utils #19408
Conversation
419350f
to
fde753e
Compare
Jenkins BuildsClick to see older builds (50)
|
0% of end-end tests have passed
Failed tests (47)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
119cfa0
to
cb571cd
Compare
92% of end-end tests have passed
Failed tests (3)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
cb571cd
to
e18d204
Compare
805f648
to
8a23a3a
Compare
9cb1ddc
to
3e0cf99
Compare
3e0cf99
to
1807604
Compare
Hey @siddarthkay, thank you for the PR. Are there any known areas that might have been impacted by this PR? It would be very helpful |
Hi @VolodLytvynenko : This PR impacts a function which is used for executing almost all calls to status-go. |
1807604
to
d2df625
Compare
@siddarthkay Got it :) Thanx |
66a8fa0
to
a27fb27
Compare
92% of end-end tests have passed
Failed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (48)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
Hi @siddarthkay thank you for PR. No issues from my side. Ready to be merged |
parent issue: #18310 This PR converts the following `Java` files to `Kotlin` : - modules/react-native-status/android/src/main/java/im/status/ethereum/module/StatusModule.java - modules/react-native-status/android/src/main/java/im/status/ethereum/module/StatusPackage.java - modules/react-native-status/android/src/main/java/im/status/ethereum/module/Utils.java This PR converts Java code to `Kotlin` which involves a helper function that is used to execute `statusgo` methods. It may impact everything or nothing. - Android
a27fb27
to
bb1b2e7
Compare
88% of end-end tests have passed
Failed tests (5)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
|
parent issue: #18310
Summary
This PR converts the following
Java
files toKotlin
:Testing notes
This PR converts Java code to
Kotlin
which involves a helper function that is used to executestatusgo
methods.It may impact everything or nothing.
Platforms
status: ready