-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-route a user's own profile link to their settings page #19389
Conversation
Jenkins BuildsClick to see older builds (8)
|
73% of end-end tests have passed
Failed tests (12)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (35)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
@status-im/mobile-qa can you please review these E2E results? 🙏 |
2dcbf31
to
17814bc
Compare
@seanstrom I have triggered one more e2e run as there are a lot of infrastructure failures. Please, ping me up once new results are published. Thank you! |
94% of end-end tests have passed
Failed tests (2)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
|
@seanstrom e2e failures are not PR related. |
@pavloburykh thanks for checking those E2E results! 🙏 In your opinion, do you think this PR would need request-manual-qa? It's a small change, but it might be nice to have someone else test it. Should I ping another dev to do a quick check or assign this PR request-manual-qa? |
@VolodLytvynenko could you please verify this small fix? Thank you! |
hi @seanstrom thank you for PR . No issues from my side. PR is ready to be merged |
17814bc
to
9da44d6
Compare
9da44d6
to
133237c
Compare
fixes #19328
Summary
Platforms
Areas that maybe impacted
Functional
Steps to test
This issues provides a video on how to re-produce: #19328
Before and after screenshots comparison
Before
Screen.Recording.2024-03-25.at.13.23.07.mov
After
Screen.Recording.2024-03-25.at.13.21.50.mov
status: ready