[Feature] Show "Testnet mode enabled" banner if testnet enabled #19348

smohamedjavid · 2024-03-21T11:01:35Z

fixes #19357

Summary

This PR adds the "Testnet mode enabled" banner if the User has enabled the testnet.

Platforms

Android
iOS

Steps to test

Open Status
Log into a profile
Navigate to Profile > Advanced
Enable Testnet mode toggle
Verify the "Testnet mode enabled" is shown after login

⚠️ NOTE:

Since this commit, 1d44472 is merged. This enables Test Networks in Dev, E2E and PR Builds by default and disables in Release/Nightly Builds.

This enables in create account or restore account flow. If you upgrade the app from the old build with an existing profile, it will use the last saved (test networks enabled) state of that profile.

status: ready

status-im-auto · 2024-03-21T11:08:03Z

Jenkins Builds

Click to see older builds (24)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7097eee`	#1	2024-03-21 11:08:03	~6 min	`tests`	📄`log`
✔️	`7097eee`	#1	2024-03-21 11:08:28	~6 min	`android`	🤖`apk` 📲
✔️	`7097eee`	#1	2024-03-21 11:08:34	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`7097eee`	#1	2024-03-21 11:11:12	~9 min	`ios`	📱`ipa` 📲

✔️	`1e298b5`	#2	2024-03-22 08:18:23	~6 min	`tests`	📄`log`
✔️	`1e298b5`	#2	2024-03-22 08:19:20	~7 min	`android`	🤖`apk` 📲
✔️	`1e298b5`	#2	2024-03-22 08:19:28	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`1e298b5`	#2	2024-03-22 08:20:49	~8 min	`ios`	📱`ipa` 📲

✔️	`41cdb63`	#3	2024-03-26 15:17:04	~12 min	`android`	🤖`apk` 📲
✔️	`41cdb63`	#3	2024-03-26 15:17:06	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`41cdb63`	#3	2024-03-26 15:17:37	~12 min	`ios`	📱`ipa` 📲
✔️	`41cdb63`	#3	2024-03-26 15:17:52	~12 min	`tests`	📄`log`

✔️	`ab03040`	#4	2024-03-26 15:33:21	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ab03040`	#4	2024-03-26 15:33:42	~6 min	`tests`	📄`log`
✔️	`ab03040`	#4	2024-03-26 15:34:34	~7 min	`android`	🤖`apk` 📲
✔️	`ab03040`	#4	2024-03-26 15:36:46	~9 min	`ios`	📱`ipa` 📲

✔️	`0dc7a6d`	#5	2024-03-27 12:01:13	~6 min	`tests`	📄`log`
✔️	`0dc7a6d`	#5	2024-03-27 12:02:01	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`0dc7a6d`	#5	2024-03-27 12:02:09	~7 min	`android`	🤖`apk` 📲
✔️	`0dc7a6d`	#5	2024-03-27 12:05:44	~10 min	`ios`	📱`ipa` 📲

✔️	`5ffb139`	#6	2024-04-02 11:31:55	~4 min	`tests`	📄`log`
✔️	`5ffb139`	#6	2024-04-02 11:33:48	~6 min	`android`	🤖`apk` 📲
✔️	`5ffb139`	#6	2024-04-02 11:34:31	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`5ffb139`	#6	2024-04-02 11:37:39	~9 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`23a4ec6`	#7	2024-04-03 09:46:51	~4 min	`tests`	📄`log`
✔️	`23a4ec6`	#7	2024-04-03 09:49:20	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`23a4ec6`	#7	2024-04-03 09:50:18	~7 min	`android`	🤖`apk` 📲
✔️	`23a4ec6`	#7	2024-04-03 09:53:50	~11 min	`ios`	📱`ipa` 📲

✔️	`07b10cf`	#8	2024-04-03 10:04:33	~6 min	`android`	🤖`apk` 📲
✔️	`07b10cf`	#8	2024-04-03 10:04:38	~6 min	`android-e2e`	🤖`apk` 📲
❌	`07b10cf`	#8	2024-04-03 10:08:53	~10 min	`ios`	📄`log`
❌	`07b10cf`	#9	2024-04-03 10:09:35	~12 sec	`ios`	📄`log`
✔️	`07b10cf`	#10	2024-04-03 10:23:11	~12 min	`ios`	📱`ipa` 📲
✔️	`07b10cf`	#10	2024-04-03 10:44:07	~3 min	`tests`	📄`log`

ulisesmac

Hey @smohamedjavid
the code looks good 👍

but I think you are missing the issue being fixed, also a link to designs would help

Parveshdhull

finally, lets see alert banner in action 🔥

smohamedjavid · 2024-03-22T08:11:34Z

but I think you are missing the issue being fixed, also a link to designs would help

Added @ulisesmac 🙏

smohamedjavid · 2024-03-22T08:11:47Z

finally, lets see alert banner in action 🔥

Yes 🔥 Thanks to you for the banner implementation 😄

status-im-auto · 2024-03-22T08:59:27Z

79% of end-end tests have passed

Total executed tests: 48
Failed tests: 9
Expected to fail tests: 1
Passed tests: 38

IDs of failed tests: 702782,702733,702777,702813,702894,702745,702855,703391,703629

IDs of expected to fail tests: 703503

Failed tests (9)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 1: Find `Button` by `xpath`: `//*[@text="Paste"]`
Device 1: Tap on found: Button

activity_center/test_activity_center.py:237: in test_add_contact_field_validation
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Error message is not shown for value "random string 123"

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Find `BaseElement` by `xpath`: `//[@content-desc=':chat-floating-screen']//[starts-with(@text,'⬇')]` Device 1: Long press on `BaseElement` until expected element is shown critical/chats/test_1_1_public_chats.py:117: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_1.quote_message(emoji_unicode) ../views/chat_view.py:1058: in quote_message self.chat_view_element_starts_with_text(message).long_press_until_element_is_shown(self.reply_message_button) ../views/base_element.py:330: in long_press_until_element_is_shown action.long_press(element).release().perform() /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:174: in perform self._driver.execute(Command.TOUCH_ACTION, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace)) The element 'By.xpath: //[@content-desc=':chat-floating-screen']//[starts-with(@text,'⬇')]' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception E Stacktrace: E io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //[@content-desc=':chat-floating-screen']//[starts-with(@text,'⬇')]' is not linked to the same object in DOM anymore E at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122) E at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153) E at io.appium.uiautomator2.handler.Location.safeHandle(Location.java:23) E at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59) E at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277) E at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271) E at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435) E at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293) E at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267) E at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911) E at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) E at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611) E at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552) E at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466) E at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438) E at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140) E at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144) E at java.lang.Thread.run(Thread.java:1012) Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:459: in test_1_1_chat_text_message_delete_push_disappear self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:659: in jump_to_card_by_text self.click_on_floating_jump_to() ../views/base_view.py:648: in click_on_floating_jump_to self.jump_to_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.'; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_push_emoji, id: 702813
Device 2: Find `ProfileButton` by `accessibility id`: `open-profile` Device 1: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:321: in test_1_1_chat_push_emoji self.home_1.chats_tab.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 1: Tap on found: Button Device 1: Find `Button` by `xpath`: `//[@text="receiver"]` critical/chats/test_1_1_public_chats.py:276: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.home_1.jump_to_card_by_text(self.username_2) ../views/base_view.py:660: in jump_to_card_by_text self.element_by_text(text).click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="receiver"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
5. test_1_1_chat_edit_message, id: 702855
Device 2: Tap on found: Button Device 2: Find `Button` by `xpath`: `//[@text="sender"]` critical/chats/test_1_1_public_chats.py:372: in test_1_1_chat_edit_message self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:660: in jump_to_card_by_text self.element_by_text(text).click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[@text="sender"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.'; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:398: in test_1_1_chat_send_image_save_and_share self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:659: in jump_to_card_by_text self.click_on_floating_jump_to() ../views/base_view.py:648: in click_on_floating_jump_to self.jump_to_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Feature not implemented.'; also Unexpected Alert is shown: 'Feature not implemented.' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894

Device 2: Text is Delivered
Device 1: Looking for a message by text: Hurray! unblocked

critical/chats/test_public_chat_browsing.py:740: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 1-1 chat from blocked user is not removed and messages home is not empty!

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Looking for community: 'open community'
Device 2: Click until Text by accessibility id: community-description-text will be presented

critical/chats/test_public_chat_browsing.py:1180: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (38)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-03-26T14:14:17Z

Hi @smohamedjavid !

Can you please resolve conflicts and rebase your PR?

smohamedjavid · 2024-03-26T15:20:36Z

@mariia-skrypnyk - Ready for testing 👍

mariia-skrypnyk · 2024-03-26T16:22:39Z

Hi @smohamedjavid !
Thanks for banner implementation.

I am facing several issues:

ISSUE 1: can not open User's Profile, it is not clickable

Install app
Try to tap on user's Profile
*sometimes need to make extra actions like surfing through the app and then try once again

Actual result: user can not open his Profile

Expected result: Profile opens by tap on avatar

ISSUE 2: Some screen names are overlapped

Install app
Go to the Profile
Go through menu items by opening them one by one

Actuals result:

Expected result:
Screen names are not overlapped

smohamedjavid · 2024-03-27T10:17:19Z

Hi @mariia-skrypnyk - Thanks for testing this PR.

ISSUE 1: can not open User's Profile, it is not clickable

I tried out the latest PR build on both Android and iOS, It's working fine. 🤔
Can you help me check again? If it persists, Can you help me add the device details you have tested?

ISSUE 2: Some screen names are overlapped

I believe this is highlighted in the Alert banner Implementation PR #19011 (comment). This is expected as these are old screens and will be removed and rebuilt later.

NOTE: This PR adds the banner when testnet mode is enabled and doesn't make any other changes to the component or other features in the application.

I found one other issue. The testnet banner is shown on the onboarding flow after the keys are generated on profile creation.

Identifier	Notification

I will fix this 👍

smohamedjavid · 2024-03-27T12:04:07Z

@mariia-skrypnyk

I found one other issue. The testnet banner is shown on the onboarding flow after the keys are generated on profile creation.

This is fixed now.

mariia-skrypnyk · 2024-04-02T10:23:21Z

ISSUE 1: can not open User's Profile, it is not clickable

I tried out the latest PR build on both Android and iOS, It's working fine. 🤔 Can you help me check again? If it persists, Can you help me add the device details you have tested?

Hi @smohamedjavid !

Yes. It is a tricky issue.
I've tested on iPhone 13 17.3.1. version
Will try to reproduce it one more time, it is very rare issue - will create it separately as low prio.

Can you resolve conflicts and rebase?

smohamedjavid · 2024-04-02T11:29:44Z

Hi @mariia-skrypnyk

Yes. It is a tricky issue. I've tested on iPhone 13 17.3.1. version Will try to reproduce it one more time, it is very rare issue - will create it separately as low prio.

Sure, thanks! 🙏

Can you resolve conflicts and rebase?

Done 👍

mariia-skrypnyk · 2024-04-02T13:51:02Z

@smohamedjavid thanks for rebase.

Yes, I didn't catch this profile untapable issue but I catched thin red line above profile and above banner at the top of the app when I reopen app from the background.

IMG_7835.MP4

Can it be fixed in this PR?

smohamedjavid · 2024-04-02T16:09:58Z

Yes, I didn't catch this profile untapable issue but I catched thin red line above profile and above banner at the top of the app when I reopen app from the background.

IMG_7835.MP4
Can it be fixed in this PR?

@mariia-skrypnyk
It's barely noticeable 😅 (I took a while to notice it). I guess this is caused due to calculations in the Alert Banner. Not sure. Since this is not a blocker and low priority, can you help create a separate issue to track? 🙏

mariia-skrypnyk · 2024-04-03T08:38:59Z

Yes @smohamedjavid it is really barely noticeable.

Will do a separate issue.

status-im-auto · 2024-04-03T09:15:03Z

0% of end-end tests have passed

Total executed tests: 9
Failed tests: 9
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 702894,702855,702745,702733,702813,703629,702782,703391,702777

Failed tests (9)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Find `Button` by `accessibility id`: `show-qr-button`
Device 2: Tap on found: Button

Test setup failed: critical/chats/test_public_chat_browsing.py:815: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key()
../views/home_view.py:571: in get_public_key
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:565: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 1: Find Button by accessibility id: show-qr-button
Device 1: Tap on found: Button

Test setup failed: activity_center/test_activity_center.py:26: in prepare_devices
    self.public_key_1 = self.home_1.get_public_key()
../views/home_view.py:571: in get_public_key
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:565: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894

Device 2: Find Button by accessibility id: show-qr-button
Device 2: Tap on found: Button

Test setup failed: critical/chats/test_public_chat_browsing.py:291: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key()
../views/home_view.py:571: in get_public_key
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:565: in get_link_to_profile
    self.link_to_profile_text.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Test setup failed: critical/chats/test_1_1_public_chats.py:31: in prepare_devices self.public_key_2 = self.home_2.get_public_key() ../views/home_view.py:571: in get_public_key link_to_profile = self.get_link_to_profile() ../views/home_view.py:565: in get_link_to_profile self.link_to_profile_text.wait_for_visibility_of_element() ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Test setup failed: critical/chats/test_1_1_public_chats.py:31: in prepare_devices self.public_key_2 = self.home_2.get_public_key() ../views/home_view.py:571: in get_public_key link_to_profile = self.get_link_to_profile() ../views/home_view.py:565: in get_link_to_profile self.link_to_profile_text.wait_for_visibility_of_element() ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element
3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Test setup failed: critical/chats/test_1_1_public_chats.py:31: in prepare_devices self.public_key_2 = self.home_2.get_public_key() ../views/home_view.py:571: in get_public_key link_to_profile = self.get_link_to_profile() ../views/home_view.py:565: in get_link_to_profile self.link_to_profile_text.wait_for_visibility_of_element() ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element
4. test_1_1_chat_push_emoji, id: 702813
Test setup failed: critical/chats/test_1_1_public_chats.py:31: in prepare_devices self.public_key_2 = self.home_2.get_public_key() ../views/home_view.py:571: in get_public_key link_to_profile = self.get_link_to_profile() ../views/home_view.py:565: in get_link_to_profile self.link_to_profile_text.wait_for_visibility_of_element() ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element
5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 2: Find `Button` by `accessibility id`: `show-qr-button` Device 2: Tap on found: Button Test setup failed: critical/chats/test_1_1_public_chats.py:31: in prepare_devices self.public_key_2 = self.home_2.get_public_key() ../views/home_view.py:571: in get_public_key link_to_profile = self.get_link_to_profile() ../views/home_view.py:565: in get_link_to_profile self.link_to_profile_text.wait_for_visibility_of_element() ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
6. test_1_1_chat_send_image_save_and_share, id: 703391
Test setup failed: critical/chats/test_1_1_public_chats.py:31: in prepare_devices self.public_key_2 = self.home_2.get_public_key() ../views/home_view.py:571: in get_public_key link_to_profile = self.get_link_to_profile() ../views/home_view.py:565: in get_link_to_profile self.link_to_profile_text.wait_for_visibility_of_element() ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`share-qr-code-info-text` is not found on the screen after wait_for_visibility_of_element

mariia-skrypnyk · 2024-04-03T09:35:34Z

@smohamedjavid you can merge your PR, failed e2e will need a fix from our side.

yevh-berdnyk · 2024-04-03T09:43:08Z

hi @smohamedjavid , I've just pushed a fix for e2e tests, please don't remove my commit when rebasing

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

status-im-auto · 2024-04-03T10:29:11Z

56% of end-end tests have passed

Total executed tests: 9
Failed tests: 4
Expected to fail tests: 0
Passed tests: 5

IDs of failed tests: 702782,702777,702894,703629

Failed tests (4)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 2: Tap on found: LogInButton
Device 2: Find `Button` by `xpath`: `//*[@text="Copy code"]`

activity_center/test_activity_center.py:222: in test_add_contact_field_validation
    sync_code = self.profile_2.get_sync_code()
../views/profile_view.py:549: in get_sync_code
    self.element_by_translation_id("copy-qr").click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@text="Copy code"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Type qwerty1234 to EditBox
Device 2: Find LogInButton by accessibility id: login-button

Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:423: in join_community
    self.login_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device 2: Long press on BaseElement until expected element is shown
Device 2: Find Button by xpath: //*[@text="Reply"]

critical/chats/test_1_1_public_chats.py:150: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_2.quote_message(url_message)
../views/chat_view.py:1058: in quote_message
    self.reply_message_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `//*[@text="Reply"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894

Device 2: Type qwerty1234 to EditBox
Device 2: Find LogInButton by accessibility id: login-button

Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:423: in join_community
    self.login_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Device 2:

Passed tests (5)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

smohamedjavid self-assigned this Mar 21, 2024

smohamedjavid requested a review from a team March 21, 2024 11:02

ulisesmac approved these changes Mar 21, 2024

View reviewed changes

J-Son89 requested review from Parveshdhull and seanstrom March 21, 2024 15:44

Parveshdhull approved these changes Mar 21, 2024

View reviewed changes

smohamedjavid force-pushed the feature/show-testnet-banner-if-testnet-enabled branch from 7097eee to 1e298b5 Compare March 22, 2024 08:12

smohamedjavid added the request-manual-qa label Mar 22, 2024

pavloburykh assigned mariia-skrypnyk Mar 25, 2024

smohamedjavid force-pushed the feature/show-testnet-banner-if-testnet-enabled branch from 1e298b5 to 41cdb63 Compare March 26, 2024 15:04

smohamedjavid force-pushed the feature/show-testnet-banner-if-testnet-enabled branch from 41cdb63 to ab03040 Compare March 26, 2024 15:27

mariia-skrypnyk added the Tested - Issues label Mar 26, 2024

vkjr approved these changes Mar 27, 2024

View reviewed changes

smohamedjavid force-pushed the feature/show-testnet-banner-if-testnet-enabled branch from ab03040 to 0dc7a6d Compare March 27, 2024 11:54

smohamedjavid force-pushed the feature/show-testnet-banner-if-testnet-enabled branch from 0dc7a6d to 5ffb139 Compare April 2, 2024 11:27

mariia-skrypnyk added Tested - OK and removed Tested - Issues labels Apr 3, 2024

smohamedjavid requested a review from churik as a code owner April 3, 2024 09:42

mariia-skrypnyk mentioned this pull request Apr 3, 2024

Red line above profile picture and below Testnet mode banner appears when user reopens app from the background #19490

Closed

smohamedjavid and others added 2 commits April 3, 2024 15:27

[Feature] Show Testnet banner if Testnet enabled

0e4ac52

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>

e2e: fix

07b10cf

smohamedjavid force-pushed the feature/show-testnet-banner-if-testnet-enabled branch from 23a4ec6 to 07b10cf Compare April 3, 2024 09:58

smohamedjavid merged commit 4176368 into develop Apr 3, 2024
6 checks passed

smohamedjavid deleted the feature/show-testnet-banner-if-testnet-enabled branch April 3, 2024 10:45

mariia-skrypnyk mentioned this pull request Apr 3, 2024

"Testnet mode enabled" banner issues #19506

Closed

Parveshdhull mentioned this pull request Apr 24, 2024

Disabling Testnet alert banner #19762

Closed

[Feature] Show "Testnet mode enabled" banner if testnet enabled #19348

[Feature] Show "Testnet mode enabled" banner if testnet enabled #19348

Conversation

smohamedjavid commented Mar 21, 2024 • edited Loading

Summary

Platforms

Steps to test

⚠️ NOTE:

status-im-auto commented Mar 21, 2024 • edited Loading

Jenkins Builds

ulisesmac left a comment

Choose a reason for hiding this comment

Parveshdhull left a comment

Choose a reason for hiding this comment

smohamedjavid commented Mar 22, 2024

smohamedjavid commented Mar 22, 2024

status-im-auto commented Mar 22, 2024

79% of end-end tests have passed

Failed tests (9)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (38)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

mariia-skrypnyk commented Mar 26, 2024

smohamedjavid commented Mar 26, 2024

mariia-skrypnyk commented Mar 26, 2024 • edited Loading

smohamedjavid commented Mar 27, 2024

smohamedjavid commented Mar 27, 2024

mariia-skrypnyk commented Apr 2, 2024 • edited Loading

smohamedjavid commented Apr 2, 2024

mariia-skrypnyk commented Apr 2, 2024 • edited Loading

smohamedjavid commented Apr 2, 2024

mariia-skrypnyk commented Apr 3, 2024

status-im-auto commented Apr 3, 2024

0% of end-end tests have passed

Failed tests (9)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

mariia-skrypnyk commented Apr 3, 2024

yevh-berdnyk commented Apr 3, 2024

status-im-auto commented Apr 3, 2024

56% of end-end tests have passed

Failed tests (4)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (5)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

smohamedjavid commented Mar 21, 2024 •

edited

Loading

status-im-auto commented Mar 21, 2024 •

edited

Loading

mariia-skrypnyk commented Mar 26, 2024 •

edited

Loading

mariia-skrypnyk commented Apr 2, 2024 •

edited

Loading

mariia-skrypnyk commented Apr 2, 2024 •

edited

Loading