Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subs leak and fix schema error #19321

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Fix subs leak and fix schema error #19321

merged 7 commits into from
Mar 19, 2024

Conversation

ibrkhalil
Copy link
Contributor

Fixes a subs leak and a schema error

@ibrkhalil ibrkhalil self-assigned this Mar 19, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 19, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 17a9ca8 #1 2024-03-19 09:22:28 ~2 min tests 📄log
✔️ 17a9ca8 #1 2024-03-19 09:27:08 ~6 min android 🤖apk 📲
✔️ 17a9ca8 #1 2024-03-19 09:27:12 ~6 min android-e2e 🤖apk 📲
✔️ 17a9ca8 #1 2024-03-19 09:29:12 ~8 min ios 📱ipa 📲
❌ 3c5a60b #3 2024-03-19 09:34:53 ~2 min tests 📄log
❌ 1129a9c #4 2024-03-19 09:38:39 ~1 min tests 📄log
✔️ 1129a9c #4 2024-03-19 09:43:46 ~6 min android 🤖apk 📲
✔️ 1129a9c #4 2024-03-19 09:43:57 ~6 min android-e2e 🤖apk 📲
✔️ 1129a9c #4 2024-03-19 09:46:10 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 0aa6c32 #5 2024-03-19 09:52:04 ~1 min tests 📄log
✔️ 0aa6c32 #5 2024-03-19 09:57:25 ~7 min android 🤖apk 📲
✔️ 0aa6c32 #5 2024-03-19 09:57:41 ~7 min android-e2e 🤖apk 📲
✔️ 0aa6c32 #5 2024-03-19 10:00:48 ~10 min ios 📱ipa 📲
✔️ cb335a2 #7 2024-03-19 10:47:05 ~10 min ios 📱ipa 📲
✔️ cb335a2 #7 2024-03-19 10:48:45 ~12 min android-e2e 🤖apk 📲
✔️ cb335a2 #7 2024-03-19 10:50:35 ~14 min android 🤖apk 📲
✔️ cb335a2 #7 2024-03-19 10:50:36 ~14 min tests 📄log

@flexsurfer
Copy link
Member

seems like Schema is broken, take a look on tests

@ibrkhalil ibrkhalil mentioned this pull request Mar 19, 2024
Closed
@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Expected to fail tests: 1
Passed tests: 46

IDs of failed tests: 704615 

IDs of expected to fail tests: 703503

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615

    Device 1: Looking for a message by text: message to edit
    Device 1: Looking for a message by text: message to delete 

    critical/chats/test_public_chat_browsing.py:782: in test_community_edit_delete_message_when_offline
    self.channel_1.driver.fail("Message '%s' was not received")
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Message '%s' was not received



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @ibrkhalil
    Copy link
    Contributor Author

    E2E test failed not related to current PR
    Merging

    @ibrkhalil ibrkhalil merged commit 27407b9 into develop Mar 19, 2024
    6 checks passed
    @ibrkhalil ibrkhalil deleted the chore-fix-subs-leak-and-fix-schema-error branch March 19, 2024 12:14
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @ibrkhalil ibrkhalil

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @ibrkhalil @status-im-auto @flexsurfer