Prevent profiles list from disappearing after onboarding and logging out #19315

seanstrom · 2024-03-18T13:28:55Z

fixes #19094

Summary

This PR attempts to fix the issues related to the profiles list not appearing when choosing a user profile at login.
- This PR modifies the unmount hook of the profiles view to reset the translate-x offset to 0 after unmounting.
  - This seems necessary because the profiles view seems to display other views / modals inside of itself, which causes the profile list to be moved / animated offscreen.
  - This offset value is supposed to be reset after the onboarding screens have finished or when the user navigates back to the profiles list.
  - This PR attempts to ensure that the offset value will always be reset whenever the profiles view or onboarding screens are finished.

Testing notes

Platforms

Android
iOS

Areas that maybe impacted

Functional

account recovery
new account
existing account sync
onboarding

Steps to test

Open Status mobile
Press the profiles list button (if viewing the login screen)
Press the "+" button
Press the "Create new profile" button
Create a new profile or recover a profile
Once passed the welcome screen, logout from the app
While viewing the login screen, press the profiles list button

Before and after screenshots comparison

Before

Screen.Recording.2024-03-18.at.13.25.00.mov

After

Screen.Recording.2024-03-18.at.13.22.30.mov

status: ready

mohsen-ghafouri

LGTM :)

status-im-auto · 2024-03-18T13:36:05Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`cb0275c`	#1	2024-03-18 13:36:05	~6 min	`tests`	📄`log`
✔️	`cb0275c`	#1	2024-03-18 13:37:22	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`cb0275c`	#1	2024-03-18 13:37:47	~8 min	`android`	🤖`apk` 📲
✔️	`cb0275c`	#1	2024-03-18 13:39:38	~10 min	`ios`	📱`ipa` 📲

✔️	`ea5f681`	#2	2024-03-18 14:38:29	~6 min	`tests`	📄`log`
✔️	`ea5f681`	#2	2024-03-18 14:38:48	~6 min	`android`	🤖`apk` 📲
✔️	`ea5f681`	#2	2024-03-18 14:39:30	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ea5f681`	#2	2024-03-18 14:40:19	~8 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`e31d566`	#3	2024-03-19 10:52:21	~6 min	`tests`	📄`log`
✔️	`e31d566`	#3	2024-03-19 10:53:43	~7 min	`android`	🤖`apk` 📲
✔️	`e31d566`	#3	2024-03-19 10:54:25	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`e31d566`	#3	2024-03-19 10:57:19	~11 min	`ios`	📱`ipa` 📲

✔️	`7463414`	#4	2024-03-19 17:33:01	~6 min	`tests`	📄`log`
✔️	`7463414`	#4	2024-03-19 17:34:43	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`7463414`	#4	2024-03-19 17:34:51	~8 min	`android`	🤖`apk` 📲
✔️	`7463414`	#4	2024-03-19 17:35:26	~9 min	`ios`	📱`ipa` 📲

status-im-auto · 2024-03-18T15:35:02Z

69% of end-end tests have passed

Total executed tests: 48
Failed tests: 14
Expected to fail tests: 1
Passed tests: 33

IDs of failed tests: 703194,702859,702840,703086,702948,702894,703297,704615,702869,702839,702838,702844,702843,702841

IDs of expected to fail tests: 703503

Failed tests (14)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948

Device 2: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented
Device 2: Looking for a message by text: #cats

critical/chats/test_public_chat_browsing.py:1063: in test_community_hashtag_links_to_community_channels
    self.channel_2.chat_element_by_text(message_with_hashtag).click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestCommunityOneDeviceMerged:

1. test_community_undo_delete_message, id: 702869

Device 1: Tap on found: Button
Device 1: Find Button by xpath: //*[@text="Undo"]

critical/chats/test_public_chat_browsing.py:112: in test_community_undo_delete_message
    self.channel.element_by_text("Undo").click()
../views/base_element.py:92: in click
    element.click()
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:94: in click
    self._execute(Command.CLICK_ELEMENT)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute
    return self._parent.execute(command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 The element 'By.xpath: //*[@text="Undo"]' does not exist in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
E   Stacktrace:
E   io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //*[@text="Undo"]' does not exist in DOM anymore
E   	at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:117)
E   	at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153)
E   	at io.appium.uiautomator2.handler.Click.safeHandle(Click.java:36)
E   	at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271)
E   	at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
E   	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
E   	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
E   	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
E   	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
E   	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
E   	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
E   	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
E   	at java.lang.Thread.run(Thread.java:1012)

During handling of the above exception, another exception occurred:
critical/chats/test_public_chat_browsing.py:114: in test_community_undo_delete_message
    pytest.fail("Can't press Undo button, not enough time")
E   Failed: Can't press Undo button, not enough time

Device sessions

Device 1:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_send_image_save_and_share, id: 703297
Device 3: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` Device 3: Tap on found: ChatsTab `critical/chats/test_group_chat.py:283: in test_group_chat_send_image_save_and_share self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message about saving a photo is not shown for member_2.` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
2. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
3. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
4. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
5. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
6. test_community_edit_delete_message_when_offline, id: 704615
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
7. test_community_message_delete, id: 702839
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Find `Button` by `xpath`: `//[@content-desc='password-input']/../following-sibling:://*[@text='Join Community']` Device 2: Tap on found: Button Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
10. test_community_message_edit, id: 702843
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element
11. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (33)

Click to expand

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

mariia-skrypnyk · 2024-03-19T10:01:54Z

Hi @seanstrom !
Thanks for your PR!
Please, can you do a rebase?

seanstrom · 2024-03-19T10:49:29Z

@mariia-skrypnyk yup yup, I've rebased and pushed now 🙏

status-im-auto · 2024-03-19T15:25:34Z

93% of end-end tests have passed

Total executed tests: 14
Failed tests: 1
Expected to fail tests: 0
Passed tests: 13

IDs of failed tests: 702894

Failed tests (1)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894

Device 1: Tap on found: Button
# STEP: Check that can send message in community after unblock

/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
E   http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:
critical/chats/test_public_chat_browsing.py:697: in test_community_contact_block_unblock_offline
    self.home_2.just_fyi("Check that can send message in community after unblock")
../views/base_view.py:395: in just_fyi
    self.driver.execute_script("sauce:context=STEP: %s" % some_str)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:405: in execute_script
    return self.execute(command, {"script": script, "args": converted_args})["value"]
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
    response = self.command_executor.execute(driver_command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
    return self._request(command_info[0], url, body=data)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
    response = self._conn.request(method, url, body=body, headers=headers)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request
    return self.request_encode_body(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
    retries = retries.increment(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
    raise six.reraise(type(error), error, _stacktrace)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
    raise value.with_traceback(tb)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
 ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Device sessions

Device 1:

Device 2:

Passed tests (13)

Click to expand

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-03-19T16:53:49Z

Hi @seanstrom!
Fix looks great! Thanks!
Please, feel free to merge it.

seanstrom self-assigned this Mar 18, 2024

seanstrom requested review from jo-mut and mohsen-ghafouri March 18, 2024 13:29

mohsen-ghafouri approved these changes Mar 18, 2024

View reviewed changes

jo-mut approved these changes Mar 18, 2024

View reviewed changes

seanstrom added the request-manual-qa label Mar 18, 2024

seanstrom force-pushed the seanstrom/fix-profiles-list-after-onboarding branch from cb0275c to ea5f681 Compare March 18, 2024 14:31

mariia-skrypnyk self-assigned this Mar 19, 2024

seanstrom force-pushed the seanstrom/fix-profiles-list-after-onboarding branch from ea5f681 to e31d566 Compare March 19, 2024 10:45

mariia-skrypnyk added the Tested - OK label Mar 19, 2024

fix: reset profiles list translate-x while unmounting

7463414

seanstrom force-pushed the seanstrom/fix-profiles-list-after-onboarding branch from e31d566 to 7463414 Compare March 19, 2024 17:25

seanstrom merged commit 772efa9 into develop Mar 19, 2024
6 checks passed

seanstrom deleted the seanstrom/fix-profiles-list-after-onboarding branch March 19, 2024 17:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent profiles list from disappearing after onboarding and logging out #19315

Prevent profiles list from disappearing after onboarding and logging out #19315

seanstrom commented Mar 18, 2024

mohsen-ghafouri left a comment

status-im-auto commented Mar 18, 2024 •

edited

Loading

status-im-auto commented Mar 18, 2024

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

mariia-skrypnyk commented Mar 19, 2024

seanstrom commented Mar 19, 2024

status-im-auto commented Mar 19, 2024

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

mariia-skrypnyk commented Mar 19, 2024

Prevent profiles list from disappearing after onboarding and logging out #19315

Prevent profiles list from disappearing after onboarding and logging out #19315

Conversation

seanstrom commented Mar 18, 2024

Summary

Testing notes

Platforms

Areas that maybe impacted

Functional

Steps to test

Before and after screenshots comparison

Before

After

mohsen-ghafouri left a comment

Choose a reason for hiding this comment

status-im-auto commented Mar 18, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Mar 18, 2024

69% of end-end tests have passed

Failed tests (14)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (33)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

mariia-skrypnyk commented Mar 19, 2024

seanstrom commented Mar 19, 2024

status-im-auto commented Mar 19, 2024

93% of end-end tests have passed

Failed tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (13)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

mariia-skrypnyk commented Mar 19, 2024

status-im-auto commented Mar 18, 2024 •

edited

Loading