-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not-implemented box from sticker/emoji messages #19255
Conversation
Jenkins BuildsClick to see older builds (38)
|
src/status_im/contexts/chat/messenger/messages/content/sticker/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/chat/messenger/messages/content/emoji/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/chat/messenger/messages/content/emoji/view.cljs
Outdated
Show resolved
Hide resolved
97be4fe
to
be80310
Compare
@cammellos @J-Son89 addressed your comments |
be80310
to
810a37f
Compare
src/status_im/contexts/chat/messenger/messages/content/view.cljs
Outdated
Show resolved
Hide resolved
…t-implemented-box
19% of end-end tests have passed
Failed tests (38)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (9)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
Hi @clauxx ! Can you please rebase with resolving conflicts? |
96% of end-end tests have passed
Failed tests (1)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
Hi @clauxx ! Thanks for your PR. |
* feat: replaced old emoji component with new one * feat: replaced old sticker component with the new one * ref: pass only url to sticker * fix: renamed ns and passing only needed props * fix: destructuring instead of select-keys & assoc * fix: formatting
* feat: replaced old emoji component with new one * feat: replaced old sticker component with the new one * ref: pass only url to sticker * fix: renamed ns and passing only needed props * fix: destructuring instead of select-keys & assoc * fix: formatting
fixes #19226
Summary
Areas that maybe impacted
Functional
Steps to test
status: ready