-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#19247] feat: migrate to new contact profile #19246
Conversation
3ca2d74
to
415add0
Compare
Jenkins BuildsClick to see older builds (38)
|
10% of end-end tests have passed
Failed tests (42)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
|
@yevh-berdnyk could you please adjust e2e according to the new UI in this PR? |
hi @mohsen-ghafouri, I've just pushed updates for e2e test, please don't remove them when adding new commits. Thanks in advance! |
69% of end-end tests have passed
Failed tests (14)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (33)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
|
3c7f85a
to
374a01e
Compare
56% of end-end tests have passed
Failed tests (20)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (27)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
374a01e
to
db9cd9a
Compare
Hi @yevh-berdnyk, Added. |
Hi @mohsen-ghafouri, thank you for the PR. Here is a list of issues. Some of them might not be PR-related. I'm reporting them to ensure we don't overlook any. Please let me know which ones were fixed and which ones are better to create as within separate follow ups ISSUE 1: Buttons in 'New Contact' profile pages do not inherit selected colorSteps:
Actual result:The following buttons do not inherit the selected color. Expected result:The buttons inherit the color that is selected for certain account |
ISSUE 3: No placeholder in the contact request drawerSteps:
Actual result:Expected result:'Type something' placeholder is shown |
ISSUE 4: [iOS] Message input field not focused after opening Contact Request drawerSteps:
Actual Result:The message input field is not focused. focus.mp4Expected Result:The message input field should be focused after the contact request drawer is opened. |
ISSUE 5: Display name not shown, only nickname is displayedSteps:
Actual Result:The display name disappears after the nickname is set. Expected result:The display name is shown near the nickname |
Hi @VolodLytvynenko, thank you for reviewing this PR, for issue 1 we have this open PR #19087, the rest i will resolve and let you know |
b2c81df
to
70e65fe
Compare
@VolodLytvynenko could you please check again, 2,3,4,5 should be resolved. |
69% of end-end tests have passed
Failed tests (14)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (33)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
94% of end-end tests have passed
Failed tests (2)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
|
Hi @mohsen-ghafouri the issues 2-5 are fixed. Apologies for the delay in testing. The contact request feature is quite big, and I needed additional time to test everything. Take a look please a few additional issues: ISSUE 6: Navigation to chat review page after tapping 'Block' buttonSteps:
Actual result:The user is navigated to the chat preview page. block.mp4Expected result:The user should remain on the same page after blocking a user, rather than being navigated to the chat preview page. |
3425308
to
2ba8261
Compare
Hey @Francesca-G, thank you for your feedback. In your review, you specified that the 'Jump to' button should not be visible. However, on the original design, it is visible. Which is the correct approach? |
Apologies for this, there was an inconsistency among different files. I confirmed it with Pedro and the Jump to should be visible in this case 👍 |
fixes #19247
Summary
Migrate to new contact profile
Implemented Features
Platforms
Areas that maybe impacted
Before and after screenshots comparison
Before
After
Video
Contact.profile.mp4
status: ready