[#18833] Confirm button disappearing while editing address #19186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (32)
|
OmarBasem
approved these changes
Mar 12, 2024
J-Son89
reviewed
Mar 12, 2024
J-Son89
approved these changes
Mar 12, 2024
ulisesmac
changed the title
ulisesmac
force-pushed
the
18833-confirm-button-disappearing
branch
2 times, most recently
from
827df0e
to
eef83f5
Compare
90% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
clauxx
approved these changes
Mar 13, 2024
73% of end-end tests have passedFailed tests (12)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (35)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
|
pavloburykh
force-pushed
the
18833-confirm-button-disappearing
branch
from
eef83f5
to
8664ecc
Compare
|
Hi @ulisesmac! Thanks for your PR! I have a doubt regarding the correctness of a slide button fix. And current fix looks like this: And I can not scroll here. |
ulisesmac
force-pushed
the
18833-confirm-button-disappearing
branch
from
8664ecc
to
0e17164
Compare
|
Hey @mariia-skrypnyk thanks for testing.
That's related to the floating button page implementation, we might need to revisit it, currently designs look as:
And our implementation:
Not too different, atm this is out of scope of this PR, but we can create a follow up issue.
You couldn't scroll because the input was focused. at the beginning I didn't think that behavior is wrong, but now I enabled it, so we are now able to scroll 👍 |
ulisesmac
force-pushed
the
18833-confirm-button-disappearing
branch
from
2a33cfd
to
88a234f
Compare
Hi @ulisesmac ! Thanks for a details. 2) In case 1) I still can not scroll to see the Derivation path. Can it be fixed in this PR or followup? IMG_7532.MP4 |
Hey @mariia-skrypnyk AFAIK, that's an iOS behavior. If you are focusing an input and you can scroll, it'll be limited beacuse the input should always be within the screen. |
|
Thanks @ulisesmac ! |
Yes I think that the user should be able to scroll and see the whole screen when the keyboard is open 👍 |
Hey @Francesca-G thanks for checking this out! I'm allowing the scroll, but I think it's an iOS issue, it seems if you have a focused input you can't scroll beyond. It's not related to the keyboard, it's because the input is being focused. In case you confirm this is actually an issue, we'd like to address it in a follow up, since rn we are focusing on solving other more important bugs. thanks! |
@ulisesmac I was experimenting with it and as you can see from the video you're able to drag the page to see the derivation path. The main issue is that the page stays like that after the keyboard goes down (look at the account avatar that is cut at the top of the page) and I wasn't able to drag the page back to its original position unless the keyboard was open. So, if we're going to address the scrolling issue this issue needs to be addressed too. RPReplay_Final1711100087.mov |
Fix condition to scroll
ulisesmac
force-pushed
the
18833-confirm-button-disappearing
branch
from
88a234f
to
95de837
Compare
|
Hey @Francesca-G, I've fixed the issue, thanks for spotting it! Here's a video of the new behavior: Screen.Recording.2024-03-22.at.9.50.48.a.m.mov |
ulisesmac
force-pushed
the
18833-confirm-button-disappearing
branch
from
e2007ed
to
82621cb
Compare
Francesca-G
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18833
Summary
A small PR.
Screen.Recording.2024-03-11.at.3.58.35.p.m.mov
This PR has also the changes made in the PR
Becuase they are too realted.
Platforms
Steps to test
status: ready