Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate reagent part 3 #19165

Merged
merged 3 commits into from
Mar 13, 2024
Merged

migrate reagent part 3 #19165

merged 3 commits into from
Mar 13, 2024

Conversation

flexsurfer
Copy link
Member

migrate reagent part 3

@flexsurfer flexsurfer self-assigned this Mar 11, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 11, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ fec65b7 #1 2024-03-11 10:22:30 ~6 min tests 📄log
✔️ fec65b7 #1 2024-03-11 10:22:38 ~6 min android-e2e 🤖apk 📲
✔️ fec65b7 #1 2024-03-11 10:24:15 ~8 min android 🤖apk 📲
✔️ fec65b7 #1 2024-03-11 10:24:54 ~9 min ios 📱ipa 📲
✔️ 3a859ea #3 2024-03-11 10:37:18 ~5 min tests 📄log
✔️ 3a859ea #3 2024-03-11 10:39:01 ~7 min android 🤖apk 📲
✔️ 3a859ea #3 2024-03-11 10:39:15 ~7 min android-e2e 🤖apk 📲
✔️ 3a859ea #3 2024-03-11 10:39:28 ~7 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 48
Failed tests: 4
Expected to fail tests: 1
Passed tests: 43

IDs of failed tests: 702958,703202,703629,702957 

IDs of expected to fail tests: 703503

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Looking for community: 'open community'
    Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented 

    critical/chats/test_public_chat_browsing.py:1178: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:410: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    2. test_activity_center_mentions, id: 702957

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    Test setup failed: activity_center/test_activity_center.py:410: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2] 

    critical/chats/test_group_chat.py:119: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2)
../views/base_element.py:190: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: `1` is not equal to expected `2` in 30 sec



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (43)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    4. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    5. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    clauxx
    clauxx reviewed Mar 13, 2024
    View reviewed changes
    src/quo/components/header.cljs Show resolved Hide resolved
    src/quo/components/tabs/tabs/view.cljs
    @@ -118,87 +116,81 @@
    - `scroll-on-press?` When non-nil, clicking on a tag centers it the middle
    (with animation enabled).
    "
    [{:keys [default-active fade-end-percentage]
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    There's this PR from @ajayesivan that handles migrating this component as well

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    yeah that's fine

    @flexsurfer flexsurfer merged commit e26d3a8 into develop Mar 13, 2024
    6 checks passed
    @flexsurfer flexsurfer deleted the feature/migrate-reagent-part3 branch March 13, 2024 15:46
    @J-Son89
    Copy link
    Contributor

    J-Son89 commented Mar 13, 2024

    Hard to know if these pr's had QA or not, but if not why is that?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @clauxx clauxx clauxx approved these changes

    @Parveshdhull Parveshdhull Awaiting requested review from Parveshdhull

    @ibrkhalil ibrkhalil Awaiting requested review from ibrkhalil

    @BalogunofAfrica BalogunofAfrica Awaiting requested review from BalogunofAfrica

    @siddarthkay siddarthkay Awaiting requested review from siddarthkay

    Assignees

    @flexsurfer flexsurfer

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @flexsurfer @status-im-auto @J-Son89 @clauxx