Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update status-go version to fix the issue with peer syncing migration #19127

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Update status-go version to fix the issue with peer syncing migration #19127

merged 4 commits into from
Mar 8, 2024

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Mar 7, 2024

status-im/status-go#4883

Summary

The migration order was ruined on the go side which means the migration that adds peer-syncing-enabled boolean value to setting was not executed.
There is status-go PR that fixes that: status-im/status-go#4883
This PR just updates status-go-version.json to use the corresponding Go fix.

Review notes

You can test it the following way:

  1. install one of the older versions of Status, the ones that were created before the 5th of March
  2. create an account
  3. install the newest version of Status (the one from the current develop)
  4. make sure you cannot login there due to peer_syncing_enabled column not existing (https://discord.com/channels/1103692771585433630/1103692773363810317/1214907333013151774)
  5. install the version of Status from this PR
  6. make sure that the issue is now fixed

Testing notes

Platforms

  • Android
  • iOS

status: ready

@alwx alwx requested a review from cammellos March 7, 2024 10:54
@alwx alwx marked this pull request as ready for review March 7, 2024 10:58
@status-im-auto
Copy link
Member

status-im-auto commented Mar 7, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 730d171 #1 2024-03-07 11:01:28 ~6 min tests 📄log
✔️ 730d171 #1 2024-03-07 11:02:37 ~7 min android-e2e 🤖apk 📲
✔️ 730d171 #1 2024-03-07 11:03:31 ~8 min android 🤖apk 📲
✔️ 730d171 #1 2024-03-07 11:04:04 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6a3291a #2 2024-03-07 11:12:03 ~7 min tests 📄log
✔️ 6a3291a #2 2024-03-07 11:12:29 ~7 min android-e2e 🤖apk 📲
✔️ 6a3291a #2 2024-03-07 11:13:38 ~8 min android 🤖apk 📲
✔️ 6a3291a #2 2024-03-07 11:15:05 ~10 min ios 📱ipa 📲
✔️ 5c31ede #4 2024-03-08 09:49:44 ~6 min tests 📄log
✔️ 5c31ede #4 2024-03-08 09:50:37 ~7 min android 🤖apk 📲
✔️ 5c31ede #4 2024-03-08 09:51:24 ~8 min android-e2e 🤖apk 📲
✔️ 5c31ede #4 2024-03-08 09:52:04 ~9 min ios 📱ipa 📲

@alwx alwx force-pushed the peer-syncing-migration-order-fix branch from 730d171 to 6a3291a Compare March 7, 2024 11:04
@pavloburykh
Copy link
Contributor

@alwx thanx for the PR. Migration issue is fixed. Let's wait for e2e results. I will ping you once PR is ready for merge.

@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 703202,704615 

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]`
    Device 1: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` 

    critical/chats/test_group_chat.py:119: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2)
../views/base_element.py:190: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: `1` is not equal to expected `2` in 30 sec



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_edit_delete_message_when_offline, id: 704615

    Device 1: Looking for a message by text: text after edit
    Device 1: Looking for a message by text: message to delete 

    critical/chats/test_public_chat_browsing.py:797: in test_community_edit_delete_message_when_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Updated message 'text after edit' is not delivered to the receiver



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786
    Device sessions

    2. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    3. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    4. test_community_markdown_support, id: 702809
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    5. test_community_several_images_send_reply, id: 703194
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    10. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_add_contact_field_validation, id: 702777
    Device sessions

    3. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_mute_community_and_channel, id: 703382
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @alwx PR is ready for merge.

    @alwx alwx merged commit b3bebe1 into develop Mar 8, 2024
    6 checks passed
    @alwx alwx deleted the peer-syncing-migration-order-fix branch March 8, 2024 12:41
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mohsen-ghafouri mohsen-ghafouri mohsen-ghafouri approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    Assignees

    @alwx alwx

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @alwx @status-im-auto @pavloburykh @mohsen-ghafouri