fix Blink of shell screen occurs when the Scan sync button is tapped #19104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @Parveshdhull Can the fix of this issue #19103 be also included in this PR? |
Hi @VolodLytvynenko, I think same fix should work for both issues. But let me know if this is not the case |
|
Also, please let me know if any of the other flow is not working in settings screen. I can include in this PR. Thank you for finding this case. |
Jenkins Builds
|
jo-mut
approved these changes
Mar 5, 2024
|
hi @Parveshdhull thank you for PR. No issues from my side. Ready to be merged |
Parveshdhull
force-pushed
the
fix/screen-blink
branch
from
89bc828
to
0dc8956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19096
fixes #19103
Testing
Please let me know if any of the flow in settings screen is not working as expected
status: ready