Feature/allow user to select a color for the group chat #18982 #19088

flexsurfer · 2024-03-04T13:45:43Z

status-im-auto · 2024-03-04T13:47:35Z

Jenkins Builds

Click to see older builds (57)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`8f25e1b`	#1	2024-03-04 13:47:35	~1 min	`tests`	📄`log`
✔️	`8f25e1b`	#1	2024-03-04 13:54:54	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`8f25e1b`	#1	2024-03-04 13:54:58	~8 min	`android`	🤖`apk` 📲
✔️	`8f25e1b`	#1	2024-03-04 13:56:48	~10 min	`ios`	📱`ipa` 📲

❌	`4f2860c`	#3	2024-03-05 13:15:35	~2 min	`tests`	📄`log`
✔️	`4f2860c`	#3	2024-03-05 13:21:10	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`4f2860c`	#3	2024-03-05 13:21:29	~8 min	`android`	🤖`apk` 📲
✔️	`4f2860c`	#3	2024-03-05 13:23:52	~10 min	`ios`	📱`ipa` 📲

❌	`e48196e`	#4	2024-03-06 10:00:59	~2 min	`tests`	📄`log`
✔️	`e48196e`	#4	2024-03-06 10:05:28	~6 min	`android`	🤖`apk` 📲
✔️	`e48196e`	#4	2024-03-06 10:06:30	~7 min	`ios`	📱`ipa` 📲
✔️	`e48196e`	#4	2024-03-06 10:08:12	~9 min	`android-e2e`	🤖`apk` 📲
❌	`e48196e`	#5	2024-03-06 11:41:08	~1 min	`tests`	📄`log`

✔️	`c00e885`	#6	2024-03-06 12:35:02	~6 min	`tests`	📄`log`
✔️	`c00e885`	#5	2024-03-06 12:35:53	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`c00e885`	#5	2024-03-06 12:35:58	~7 min	`android`	🤖`apk` 📲
✔️	`c00e885`	#5	2024-03-06 12:44:03	~15 min	`ios`	📱`ipa` 📲

❌	`934cd99`	#7	2024-03-06 16:47:04	~1 min	`tests`	📄`log`
✔️	`934cd99`	#6	2024-03-06 16:52:34	~6 min	`android`	🤖`apk` 📲
✔️	`934cd99`	#6	2024-03-06 16:52:44	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`934cd99`	#6	2024-03-06 16:53:35	~7 min	`ios`	📱`ipa` 📲

✔️	`dbe0a31`	#7	2024-03-07 09:02:37	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`dbe0a31`	#7	2024-03-07 09:03:05	~6 min	`android`	🤖`apk` 📲
✔️	`dbe0a31`	#7	2024-03-07 09:04:14	~8 min	`ios`	📱`ipa` 📲
✔️	`dbe0a31`	#10	2024-03-11 08:38:06	~5 min	`tests`	📄`log`

✔️	`1ae01ce`	#11	2024-03-12 11:53:19	~6 min	`tests`	📄`log`
✔️	`1ae01ce`	#8	2024-03-12 11:54:40	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`1ae01ce`	#8	2024-03-12 11:54:45	~7 min	`ios`	📱`ipa` 📲
✔️	`1ae01ce`	#8	2024-03-12 11:54:53	~7 min	`android`	🤖`apk` 📲

✔️	`cf845ad`	#12	2024-03-12 17:14:19	~6 min	`tests`	📄`log`
✔️	`cf845ad`	#9	2024-03-12 17:15:07	~6 min	`android`	🤖`apk` 📲
✔️	`cf845ad`	#9	2024-03-12 17:16:06	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`cf845ad`	#9	2024-03-12 17:25:52	~17 min	`ios`	📱`ipa` 📲

✔️	`85c2ad1`	#13	2024-03-13 13:30:06	~6 min	`tests`	📄`log`
✔️	`85c2ad1`	#10	2024-03-13 13:31:46	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`85c2ad1`	#10	2024-03-13 13:32:34	~8 min	`android`	🤖`apk` 📲
✔️	`85c2ad1`	#10	2024-03-13 13:37:02	~13 min	`ios`	📱`ipa` 📲

✔️	`f03aa8c`	#14	2024-03-14 12:15:23	~5 min	`tests`	📄`log`
✔️	`f03aa8c`	#11	2024-03-14 12:16:13	~6 min	`android`	🤖`apk` 📲
✔️	`f03aa8c`	#11	2024-03-14 12:16:22	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`f03aa8c`	#11	2024-03-14 12:17:21	~7 min	`ios`	📱`ipa` 📲

✔️	`c7c8628`	#15	2024-03-15 09:12:10	~6 min	`tests`	📄`log`
✔️	`c7c8628`	#12	2024-03-15 09:12:10	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`c7c8628`	#12	2024-03-15 09:13:49	~7 min	`android`	🤖`apk` 📲
✔️	`c7c8628`	#12	2024-03-15 09:14:06	~8 min	`ios`	📱`ipa` 📲

✔️	`b4f379b`	#16	2024-03-19 10:34:28	~6 min	`tests`	📄`log`
✔️	`b4f379b`	#13	2024-03-19 10:35:46	~7 min	`android`	🤖`apk` 📲
✔️	`b4f379b`	#13	2024-03-19 10:35:59	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`b4f379b`	#13	2024-03-19 10:37:23	~9 min	`ios`	📱`ipa` 📲

✔️	`ef503e4`	#17	2024-03-21 09:42:23	~5 min	`tests`	📄`log`
✔️	`ef503e4`	#14	2024-03-21 09:42:31	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ef503e4`	#14	2024-03-21 09:43:49	~7 min	`android`	🤖`apk` 📲
✔️	`ef503e4`	#14	2024-03-21 09:46:30	~10 min	`ios`	📱`ipa` 📲

✔️	`9082dc9`	#15	2024-03-21 10:20:43	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`9082dc9`	#15	2024-03-21 10:21:14	~6 min	`android`	🤖`apk` 📲
✔️	`9082dc9`	#15	2024-03-21 10:24:23	~9 min	`ios`	📱`ipa` 📲
✔️	`9082dc9`	#19	2024-03-21 12:25:40	~5 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`0d0a324`	#16	2024-03-21 12:57:26	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`0d0a324`	#20	2024-03-21 12:57:33	~6 min	`tests`	📄`log`
✔️	`0d0a324`	#16	2024-03-21 12:57:53	~7 min	`android`	🤖`apk` 📲
✔️	`0d0a324`	#16	2024-03-21 13:00:33	~9 min	`ios`	📱`ipa` 📲

✔️	`8d15f30`	#21	2024-03-22 10:01:35	~5 min	`tests`	📄`log`
✔️	`8d15f30`	#17	2024-03-22 10:03:28	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`8d15f30`	#17	2024-03-22 10:03:55	~8 min	`android`	🤖`apk` 📲
✔️	`8d15f30`	#17	2024-03-22 10:05:23	~9 min	`ios`	📱`ipa` 📲

src/legacy/status_im/group_chats/core.cljs

src/status_im/contexts/chat/group_create/events.cljs

src/status_im/contexts/chat/group_create/view.cljs

yevh-berdnyk · 2024-03-12T17:09:00Z

hi @flexsurfer,
I've just pushed a small update for e2e tests.

Francesca-G

here's the design review :)

flexsurfer · 2024-03-20T13:13:58Z

the default name should be the list of members added
emojis shouldn't be allowed in the name

flexsurfer · 2024-03-21T09:36:49Z

@Francesca-G thank you , all feedback addressed cc @qoqobolo

Francesca-G

@flexsurfer here's the review
thank you 😊

flexsurfer · 2024-03-21T12:32:54Z

thank you @Francesca-G
@qoqobolo it seems like latest review related to title component, should we create a separate issue and merge this one ?

qoqobolo · 2024-03-21T12:42:35Z

@flexsurfer there is a new issue

ISSUE 8: [Android] Error and crash when adding an emoji to the name

video_2024-03-21_13-42-03.mp4

flexsurfer · 2024-03-21T12:53:41Z

thank you @qoqobolo fixed

qoqobolo · 2024-03-21T13:40:23Z

Thank you @flexsurfer, and hopefully last one:

ISSUE 9: The `Create group chat` button should be active right after opening the screen

Since we have the name field prefilled now, the user should be able to create a group chat without changing the name from the default one

video_2024-03-21_14-36-42.mp4

https://www.figma.com/file/7KIYbhoqNGAIFonE0w9TDz/Messages-for-Mobile?type=design&node-id=7026-527572&mode=design&t=Ifo5UvdMPhwTk3mE-4

flexsurfer · 2024-03-22T09:55:44Z

thank you @qoqobolo fixed

status-im-auto · 2024-03-22T11:40:44Z

19% of end-end tests have passed

Total executed tests: 48
Failed tests: 38
Expected to fail tests: 1
Passed tests: 9

IDs of failed tests: 702845,702840,702894,703086,702855,702947,702730,702775,702786,702745,702731,702844,702851,703202,704613,702841,702807,702839,702733,702808,702809,702838,702813,704615,702948,702859,703629,702869,702843,702782,702850,703391,702732,703297,702936,703495,702777,703194

IDs of expected to fail tests: 703503

Failed tests (38)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_group_chat_join_send_text_messages_push, id: 702807
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_group_chat_offline_pn, id: 702808
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
4. test_group_chat_pin_messages, id: 702732
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
5. test_group_chat_send_image_save_and_share, id: 703297
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
6. test_group_chat_mute_chat, id: 703495
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_community_contact_block_unblock_offline, id: 702894
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
3. test_community_mark_all_messages_as_read, id: 703086
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
5. test_community_unread_messages_badge, id: 702841
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
6. test_community_message_delete, id: 702839
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
7. test_community_message_send_check_timestamps_sender_username, id: 702838
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'` Device sessions Device 1: Steps, video, logs Failure screenshot
8. test_community_edit_delete_message_when_offline, id: 704615
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
9. test_community_one_image_send_reply, id: 702859
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
10. test_community_message_edit, id: 702843
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
11. test_community_several_images_send_reply, id: 703194
`Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
`Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_activity_center_contact_request_decline, id: 702850
`Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
3. test_add_contact_field_validation, id: 702777
`Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
`Test setup failed: activity_center/test_activity_center.py:245: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_navigation_jump_to, id: 702936
`Test setup failed: activity_center/test_activity_center.py:245: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
`Test setup failed: critical/test_deep_and_universal_links.py:13: in prepare_devices self.drivers, self.loop = create_shared_drivers(1) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_links_open_universal_links_from_chat, id: 704613
`Test setup failed: critical/test_deep_and_universal_links.py:13: in prepare_devices self.drivers, self.loop = create_shared_drivers(1) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
`Test setup failed: critical/chats/test_public_chat_browsing.py:807: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_community_mentions_push_notification, id: 702786
`Test setup failed: critical/chats/test_public_chat_browsing.py:807: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
3. test_community_markdown_support, id: 702809
`Test setup failed: critical/chats/test_public_chat_browsing.py:807: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
4. test_community_hashtag_links_to_community_channels, id: 702948
`Test setup failed: critical/chats/test_public_chat_browsing.py:807: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
5. test_community_join_when_node_owner_offline, id: 703629
`Test setup failed: critical/chats/test_public_chat_browsing.py:807: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_1_1_chat_message_reaction, id: 702730
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
4. test_1_1_chat_pin_messages, id: 702731
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
6. test_1_1_chat_push_emoji, id: 702813
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
8. test_1_1_chat_send_image_save_and_share, id: 703391
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:328: in create_shared_drivers raise e base_test_case.py:318: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestCommunityOneDeviceMerged:

1. test_community_undo_delete_message, id: 702869

Device 1: Tap on found: Button
Device 1: Find Button by xpath: //*[@text="Undo"]

critical/chats/test_public_chat_browsing.py:112: in test_community_undo_delete_message
    self.channel.element_by_text("Undo").click()
../views/base_element.py:92: in click
    element.click()
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:94: in click
    self._execute(Command.CLICK_ELEMENT)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute
    return self._parent.execute(command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 The element 'By.xpath: //*[@text="Undo"]' does not exist in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
E   Stacktrace:
E   io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //*[@text="Undo"]' does not exist in DOM anymore
E   	at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:117)
E   	at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153)
E   	at io.appium.uiautomator2.handler.Click.safeHandle(Click.java:36)
E   	at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271)
E   	at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
E   	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
E   	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
E   	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
E   	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
E   	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
E   	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
E   	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
E   	at java.lang.Thread.run(Thread.java:1012)

During handling of the above exception, another exception occurred:
critical/chats/test_public_chat_browsing.py:114: in test_community_undo_delete_message
    pytest.fail("Can't press Undo button, not enough time")
E   Failed: Can't press Undo button, not enough time

Device sessions

Device 1:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (9)

Click to expand

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2024-03-22T11:53:53Z

E2e failed because of the known random error, won't rerun it because of the queue.
@flexsurfer thanks a lot for your work! And thanks @Francesca-G for the reviews 🙏
PR can be merged.

flexsurfer self-assigned this Mar 4, 2024

flexsurfer force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch from 8f25e1b to 4dc0e37 Compare March 5, 2024 13:10

flexsurfer changed the title ~~[WIP] Feature/allow user to select a color for the group chat #18982~~ Feature/allow user to select a color for the group chat #18982 Mar 5, 2024

flexsurfer added the request-manual-qa label Mar 5, 2024

flexsurfer requested review from Parveshdhull and clauxx March 5, 2024 13:11

Parveshdhull reviewed Mar 5, 2024

View reviewed changes

clauxx reviewed Mar 5, 2024

View reviewed changes

src/status_im/contexts/chat/group_create/view.cljs Outdated Show resolved Hide resolved

src/status_im/contexts/chat/group_create/view.cljs Show resolved Hide resolved

src/status_im/contexts/chat/group_create/view.cljs Outdated Show resolved Hide resolved

flexsurfer force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch from 4f2860c to e48196e Compare March 6, 2024 09:58

flexsurfer requested review from Parveshdhull and clauxx March 6, 2024 09:58

flexsurfer added the design-review-required label Mar 6, 2024

flexsurfer force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch 2 times, most recently from 934cd99 to dbe0a31 Compare March 7, 2024 08:55

This comment was marked as resolved.

Sign in to view

clauxx approved these changes Mar 7, 2024

View reviewed changes

flexsurfer mentioned this pull request Mar 12, 2024

Feature/allow user to select a picture for a group chat #18983 #19128

Merged

qoqobolo self-assigned this Mar 12, 2024

qoqobolo force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch from dbe0a31 to 1ae01ce Compare March 12, 2024 11:46

This comment was marked as resolved.

Sign in to view

qoqobolo added the Tested - Issues label Mar 12, 2024

flexsurfer requested a review from churik as a code owner March 12, 2024 17:07

This comment was marked as resolved.

Sign in to view

flexsurfer force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch from cf845ad to 85c2ad1 Compare March 13, 2024 13:23

Francesca-G reviewed Mar 19, 2024

View reviewed changes

flexsurfer force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch from b4f379b to ef503e4 Compare March 21, 2024 09:36

flexsurfer requested a review from Francesca-G March 21, 2024 09:37

status-im deleted a comment from status-im-auto Mar 21, 2024

Francesca-G reviewed Mar 21, 2024

View reviewed changes

flexsurfer force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch from 9082dc9 to 0d0a324 Compare March 21, 2024 12:50

Allow user to select a color for the group chat #18982

8d15f30

flexsurfer force-pushed the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch from 0d0a324 to 8d15f30 Compare March 22, 2024 09:55

flexsurfer merged commit 6f07e80 into develop Mar 22, 2024
6 of 7 checks passed

flexsurfer deleted the feature/Allow_user_to_select_a_color_for_the_group_chat_#18982 branch March 22, 2024 13:10

cammellos pushed a commit that referenced this pull request Mar 25, 2024

Allow user to select a color for the group chat #18982 (#19088)

8e634ae

mmilad75 pushed a commit that referenced this pull request Apr 2, 2024

Allow user to select a color for the group chat #18982 (#19088)

6b32b2a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/allow user to select a color for the group chat #18982 #19088

Feature/allow user to select a color for the group chat #18982 #19088

flexsurfer commented Mar 4, 2024 •

edited

Loading

status-im-auto commented Mar 4, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

yevh-berdnyk commented Mar 12, 2024

This comment was marked as resolved.

Francesca-G left a comment

flexsurfer commented Mar 20, 2024 •

edited

Loading

flexsurfer commented Mar 21, 2024

Francesca-G left a comment

flexsurfer commented Mar 21, 2024

qoqobolo commented Mar 21, 2024

flexsurfer commented Mar 21, 2024

qoqobolo commented Mar 21, 2024

flexsurfer commented Mar 22, 2024

status-im-auto commented Mar 22, 2024

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

qoqobolo commented Mar 22, 2024

Feature/allow user to select a color for the group chat #18982 #19088

Feature/allow user to select a color for the group chat #18982 #19088

Conversation

flexsurfer commented Mar 4, 2024 • edited Loading

status-im-auto commented Mar 4, 2024 • edited Loading

Jenkins Builds

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

yevh-berdnyk commented Mar 12, 2024

This comment was marked as resolved.

Francesca-G left a comment

Choose a reason for hiding this comment

flexsurfer commented Mar 20, 2024 • edited Loading

flexsurfer commented Mar 21, 2024

Francesca-G left a comment

Choose a reason for hiding this comment

flexsurfer commented Mar 21, 2024

qoqobolo commented Mar 21, 2024

ISSUE 8: [Android] Error and crash when adding an emoji to the name

flexsurfer commented Mar 21, 2024

qoqobolo commented Mar 21, 2024

ISSUE 9: The Create group chat button should be active right after opening the screen

flexsurfer commented Mar 22, 2024

status-im-auto commented Mar 22, 2024

19% of end-end tests have passed

Failed tests (38)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (9)

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

qoqobolo commented Mar 22, 2024

flexsurfer commented Mar 4, 2024 •

edited

Loading

status-im-auto commented Mar 4, 2024 •

edited

Loading

flexsurfer commented Mar 20, 2024 •

edited

Loading

ISSUE 9: The `Create group chat` button should be active right after opening the screen