-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the mention highlighted area is only updated after reopening the chat #19076
Conversation
Jenkins BuildsClick to see older builds (20)
|
90% of end-end tests have passed
Failed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
d4a0d6a
to
0504b90
Compare
@Parveshdhull thank you for the fix! Please take a look at the issue. ISSUE 1 Shorter mention leaves empty space after updating name [IOS]IOS only. Reproducing on iPhone X, IOS 16.7.5 Preconditions: User A - any device, User B - IOS Steps:
Actual result: shorter mention leaves empty space after updating name. Fixes after chat re-opening. update_username.mp4 |
Hi @pavloburykh, Thank you very for testing the PR.
Weird, Is this issue only in PR? UPD: Got it now, so we updated that background but container is still same sized. |
c920485
to
50c6b1e
Compare
Issue 1 should be fixed now. |
50c6b1e
to
e4149bc
Compare
0% of end-end tests have passed
Failed tests (47)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
@Parveshdhull thanx for the fix. Ready for merge. |
e4149bc
to
18ab601
Compare
fixes #18432
status: ready