Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account edit confirmation button #18930

Merged
merged 11 commits into from
Mar 1, 2024
Merged

Fix account edit confirmation button #18930

merged 11 commits into from
Mar 1, 2024

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Feb 21, 2024 •
edited
Loading

fixes #18834
fixes #18791

Summary

On the account edit screen, always show the confirmation button, even if the input is focused. Also, fixed the issue with the text in the button.

Platforms

  • Android
  • iOS
Functional
  • edit account

Steps to test

  • Open Status
  • Create a profile
  • Navigate to the Wallet tab
  • Open account
  • Press account options
  • Press edit account

Demo

RPReplay_Final1708522337.2.MP4

status: ready

@clauxx clauxx self-assigned this Feb 21, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Feb 21, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (34)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b826aed #1 2024-02-21 12:38:29 ~7 min android 🤖apk 📲
✔️ b826aed #1 2024-02-21 12:38:45 ~7 min android-e2e 🤖apk 📲
✔️ b826aed #1 2024-02-21 12:39:26 ~8 min ios 📱ipa 📲
✔️ 26410d3 #3 2024-02-21 13:54:29 ~5 min tests 📄log
✔️ 26410d3 #3 2024-02-21 13:56:52 ~8 min ios 📱ipa 📲
✔️ 26410d3 #3 2024-02-21 13:57:14 ~8 min android-e2e 🤖apk 📲
✔️ 26410d3 #3 2024-02-21 13:57:37 ~9 min android 🤖apk 📲
❌ 1793161 #4 2024-02-21 16:05:01 ~1 min tests 📄log
✔️ 1793161 #4 2024-02-21 16:10:15 ~7 min android 🤖apk 📲
✔️ 1793161 #4 2024-02-21 16:10:23 ~7 min android-e2e 🤖apk 📲
✔️ 1793161 #4 2024-02-21 16:12:24 ~9 min ios 📱ipa 📲
✔️ 9aed540 #5 2024-02-22 11:07:46 ~6 min tests 📄log
✔️ 9aed540 #5 2024-02-22 11:08:39 ~6 min android-e2e 🤖apk 📲
✔️ 9aed540 #5 2024-02-22 11:10:00 ~8 min android 🤖apk 📲
✔️ 9aed540 #5 2024-02-22 11:10:03 ~8 min ios 📱ipa 📲
✔️ 4b4876c #6 2024-02-23 11:52:34 ~7 min android 🤖apk 📲
✔️ 4b4876c #6 2024-02-23 11:52:48 ~7 min android-e2e 🤖apk 📲
❌ 4b4876c #6 2024-02-23 11:54:12 ~8 min ios 📄log
✔️ 067afa0 #7 2024-02-23 12:01:23 ~4 min tests 📄log
✔️ 067afa0 #7 2024-02-23 12:04:18 ~7 min android-e2e 🤖apk 📲
✔️ 067afa0 #7 2024-02-23 12:04:22 ~7 min android 🤖apk 📲
✔️ 067afa0 #7 2024-02-23 12:05:14 ~8 min ios 📱ipa 📲
✔️ 5aff7e7 #8 2024-02-23 12:11:41 ~5 min tests 📄log
✔️ 5aff7e7 #8 2024-02-23 12:14:05 ~8 min android-e2e 🤖apk 📲
✔️ 5aff7e7 #8 2024-02-23 12:14:40 ~8 min android 🤖apk 📲
✔️ 5aff7e7 #8 2024-02-23 12:14:47 ~8 min ios 📱ipa 📲
✔️ 4fb7218 #9 2024-02-26 17:05:12 ~5 min tests 📄log
✔️ 4fb7218 #9 2024-02-26 17:06:50 ~6 min android 🤖apk 📲
✔️ 4fb7218 #9 2024-02-26 17:07:37 ~7 min android-e2e 🤖apk 📲
✔️ 4fb7218 #9 2024-02-26 17:09:00 ~9 min ios 📱ipa 📲
✔️ f1f286f #10 2024-02-29 10:46:18 ~6 min tests 📄log
✔️ f1f286f #10 2024-02-29 10:47:41 ~7 min android 🤖apk 📲
✔️ f1f286f #10 2024-02-29 10:48:19 ~8 min android-e2e 🤖apk 📲
✔️ f1f286f #10 2024-02-29 10:51:52 ~11 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6c5706b #11 2024-02-29 14:27:08 ~6 min tests 📄log
✔️ 6c5706b #11 2024-02-29 14:27:18 ~6 min android-e2e 🤖apk 📲
✔️ 6c5706b #11 2024-02-29 14:27:38 ~6 min android 🤖apk 📲
✔️ 6c5706b #11 2024-02-29 14:32:06 ~11 min ios 📱ipa 📲
✔️ 7da7be2 #13 2024-03-01 08:37:09 ~6 min tests 📄log
✔️ 7da7be2 #13 2024-03-01 08:38:05 ~7 min android 🤖apk 📲
✔️ 7da7be2 #13 2024-03-01 08:38:16 ~7 min android-e2e 🤖apk 📲
✔️ 7da7be2 #13 2024-03-01 08:41:03 ~10 min ios 📱ipa 📲

@J-Son89
Copy link
Contributor

J-Son89 commented Feb 21, 2024 •
edited
Loading

any chance of a photo/video to see this in action?

@clauxx
Copy link
Member Author

clauxx commented Feb 21, 2024

any chance of a photo/video to see this in action?

Added to the description

@clauxx clauxx requested a review from J-Son89 February 23, 2024 11:57
ulisesmac
ulisesmac approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@ulisesmac ulisesmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/status_im/contexts/wallet/common/screen_base/create_or_edit_account/view.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/wallet/common/screen_base/create_or_edit_account/view.cljs Outdated Show resolved Hide resolved
src/status_im/contexts/wallet/edit_account/view.cljs Outdated Show resolved Hide resolved
@clauxx clauxx force-pushed the cl-18791-edit-account-confirm-btn branch from 5aff7e7 to 4fb7218 Compare February 26, 2024 16:59
@clauxx clauxx requested a review from J-Son89 February 26, 2024 17:00
@status-im-auto
Copy link
Member

12% of end-end tests have passed

Total executed tests: 48
Failed tests: 41
Expected to fail tests: 1
Passed tests: 6

IDs of failed tests: 702809,702782,702733,702784,703194,702859,702777,702732,702813,703133,702957,702851,702840,703495,703086,702948,702894,702745,702783,702850,703297,704615,703496,702936,702855,703202,703391,702786,702839,702947,702838,702844,702843,702807,702731,702808,702730,702845,702958,703629,702841 

IDs of expected to fail tests: 703503

Failed tests (41)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:276: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    3. test_community_emoji_send_copy_paste_reply (TestRail link is not found)

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    6. test_community_edit_delete_message_when_offline (TestRail link is not found)

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    7. test_community_message_delete, id: 702839 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    8. test_community_message_send_check_timestamps_sender_username (TestRail link is not found)

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable (TestRail link is not found)

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    10. test_community_message_edit, id: 702843 

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    11. test_community_unread_messages_badge (TestRail link is not found)

    Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 

    Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496 

    Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages (TestRail link is not found)

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_group_chat_mute_chat, id: 703495 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    3. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    4. test_group_chat_reactions, id: 703202 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_group_chat_join_send_text_messages_push (TestRail link is not found)

    Device 3: Tap on found: Button
    Device 3: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    6. test_group_chat_offline_pn (TestRail link is not found)

    Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: activity_center/test_activity_center.py:246: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: activity_center/test_activity_center.py:246: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link (TestRail link is not found)

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    3. test_1_1_chat_push_emoji, id: 702813 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo (TestRail link is not found)

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_1_1_chat_edit_message (TestRail link is not found)

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    6. test_1_1_chat_send_image_save_and_share, id: 703391 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    7. test_1_1_chat_pin_messages, id: 702731 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    8. test_1_1_chat_message_reaction, id: 702730

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: activity_center/test_activity_center.py:393: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:393: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    activity_center/test_activity_center.py:190: in test_add_contact_field_validation
    self.home_2.handle_contact_request(new_username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'test user 123')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Find ChatsTab by accessibility id: chats-stack-tab
    Device 1: Tap on found: ChatsTab 

    activity_center/test_activity_center.py:112: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    3. test_activity_center_contact_request_decline (TestRail link is not found)

    Device 1: Tap on found: Button
    Device 1: Find Text by xpath: //*[@content-desc="pending-contact-requests-count"]/android.widget.TextView 

    activity_center/test_activity_center.py:69: in test_activity_center_contact_request_decline
    if self.home_1.pending_contact_request_text.text != '1':
../views/base_element.py:415: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    2. test_community_hashtag_links_to_community_channels (TestRail link is not found)

    Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    3. test_community_mentions_push_notification, id: 702786

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_community_leave (TestRail link is not found)

    Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'user_1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element



    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery (TestRail link is not found)

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (6)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message (TestRail link is not found)
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch (TestRail link is not found)
    Device sessions

    4. test_community_mute_community_and_channel (TestRail link is not found)
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    ibrkhalil
    ibrkhalil reviewed Feb 27, 2024
    View reviewed changes
    src/status_im/contexts/wallet/edit_account/view.cljs
    (rn/dismiss-keyboard!)
    (save-account {:account account
    :updated-key :name
    :new-value @edited-account-name}))]
    (fn []
    (let [{:keys [name emoji address color watch-only? default-account?]
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    nit: we can destructure name as wallet-name to avoid shadowing clojure.core/name

    @qoqobolo qoqobolo self-assigned this Feb 29, 2024
    @pavloburykh pavloburykh force-pushed the cl-18791-edit-account-confirm-btn branch from 4fb7218 to f1f286f Compare February 29, 2024 10:34
    @qoqobolo
    Copy link
    Contributor

    Thanks for the fixes @clauxx!
    PR can be merged.

    @clauxx clauxx force-pushed the cl-18791-edit-account-confirm-btn branch from f1f286f to 6c5706b Compare February 29, 2024 14:20
    clauxx added 11 commits March 1, 2024 10:29
    @clauxx
    fix: confirm button not visible
    a54f12a 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: edit account btn text
    aece8b5 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: removed bottom-action? prop
    6abfe5d 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: removed unused on-focus and on-blur props
    95d73c6 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    ref: using floating-button-page
    80a7979 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: linting error
    bf4aa13 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: hide btn when disabled and keyboard hidden
    36622b3 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: react warning and header height (again)
    00daa0f 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: replace padding prop with style
    174adc7 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    fix: addressed review comments
    2f10e99 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx
    chore: removed redundant :f> due to new reagent compiler
    7da7be2 
    Signed-off-by: Cristian Lungu <lungucristian95@gmail.com>
    @clauxx clauxx force-pushed the cl-18791-edit-account-confirm-btn branch from 43391cc to 7da7be2 Compare March 1, 2024 08:30
    @clauxx clauxx merged commit a4b9739 into develop Mar 1, 2024
    6 checks passed
    @clauxx clauxx deleted the cl-18791-edit-account-confirm-btn branch March 1, 2024 10:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ulisesmac ulisesmac ulisesmac approved these changes

    @ibrkhalil ibrkhalil ibrkhalil left review comments

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @BalogunofAfrica BalogunofAfrica Awaiting requested review from BalogunofAfrica

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @clauxx clauxx

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    8 participants
    @clauxx @status-im-auto @J-Son89 @qoqobolo @ajayesivan @smohamedjavid @ibrkhalil @ulisesmac