[Feature] Enable Sepolia testnet by default #18917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
smohamedjavid
force-pushed
the
feature/enable-sepolia-by-default
branch
4 times, most recently
from
dd2c9a5
to
e60d82a
Compare
smohamedjavid
changed the title
OmarBasem
reviewed
Feb 21, 2024
Comment on lines
+418
to
426
| (def ^:const ethereum-mainnet-chain-id 1) | ||
| (def ^:const ethereum-goerli-chain-id 5) | ||
| (def ^:const ethereum-sepolia-chain-id 11155111) | ||
| (def ^:const arbitrum-mainnet-chain-id 42161) | ||
| (def ^:const arbitrum-goerli-chain-id 421613) | ||
| (def ^:const arbitrum-sepolia-chain-id 421614) | ||
| (def ^:const optimism-mainnet-chain-id 10) | ||
| (def ^:const optimism-goerli-chain-id 420) | ||
| (def ^:const optimism-sepolia-chain-id 11155420) |
There was a problem hiding this comment.
Aren't these changes already being done in another PR?
There was a problem hiding this comment.
Yes, This is much needed for this PR. I have included it. Not sure when the other PR will go through testing.
We will fast-track this PR to get this merged.
smohamedjavid
force-pushed
the
feature/enable-sepolia-by-default
branch
from
e60d82a
to
f287f8b
Compare
OmarBasem
approved these changes
Feb 21, 2024
smohamedjavid
force-pushed
the
feature/enable-sepolia-by-default
branch
from
f287f8b
to
83603a2
Compare
92% of end-end tests have passedFailed tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
|
100% of end-end tests have passedPassed tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
hey @smohamedjavid, thank you for PR. no issues from my side. PR is ready to be merged |
J-Son89
approved these changes
Feb 22, 2024
status-im/status-go@23ee898...fa0e662 Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
status-im/status-go@23ee898...5304406 Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
feature/enable-sepolia-by-default
branch
from
83603a2
to
8ebda94
Compare
ibrkhalil
pushed a commit
that referenced
this pull request
Feb 25, 2024
This commit: - enables Sepolia test network by default - adds a toggle to switch to the Goerli test network Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR
status-go PR: status-im/status-go#4770
Testing notes
A complete testing of Wallet is appreciated.
Platforms
Steps to test
Profile > AdvancedTestnet mode(Make sure the toggleEnable Goerli as test networkis OFF)Enable Goerli as test networktogglestatus: ready