-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The last collectible is shown for a moment while opening a new collectible #18750 #18793
Merged
mmilad75
merged 17 commits into
develop
from
milad/18750-clear-last-collectible-on-leave
Feb 20, 2024
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
95ecadc
fix issue
mmilad75 e4938af
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 e50d432
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 cf31c6d
move navigation to the event
mmilad75 096f093
move clearing to hook
mmilad75 003a522
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 5666637
revert scroll_page
mmilad75 254b017
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 cc883df
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 9f9c58f
resolve comment
mmilad75 ba1a6f6
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 ecad567
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 eb36e09
fix duplicate navigation
mmilad75 c24f436
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 f1ff2d3
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 1491c3a
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 0da962e
Merge branch 'develop' into milad/18750-clear-last-collectible-on-leave
mmilad75 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this empty vector can be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to run the code only in componentWillUnmount