-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The last collectible is shown for a moment while opening a new collectible #18750 #18793
Changes from 2 commits
95ecadc
e4938af
e50d432
cf31c6d
096f093
003a522
5666637
254b017
cc883df
9f9c58f
ba1a6f6
ecad567
eb36e09
c24f436
f1ff2d3
1491c3a
0da962e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,7 +122,8 @@ | |
{:keys [collectibles]} response | ||
collectible (first collectibles)] | ||
(if collectible | ||
{:fx [[:dispatch [:wallet/store-last-collectible-details collectible]]]} | ||
{:fx [[:dispatch [:wallet/store-last-collectible-details collectible]] | ||
[:dispatch [:navigate-to :wallet-collectible]]]} | ||
(log/error "failed to get collectible details" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey @mmilad75 thanks for applying the suggestion, but I think we could delay the navigation even more, inside the event that is storing: wdyt? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure 👍 Let me apply it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done @ulisesmac |
||
{:event :wallet/get-collectible-details-done | ||
:response response}))))) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this empty vector can be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to run the code only in componentWillUnmount