feat: new keypair: mnemonic, address, KP name screen #18790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (80)
|
OmarBasem
force-pushed
the
wallet/generate-keypair
branch
2 times, most recently
from
1cdc9f8
to
af27997
Compare
OmarBasem
requested review from
smohamedjavid,
J-Son89,
vkjr,
mmilad75,
shivekkhurana and
briansztamfater
OmarBasem
changed the title
OmarBasem
changed the title
J-Son89
reviewed
Feb 14, 2024
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/backup_recovery_phrase/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/backup_recovery_phrase/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/check_your_backup/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/check_your_backup/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/keypair_name/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/keypair_name/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/keypair_name/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/keypair_name/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
src/status_im/contexts/wallet/create_account/new_keypair/keypair_name/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 14, 2024
J-Son89
reviewed
Feb 14, 2024
J-Son89
reviewed
Feb 14, 2024
J-Son89
reviewed
Feb 14, 2024
OmarBasem
force-pushed
the
wallet/generate-keypair
branch
from
71a6612
to
86ff7d5
Compare
OmarBasem
force-pushed
the
wallet/generate-keypair
branch
from
bc66fb9
to
3ca7a11
Compare
Nope. It will be added when the animations are ready from the design team because nothing happens on that screen beyond the illustrations which is only for educational purposes. |
ibrkhalil
pushed a commit
that referenced
this pull request
Feb 25, 2024
feat: new keypair: mnemonic, address, KP name screen (#18790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18670
This PR implements the following in the new keypair flow:
Finalizing the wallet account creation from the new keypair will be addressed in a separate issue: #18813
status-go PR: status-im/status-go#4712
Designs
Demo:
https://github.com/status-im/status-mobile/assets/29354102/cc3351a6-cab9-4c2c-b74e-56288eb1ba0f