-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#18545] Add missing linear gradient to dark themed cards #18689
Conversation
Just a small PR |
cd29df7
to
80e26e2
Compare
(colors/resolve-color customization-color theme 6) | ||
colors/neutral-95 | ||
theme)) | ||
(colors/theme-colors (colors/resolve-color customization-color theme 6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve colors handles theming anyway.
(colors/resolve-color customization-color theme 6)
- is all you need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @J-Son89
Jenkins BuildsClick to see older builds (4)
|
80e26e2
to
11a247e
Compare
@J-Son89 Probably this can be merged without QA and design review? It is just a missing gradient color |
@pavloburykh wdyt? Looking at the changes it seems quite safe, it is in fact just changing some colors |
0% of end-end tests have passed
Failed tests (47)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
|
@J-Son89 let's merge it. Ignore test results for now, as e2e are broken. |
Fix the `:ellipsis-mode` property
11a247e
to
3c7aaf7
Compare
fixes #18545
This PR also fix the
:ellipsis-mode
property, it had a typonow:
Steps to test
status: ready