Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated data-item, monospaced & aligned address #18008

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Updated data-item, monospaced & aligned address #18008

merged 4 commits into from
Dec 1, 2023

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Nov 27, 2023

fixes #17944

Also updates data-item because the previous API was very confusing — the field was called description while in fact it was an indicator of subtitle type (so it only affected how the subtitle looked)

status: ready

@alwx alwx self-assigned this Nov 27, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Nov 27, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (10)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3e3fa49 #1 2023-11-27 17:38:03 ~6 min android-e2e 🤖apk 📲
✔️ 3e3fa49 #1 2023-11-27 17:38:22 ~6 min ios 📱ipa 📲
✔️ de9b8a9 #2 2023-11-27 17:44:54 ~6 min android 🤖apk 📲
✔️ de9b8a9 #2 2023-11-27 17:45:12 ~6 min android-e2e 🤖apk 📲
✔️ de9b8a9 #2 2023-11-27 17:49:30 ~10 min tests 📄log
✔️ de9b8a9 #2 2023-11-27 17:51:40 ~13 min ios 📱ipa 📲
❌ 1c62067 #3 2023-11-28 07:20:39 ~2 min tests 📄log
✔️ 1c62067 #3 2023-11-28 07:24:44 ~6 min android-e2e 🤖apk 📲
✔️ 1c62067 #3 2023-11-28 07:24:49 ~6 min android 🤖apk 📲
✔️ 1c62067 #3 2023-11-28 07:24:49 ~6 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 919e022 #4 2023-11-30 12:25:34 ~7 min android-e2e 🤖apk 📲
✔️ 919e022 #4 2023-11-30 12:25:36 ~7 min android 🤖apk 📲
✔️ 919e022 #4 2023-11-30 12:29:18 ~10 min tests 📄log
✔️ 919e022 #4 2023-11-30 12:31:07 ~12 min ios 📱ipa 📲
✔️ 7eb3285 #5 2023-12-01 08:47:09 ~7 min android-e2e 🤖apk 📲
✔️ 7eb3285 #5 2023-12-01 08:50:57 ~11 min android 🤖apk 📲
✔️ 7eb3285 #5 2023-12-01 08:53:13 ~13 min ios 📱ipa 📲
✔️ 7eb3285 #5 2023-12-01 08:56:53 ~17 min tests 📄log

vkjr
vkjr reviewed Nov 28, 2023
View reviewed changes
src/quo/components/settings/data_item/view.cljs
[{:keys [theme title status size blur? description custom-subtitle icon subtitle label icon-color
customization-color network-image
emoji]
"The description can either be given as a string `subtitle-type` or a component `custom-subtitle`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably subtitle-type should be changed to subtitle here, because subtitle-type is not string, if I understood the component right.

@status-im-auto
Copy link
Member

82% of end-end tests have passed

Total executed tests: 45
Failed tests: 4
Expected to fail tests: 4
Passed tests: 37

IDs of failed tests: 702786,702782,702859,703133 

IDs of expected to fail tests: 702732,702808,703503,702731

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 0 instead of 2
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859

    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'reply to image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:499: in test_community_one_image_send_reply
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image message reaction is not shown for the sender



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:901: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Can not edit a message with a mention
E    Edited message is not shown correctly for the (receiver) admin



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 2: Find OpenInStatusButton by xpath: //*[@text="Open in Status"]
    Device 2: Tap on found: OpenInStatusButton 

    critical/chats/test_1_1_public_chats.py:174: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 URL was not opened from 1-1 chat



    Device sessions

    Expected to fail tests (4)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (37)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_add_contact_field_validation, id: 702777
    Device sessions

    3. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_mute_community_and_channel, id: 703382
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    3. test_community_message_edit, id: 702843
    Device sessions

    4. test_community_several_images_send_reply, id: 703194
    Device sessions

    5. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    9. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @alwx thank you for the PR. Please don't forget to add "request-manual-qa" label for those PRs that request manual testing. Otherwise it may cause delay with PR testing.

    @pavloburykh pavloburykh self-assigned this Nov 30, 2023
    @pavloburykh
    Copy link
    Contributor

    @alwx tested and ready for merge.

    @alwx alwx merged commit 52f7fc5 into develop Dec 1, 2023
    6 checks passed
    @alwx alwx deleted the bugfix/17944 branch December 1, 2023 09:03
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @alwx @yevh-berdnyk
    Updated data-item, monospaced & aligned address (#18008)
    603c7e6 
    * Upd

* Fix
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @vkjr vkjr vkjr approved these changes

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @alwx alwx

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    The address is not aligned with inputed address during 'address to watch' creation
    5 participants
    @alwx @status-im-auto @pavloburykh @vkjr @flexsurfer