Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: Keypair follow up #17953

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Wallet: Keypair follow up #17953

merged 4 commits into from
Nov 23, 2023

Conversation

OmarBasem
Copy link
Contributor

fixes: #17886

This PR is a follow-up to fix 2 UI issues in keypair screen.

  • Small dot alignment in keypair subtitle between address and on device text
  • Bottom button alignment

unnamed

@status-im-auto
Copy link
Member

status-im-auto commented Nov 21, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0733e6e #2 2023-11-21 07:18:15 ~6 min android 🤖apk 📲
✔️ 0733e6e #2 2023-11-21 07:18:26 ~6 min ios 📱ipa 📲
✔️ 0733e6e #2 2023-11-21 07:20:43 ~8 min android-e2e 🤖apk 📲
0733e6e #2 2023-11-21 07:22:55 ~10 min tests 📄log
✔️ 35987dc3 #3 2023-11-23 04:06:03 ~6 min android-e2e 🤖apk 📲
✔️ 35987dc3 #3 2023-11-23 04:06:08 ~6 min android 🤖apk 📲
✔️ 35987dc3 #3 2023-11-23 04:12:29 ~13 min ios 📱ipa 📲
✔️ 35987dc3 #4 2023-11-23 05:54:06 ~9 min tests 📄log

@OmarBasem OmarBasem requested a review from vkjr November 21, 2023 10:52
Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨

@OmarBasem OmarBasem merged commit dbc8df2 into develop Nov 23, 2023
6 checks passed
@OmarBasem OmarBasem deleted the wallet/keypair-followup branch November 23, 2023 06:00
yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
* Wallet: Keypair follow up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Wallet: design review - fix dot in keypair component
4 participants