-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet: account real data #17821
Merged
Merged
Wallet: account real data #17821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
added
the
wallet: Accounts
all issues for the accounts page of the wallet
label
Nov 6, 2023
OmarBasem
requested review from
vkjr,
briansztamfater,
smohamedjavid,
J-Son89,
mmilad75 and
tumanov-alex
November 6, 2023 06:48
OmarBasem
force-pushed
the
wallet/account-real-data
branch
from
November 6, 2023 06:49
23ffb85
to
a3d61ec
Compare
Jenkins BuildsClick to see older builds (75)
|
ibrkhalil
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
J-Son89
reviewed
Nov 6, 2023
ulisesmac
reviewed
Nov 6, 2023
OmarBasem
force-pushed
the
wallet/account-real-data
branch
from
November 7, 2023 07:11
ac447c4
to
c2e0e12
Compare
@J-Son89 @ulisesmac @vkjr @smohamedjavid thanks for your reviews I have refactored parsing the tokens into its own sub |
vkjr
reviewed
Nov 7, 2023
vkjr
reviewed
Nov 7, 2023
vkjr
reviewed
Nov 7, 2023
vkjr
reviewed
Nov 7, 2023
OmarBasem
force-pushed
the
wallet/account-real-data
branch
from
November 8, 2023 10:21
1f89e7e
to
dbd4031
Compare
OmarBasem
force-pushed
the
wallet/account-real-data
branch
from
December 5, 2023 05:29
9c1e1d6
to
9dc9285
Compare
yevh-berdnyk
pushed a commit
that referenced
this pull request
Dec 8, 2023
* wallet: account real data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
request-manual-qa
test cases added
Tested - OK
wallet: Accounts
all issues for the accounts page of the wallet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #17764
This PR implements usage of real data to display tokens inside account screen.
There is no UI changes.