Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename to wallet-legacy #17673

Merged
merged 2 commits into from
Oct 19, 2023
Merged

rename to wallet-legacy #17673

merged 2 commits into from
Oct 19, 2023

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Oct 18, 2023 •
edited
Loading

rename to wallet-legacy

we need to make sure in review that only app-db and subscriptions were affected

@flexsurfer flexsurfer self-assigned this Oct 18, 2023
@flexsurfer flexsurfer changed the title rename to wallet-lagacy rename to wallet-legacy Oct 18, 2023
J-Son89
J-Son89 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @flexsurfer! 🙏

J-Son89
J-Son89 reviewed Oct 18, 2023
View reviewed changes
src/status_im2/subs/root.cljs
(reg-root-key-sub :wallet/swap-to-token-amount :wallet/swap-to-token-amount)
(reg-root-key-sub :wallet/swap-advanced-mode? :wallet/swap-advanced-mode?)

;; Wallet 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;; Wallet 2
(reg-root-key-sub :wallet-2/scanned-address :wallet-2/scanned-address)

should be restored - @briansztamfater added this but I think the rebase got skewed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch fixed, btw i renamed it to wallet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@status-im-auto
Copy link
Member

status-im-auto commented Oct 18, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 09f6dcd #1 2023-10-18 09:14:36 ~5 min android 🤖apk 📲
✔️ 09f6dcd #1 2023-10-18 09:19:19 ~10 min android-e2e 🤖apk 📲
✔️ 09f6dcd #1 2023-10-18 09:19:31 ~10 min tests 📄log
✔️ 09f6dcd #1 2023-10-18 09:21:26 ~12 min ios 📱ipa 📲
✔️ 4f86af6 #2 2023-10-18 09:31:29 ~7 min ios 📱ipa 📲
✔️ 4f86af6 #2 2023-10-18 09:34:43 ~10 min android-e2e 🤖apk 📲
✔️ 4f86af6 #2 2023-10-18 09:35:03 ~10 min tests 📄log
✔️ 4f86af6 #2 2023-10-18 09:35:40 ~11 min android 🤖apk 📲

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 43
Failed tests: 6
Passed tests: 37

IDs of failed tests: 702732,703495,702948,702786,702731,702808

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:473: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chats tab button is 1 after unmute, but should be 2



    Device sessions

    3. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:309: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    # STEP: Device 1 sends a message with hashtag in the dogs channel
    Device 1: Sending message '#cats' 

    critical/chats/test_public_chat_browsing.py:984: in test_community_hashtag_links_to_community_channels
    self.channel_1.send_message(message_with_hashtag)
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; 
 RemoteDisconnected



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:874: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Can not edit a message with a mention



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (37)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    smohamedjavid
    smohamedjavid approved these changes Oct 18, 2023
    View reviewed changes
    Copy link
    Member

    @smohamedjavid smohamedjavid left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @VolodLytvynenko VolodLytvynenko self-assigned this Oct 18, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    hi @flexsurfer, thank you for the PR! Before we continue with testing, could you please describe any scenario and expected behavior introduced in this PR, or if there isn't new functionality, provide examples of areas that might be affected by this PR? Thanx!

    @flexsurfer
    Copy link
    Member Author

    hey @VolodLytvynenko there is no changes in functionality, only renaming variables in the code, the affected area old wallet, thanks

    briansztamfater
    briansztamfater approved these changes Oct 18, 2023
    View reviewed changes
    Copy link
    Member

    @briansztamfater briansztamfater left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🚀

    ulisesmac
    ulisesmac approved these changes Oct 18, 2023
    View reviewed changes
    Copy link
    Contributor

    @ulisesmac ulisesmac left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks for this PR!! :) :) :) :)

    @VolodLytvynenko
    Copy link
    Contributor

    hi @flexsurfer, thank you for your work. PR is ready to be merged

    @flexsurfer flexsurfer merged commit 4a8a23a into develop Oct 19, 2023
    6 checks passed
    @flexsurfer flexsurfer deleted the feature/wallet-regacy branch October 19, 2023 11:50
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ulisesmac ulisesmac ulisesmac approved these changes

    @OmarBasem OmarBasem OmarBasem approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @briansztamfater briansztamfater briansztamfater approved these changes

    @rasom rasom rasom approved these changes

    @vkjr vkjr Awaiting requested review from vkjr

    @tumanov-alex tumanov-alex Awaiting requested review from tumanov-alex

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @flexsurfer flexsurfer

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    9 participants
    @flexsurfer @status-im-auto @VolodLytvynenko @rasom @briansztamfater @smohamedjavid @J-Son89 @OmarBasem @ulisesmac