Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17288] refactor: migrate previews to new api #17624

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[#17288] refactor: migrate previews to new api #17624

merged 1 commit into from
Oct 16, 2023

Conversation

mohsen-ghafouri
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri commented Oct 12, 2023 •
edited
Loading

to accomplish #17288

None of the basic components were touched

migrated preview screens:

  • settings
  • share

status: ready

@mohsen-ghafouri mohsen-ghafouri self-assigned this Oct 12, 2023
@mohsen-ghafouri mohsen-ghafouri mentioned this pull request Oct 12, 2023
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Oct 12, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 338b6de #1 2023-10-12 10:30:33 ~6 min android-e2e 🤖apk 📲
✔️ 338b6de #1 2023-10-12 10:30:52 ~6 min ios 📱ipa 📲
✔️ 338b6de #1 2023-10-12 10:30:59 ~6 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0918639 #2 2023-10-12 10:41:51 ~9 min ios 📱ipa 📲
✔️ 0918639 #2 2023-10-12 10:43:10 ~10 min android-e2e 🤖apk 📲
✔️ 0918639 #2 2023-10-12 10:43:11 ~10 min android 🤖apk 📲
✔️ 0918639 #2 2023-10-12 10:43:25 ~10 min tests 📄log
✔️ 3e2e853 #3 2023-10-16 08:46:42 ~5 min android-e2e 🤖apk 📲
✔️ 3e2e853 #3 2023-10-16 08:47:37 ~6 min ios 📱ipa 📲
✔️ 3e2e853 #3 2023-10-16 08:50:50 ~9 min android 🤖apk 📲
✔️ 3e2e853 #3 2023-10-16 08:51:01 ~9 min tests 📄log

@mohsen-ghafouri
Copy link
Contributor Author

@status-im/mobile-qa the changes are just related to quo2 preview screens.

@status-im-auto
Copy link
Member

53% of end-end tests have passed

Total executed tests: 43
Failed tests: 20
Passed tests: 23

IDs of failed tests: 702782,703194,702859,702732,702840,703495,703086,702894,702783,703297,703202,702786,702839,702838,702844,702843,702807,702731,702808,702841

Failed tests (20)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 
    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    3. test_community_emoji_send_copy_paste_reply, id: 702840 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    6. test_community_message_delete, id: 702839 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    7. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Looking for a message by text: open community
    Device 2: Find BaseElement by xpath: //*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View'] 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    9. test_community_message_edit, id: 702843 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    10. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/chats/test_public_chat_browsing.py:305: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495 

    Test setup failed: ../views/home_view.py:373: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 3: Button by xpath: `//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

During handling of the above exception, another exception occurred:
critical/chats/test_group_chat.py:54: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:383: in handle_contact_request
    self.driver.fail("No contact request received from %s" % username)
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
E   Failed: Device 3: No contact request received from user admin



    3. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: ../views/home_view.py:373: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 3: Button by xpath: `//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

During handling of the above exception, another exception occurred:
critical/chats/test_group_chat.py:54: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:383: in handle_contact_request
    self.driver.fail("No contact request received from %s" % username)
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
E   Failed: Device 3: No contact request received from user admin



    4. test_group_chat_reactions, id: 703202 

    Test setup failed: ../views/home_view.py:373: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 3: Button by xpath: `//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

During handling of the above exception, another exception occurred:
critical/chats/test_group_chat.py:54: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:383: in handle_contact_request
    self.driver.fail("No contact request received from %s" % username)
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
E   Failed: Device 3: No contact request received from user admin



    5. test_group_chat_join_send_text_messages_push, id: 702807

    Device 3: Tap on found: Button
    Device 3: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: ../views/home_view.py:373: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 3: Button by xpath: `//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

During handling of the above exception, another exception occurred:
critical/chats/test_group_chat.py:54: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:383: in handle_contact_request
    self.driver.fail("No contact request received from %s" % username)
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
E   Failed: Device 3: No contact request received from user admin



    Device sessions

    6. test_group_chat_offline_pn, id: 702808 

    Test setup failed: ../views/home_view.py:373: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 3: Button by xpath: `//*[contains(@text, 'user admin')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

During handling of the above exception, another exception occurred:
critical/chats/test_group_chat.py:54: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:44: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:383: in handle_contact_request
    self.driver.fail("No contact request received from %s" % username)
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
E   Failed: Device 3: No contact request received from user admin

    [[Data delivery issue]]

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:601: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Wait for text element EmojisNumber to be equal to 1
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:157: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_1.chat_element_by_text(url_message).emojis_below_message().wait_for_element_text(1)
../views/base_element.py:172: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EmojisNumber by xpath: `//*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:874: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Can not edit a message with a mention



    Device sessions

    Passed tests (23)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Oct 13, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    Hi @mohsen-ghafouri thank you for ping. I'm checking e2e

    @status-im-auto
    Copy link
    Member

    86% of end-end tests have passed

    Total executed tests: 43
Failed tests: 6
Passed tests: 37

    IDs of failed tests: 702732,703495,702783,702786,702731,702808

    Failed tests (6)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:473: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter near chats tab button is 1 after unmute, but should be 2



    Device sessions

    3. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:309: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:874: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Can not edit a message with a mention



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:601: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (37)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_discovery, id: 703503
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    6. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    @mohsen-ghafouri e2e are good. Thank you for your work
    @Francesca-G could you take a look at this PR?

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @mohsen-ghafouri A design review is not required. PR is ready to be merged if no need for QA manual testing

    @mohsen-ghafouri
    Copy link
    Contributor Author

    Thanks @VolodLytvynenko

    @mohsen-ghafouri mohsen-ghafouri merged commit ea8b8d1 into develop Oct 16, 2023
    6 checks passed
    @mohsen-ghafouri mohsen-ghafouri deleted the migrate/previews-part-five branch October 16, 2023 08:53
    ibrkhalil pushed a commit that referenced this pull request Oct 17, 2023
    @mohsen-ghafouri @ibrkhalil
    [#17288] refactor: migrate previews to new api (#17624)
    b988507
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @VolodLytvynenko VolodLytvynenko

    @mohsen-ghafouri mohsen-ghafouri

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @mohsen-ghafouri @status-im-auto @VolodLytvynenko @ilmotta