feat: support new universal/deep link format #17480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yqrashawn
changed the title
Jenkins BuildsClick to see older builds (108)
|
yqrashawn
changed the title
yqrashawn
force-pushed
the
feat/support-new-universal-deep-link
branch
8 times, most recently
from
da3d5a8
to
96c3a6d
Compare
yqrashawn
force-pushed
the
feat/support-new-universal-deep-link
branch
from
96c3a6d
to
1f62aeb
Compare
yqrashawn
force-pushed
the
feat/support-new-universal-deep-link
branch
from
1f62aeb
to
2c9f935
Compare
yqrashawn
force-pushed
the
feat/support-new-universal-deep-link
branch
3 times, most recently
from
c75e518
to
65bf372
Compare
cammellos
approved these changes
Oct 9, 2023
yqrashawn
force-pushed
the
feat/support-new-universal-deep-link
branch
from
4500e7e
to
3d7636c
Compare
|
Hi @qoqobolo, ready to test again the anyway, it's not in the scope of this PR, and it's recorded at #17550 |
26% of end-end tests have passedNot executed tests (2)Failed tests (30)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (11)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
|
58% of end-end tests have passedNot executed tests (2)Failed tests (15)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (25)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
|
80% of end-end tests have passedFailed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (12)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
Samyoul
approved these changes
Oct 20, 2023
|
Tested in this PR:
Awesome job @yqrashawn, PR can be merged 🚀 |
join.status.im -> status.app status-im -> status-app
Signed-off-by: yqrashawn <namy.19@gmail.com>
Signed-off-by: yqrashawn <namy.19@gmail.com>
didn't remove the route handler we might need these in the future Signed-off-by: yqrashawn <namy.19@gmail.com>
yqrashawn
force-pushed
the
feat/support-new-universal-deep-link
branch
from
3d7636c
to
79693ed
Compare
ibrkhalil
added a commit
that referenced
this pull request
Oct 23, 2023
This reverts commit 04a7f76.
yevh-berdnyk
pushed a commit
that referenced
this pull request
Dec 8, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #17431
Summary
this is a starting PR to support new link format
following issue for this feature:
crew: https://www.notion.so/Chainmakers-b78f651f5aa04539ad4ac2a93218d1a7?pvs=4
join.status.imlinks in docs are not changed,status.appis not ready for production.scope of this PR:
status-app://andhttps://status.appurlopen the first one in safari should trigger open the app and jump to the specific view
open second one in app (from chat) should trigger jump to the specific view
https://status.appin safari -> auto open app and jumpdetail:
status-im://->status-app://https://join.status.im->https://status.appstatus-mobile/src/status_im/ui/screens/browser/site_blocked/views.cljs
Line 24 in 1e68a16
https://status.app/u/G10A4B0JdgwyRww90WXtnP1oNH1ZLQNM0yX0Ja9YyAMjrqSZIYINOHCbFhrnKRAcPGStPxCMJDSZlGCKzmZrJcimHY8BbcXlORrElv_BbQEegnMDPx1g9C5VVNl0fE4y#zQ3shwQPhRuDJSjVGVBnTjCdgXy5i9WQaeVPdGJD6yTarJQSj
https://status.app/c/iyKACkQKB0Rvb2RsZXMSJ0NvbG9yaW5nIHRoZSB3b3JsZCB3aXRoIGpveSDigKIg4bSXIOKAohiYohsiByMxMzFEMkYqAwEhMwM=#zQ3shYSHp7GoiXaauJMnDcjwU2yNjdzpXLosAWapPS4CFxc11
https://status.app/cc/G54AAKwObLdpiGjXnckYzRcOSq0QQAS_CURGfqVU42ceGHCObstUIknTTZDOKF3E8y2MSicncpO7fTskXnoACiPKeejvjtLTGWNxUhlT7fyQS7Jrr33UVHluxv_PLjV2ePGw5GQ33innzeK34pInIgUGs5RjdQifMVmURalxxQKwiuoY5zwIjixWWRHqjHM=#zQ3shYSHp7GoiXaauJMnDcjwU2yNjdzpXLosAWapPS4CFxc11
status-app://links should have the same behavior,https://status.app/c/...->status-app://c/...b/,p/,cr/..., keep their handler for futurestatus-mobile/src/status_im/router/core.cljs
Line 49 in ef3798a
Testing notes
Note:
for links that jump to unfetched community, the code call status-go to fetch it from mailserver, but it takes a long time for the data to show up
related desktop issue status-im/status-desktop#12188
not sure if this happens to anyone else or this is a known issue
might be related to how long the community has been created
Platforms
Areas that maybe impacted
anything related to
join.status.imandstatus-im:videos:
jump to profile
remember link and jump to community after login, community not yet loaded
status: ready