Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo2: Token Input followup #17419

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Quo2: Token Input followup #17419

merged 5 commits into from
Oct 2, 2023

Conversation

OmarBasem
Copy link
Contributor

fixes: #16856

This PR is a follow up to #16819. It adds Network Tag component to Token Input component.

Designs

@OmarBasem OmarBasem self-assigned this Sep 26, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 26, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ab55bd2 #1 2023-09-26 10:14:46 ~6 min android-e2e 🤖apk 📲
✔️ ab55bd2 #1 2023-09-26 10:15:14 ~6 min android 🤖apk 📲
✔️ ab55bd2 #1 2023-09-26 10:16:28 ~7 min ios 📱ipa 📲
✔️ ab55bd2 #1 2023-09-26 10:18:36 ~10 min tests 📄log
✔️ 9fe6ee2 #2 2023-09-27 08:29:00 ~6 min ios 📱ipa 📲
✔️ 9fe6ee2 #2 2023-09-27 08:31:04 ~8 min android-e2e 🤖apk 📲
✔️ 9fe6ee2 #2 2023-09-27 08:31:19 ~9 min android 🤖apk 📲
✔️ 9fe6ee2 #2 2023-09-27 08:32:58 ~10 min tests 📄log
✔️ 9265b48 #3 2023-09-28 03:32:26 ~6 min android-e2e 🤖apk 📲
✔️ 9265b48 #3 2023-09-28 03:32:36 ~6 min android 🤖apk 📲
✔️ 9265b48 #3 2023-09-28 03:32:49 ~6 min ios 📱ipa 📲
✔️ 9265b48 #3 2023-09-28 03:34:58 ~8 min tests 📄log
✔️ 8a0dd68 #4 2023-09-28 11:29:07 ~6 min android-e2e 🤖apk 📲
✔️ 8a0dd68 #4 2023-09-28 11:29:07 ~6 min android 🤖apk 📲
✔️ 8a0dd68 #4 2023-09-28 11:31:36 ~8 min tests 📄log
✔️ 8a0dd68 #4 2023-09-28 11:32:45 ~9 min ios 📱ipa 📲
✔️ 1b08d2b #5 2023-09-28 11:47:50 ~6 min android-e2e 🤖apk 📲
✔️ 1b08d2b #5 2023-09-28 11:47:54 ~6 min android 🤖apk 📲
✔️ 1b08d2b #5 2023-09-28 11:49:24 ~7 min ios 📱ipa 📲
✔️ 1b08d2b #5 2023-09-28 11:50:09 ~8 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4eb2b08 #6 2023-09-28 13:28:12 ~6 min ios 📱ipa 📲
✔️ 4eb2b08 #6 2023-09-28 13:31:11 ~9 min android 🤖apk 📲
✔️ 4eb2b08 #6 2023-09-28 13:31:20 ~9 min android-e2e 🤖apk 📲
✔️ 4eb2b08 #6 2023-09-28 13:32:11 ~10 min tests 📄log
✔️ 4f0a515 #7 2023-10-02 04:47:31 ~5 min android-e2e 🤖apk 📲
✔️ 4f0a515 #7 2023-10-02 04:48:29 ~6 min ios 📱ipa 📲
✔️ 4f0a515 #7 2023-10-02 04:49:47 ~7 min android 🤖apk 📲
✔️ 4f0a515 #7 2023-10-02 04:51:29 ~9 min tests 📄log

@OmarBasem
Copy link
Contributor Author

@Francesca-G a design review please :)

@status-im-auto
Copy link
Member

63% of end-end tests have passed

Total executed tests: 43
Failed tests: 16
Passed tests: 27

IDs of failed tests: 702809,702784,702732,702957,702948,702783,703503,703496,703202,702786,702807,702731,702808,702845,702958,703382

Failed tests (16)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/test_public_chat_browsing.py:1052: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/test_public_chat_browsing.py:1052: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    3. test_community_mentions_push_notification, id: 702786

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'hey' 

    Test setup failed: critical/test_public_chat_browsing.py:1052: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    4. test_community_leave, id: 702845 

    Test setup failed: critical/test_public_chat_browsing.py:1052: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Find Button by xpath: //*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]
    Device 2: Find Button by accessibility id: close-activity-center 

    Test setup failed: medium/test_activity_center.py:307: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:377: in handle_contact_request
    self.close_activity_centre.wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: medium/test_activity_center.py:307: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:377: in handle_contact_request
    self.close_activity_centre.wait_for_rendering_ended_and_click()
../views/base_element.py:155: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 

    Test setup failed: critical/chats/test_1_1_public_chats.py:1361: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 1: ChatMessageInput element not found
    Device 1: Sending message 'hey' 

    Test setup failed: critical/chats/test_1_1_public_chats.py:1361: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496 

    Test setup failed: critical/chats/test_1_1_public_chats.py:1361: in prepare_devices
    self.chat_1.send_message('hey')
../views/chat_view.py:995: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_reactions, id: 703202

    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView
    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView 

    critical/chats/test_group_chat.py:252: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2)
../views/base_element.py:181: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:179: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 2: `1` is not equal to expected `2` in 30 sec



    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:228: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:235: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    4. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline
E    message from new member if not shown for device 1



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    2. test_community_mute_community_and_channel, id: 703382

    Device 1: Find MuteButton by accessibility id: mute-community
    Device 1: Click system back button 

    critical/test_public_chat_browsing.py:442: in test_community_mute_community_and_channel
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text 'Muted until 10:42 Tue 3 Oct' is not shown for a muted community channel



    Device sessions

    Passed tests (27)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Francesca-G
    Francesca-G reviewed Sep 27, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Here's the frame with the design review :)

    @OmarBasem
    Copy link
    Contributor Author

    Thanks for your review @Francesca-G, fixed the issues!

    Francesca-G
    Francesca-G reviewed Sep 27, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Here's the updated review
    Please refer to review 2 :)

    @OmarBasem
    Copy link
    Contributor Author

    @Francesca-G regarding the cursor I replied to your comment.
    The alignment should be fixed now

    @OmarBasem OmarBasem force-pushed the quo2/token-input-followup branch 2 times, most recently from 1b08d2b to 4eb2b08 Compare September 28, 2023 13:21
    @OmarBasem OmarBasem merged commit d8d8a6c into develop Oct 2, 2023
    6 checks passed
    @OmarBasem OmarBasem deleted the quo2/token-input-followup branch October 2, 2023 05:01
    clauxx pushed a commit that referenced this pull request Oct 3, 2023
    @OmarBasem @clauxx
    Quo2: Token Input followup (#17419)
    1a4e80f 
    * Quo2: token input followup
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @vkjr vkjr Awaiting requested review from vkjr

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Quo2 Wallet: complete Token Input component
    6 participants
    @OmarBasem @status-im-auto @flexsurfer @smohamedjavid @J-Son89 @Francesca-G