-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#17357] move status-im.async-storage.core #17380
[#17357] move status-im.async-storage.core #17380
Conversation
Jenkins BuildsClick to see older builds (8)
|
70% of end-end tests have passed
Failed tests (13)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (30)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
|
@status-im/mobile-qa could someone pls take a look if e2e is ok to merge? |
Hi @flexsurfer I am checking e2e. Let you know soon if something is introduced by this PR |
Hi @flexsurfer here is the issue found in e2e: ISSUE 1: When the app is killed and then reopened, the chat does not open as expected.Steps to Reproduce:
Actual Result:The chat that was previously open does not automatically reopen after killing and reopening the app. openedchat.mp4Expected Result:When the app is reopened, it should restore the state of the previously opened chat |
@flexsurfer Other e2e issues are not related to this PR |
thanks @VolodLytvynenko fixed |
51% of end-end tests have passed
Failed tests (21)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (22)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
|
@flexsurfer Today there are problems with message delivery (specifically in e2e tests). Which leads to e2e constant failures. I'll rerun e2e again. If the picture is still unclear, then I’ll take this PR and retest it manually. |
70% of end-end tests have passed
Failed tests (13)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (30)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
a738eb3
to
79fcf59
Compare
i don't think there are much, if chat works fine thats should be ok, thanks |
Thanks for the clarifications. No issues for Android builds. But I am unable to check it on the ios. IOS was not built successfully |
79fcf59
to
0e4412f
Compare
@VolodLytvynenko rebased |
@flexsurfer Thank you for PR. No issues from my side. Can be merged |
fixes #17357