Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove messages screen global states #17365

Merged
merged 2 commits into from
Sep 21, 2023
Merged

remove messages screen global states #17365

merged 2 commits into from
Sep 21, 2023

Conversation

Parveshdhull
Copy link
Member

fixes #17362

status: ready

@Parveshdhull Parveshdhull self-assigned this Sep 20, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 20, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (14)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ ea73c4e #1 2023-09-20 16:23:38 ~3 min tests 📄log
❌ 3eb23e9 #2 2023-09-20 16:26:24 ~2 min tests 📄log
✔️ 3eb23e9 #2 2023-09-20 16:29:28 ~5 min android-e2e 🤖apk 📲
✔️ 3eb23e9 #2 2023-09-20 16:29:53 ~6 min android 🤖apk 📲
✔️ 3eb23e9 #2 2023-09-20 16:30:42 ~7 min ios 📱ipa 📲
✔️ 7c7f670 #3 2023-09-20 16:37:07 ~6 min android 🤖apk 📲
✔️ 7c7f670 #3 2023-09-20 16:37:25 ~6 min ios 📱ipa 📲
✔️ 7c7f670 #3 2023-09-20 16:37:33 ~6 min android-e2e 🤖apk 📲
✔️ 7c7f670 #3 2023-09-20 16:39:26 ~8 min tests 📄log
❌ 87a1dce #5 2023-09-20 17:17:05 ~2 min tests 📄log
✔️ 4304820 #6 2023-09-20 17:25:14 ~6 min ios 📱ipa 📲
✔️ 4304820 #6 2023-09-20 17:28:00 ~9 min android-e2e 🤖apk 📲
✔️ 4304820 #6 2023-09-20 17:28:16 ~9 min android 🤖apk 📲
✔️ 4304820 #6 2023-09-20 17:28:50 ~10 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e8f2f12 #7 2023-09-21 10:10:42 ~5 min android 🤖apk 📲
✔️ e8f2f12 #7 2023-09-21 10:11:16 ~6 min ios 📱ipa 📲
✔️ e8f2f12 #7 2023-09-21 10:12:56 ~8 min android-e2e 🤖apk 📲
✔️ e8f2f12 #7 2023-09-21 10:14:20 ~9 min tests 📄log
✔️ d8424f1 #9 2023-09-21 15:47:42 ~5 min android-e2e 🤖apk 📲
✔️ d8424f1 #9 2023-09-21 15:48:13 ~6 min android 🤖apk 📲
✔️ d8424f1 #9 2023-09-21 15:49:15 ~6 min ios 📱ipa 📲
✔️ d8424f1 #9 2023-09-21 15:51:20 ~9 min tests 📄log

@Parveshdhull Parveshdhull force-pushed the fix/jump-to-button branch 3 times, most recently from c82a0ab to 87a1dce Compare September 20, 2023 17:13
Parveshdhull
Parveshdhull commented Sep 20, 2023
View reviewed changes
src/status_im2/contexts/chat/messages/list/view.cljs
@@ -27,11 +26,7 @@
(defonce ^:const scroll-animation-input-range [50 125])
(defonce ^:const min-message-height 32)

(defonce extra-keyboard-height (reagent/atom 0))
(defonce messages-list-ref (atom nil))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tried removing messages-list-ref 7c7f670, but this started to cause weird error https://stackoverflow.com/questions/48045696/flatlist-scrollview-error-on-any-state-change-invariant-violation-changing-on

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 43
Failed tests: 6
Passed tests: 37

IDs of failed tests: 702732,702783,703503,702786,702731,702808

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Delivered 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (37)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Sep 21, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    hi @Parveshdhull could you resolve please the existing conflicts in this PR?

    @VolodLytvynenko
    Copy link
    Contributor

    VolodLytvynenko commented Sep 21, 2023 •
    edited
    Loading

    Hi @Parveshdhull . thank you for PR. No issues from my side. Please let me know if you plan to push any new commits after PR review, otherwise, the PR can be merged :) Thank you!

    ibrkhalil
    ibrkhalil approved these changes Sep 21, 2023
    View reviewed changes
    Copy link
    Contributor

    @ibrkhalil ibrkhalil left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This was a much needed and awaited for cleanup
    Thanks Parvesh!

    @Parveshdhull Parveshdhull merged commit a99ae74 into develop Sep 21, 2023
    2 checks passed
    @Parveshdhull Parveshdhull deleted the fix/jump-to-button branch September 21, 2023 15:51
    ibrkhalil pushed a commit that referenced this pull request Oct 1, 2023
    @Parveshdhull @ibrkhalil
    remove messages screen global states (#17365)
    82101ea
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @alwx alwx Awaiting requested review from alwx

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @OmarBasem OmarBasem Awaiting requested review from OmarBasem

    Assignees

    @Parveshdhull Parveshdhull

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    4 participants
    @Parveshdhull @status-im-auto @VolodLytvynenko @ibrkhalil