chore: adjust counter to use customization-color internally #16799
Conversation
J-Son89
changed the title
| @@ -362,7 +361,7 @@ | |||
| customization-color (rf/sub [:profile/customization-color])] | |||
| [rn/view {:style style/community-overview-container} | |||
| [community-card-page-view id] | |||
| [floating-shell-button/floating-shell-button | |||
| [quo/floating-shell-button | |||
There was a problem hiding this comment.
updated component to use quo export 👍
Jenkins BuildsClick to see older builds (16)
|
88% of end-end tests have passedFailed tests (5)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (35)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
| :style (when (= type :default) {:color colors/white})} | ||
| label]])) | ||
|
|
||
| (def counter (quo.theme/with-theme counter-internal)) |
There was a problem hiding this comment.
I don't know if the guidelines are clear, but we can just use view and view-internal in quo2, since only one component is exposed for every view namespace.
|
@J-Son89 |
|
Thanks for the early testing @churik! I'll address those issues and look across the different uses to make sure it's all good 👍 |
J-Son89
force-pushed
the
jc/counter-refactor
branch
from
2a97d2b
to
72372ba
Compare
|
Hi @churik, this branch is ready for testing now :)
|
88% of end-end tests have passedFailed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (35)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
J-Son89
force-pushed
the
jc/counter-refactor
branch
from
72372ba
to
78c12da
Compare
|
Hey @J-Son89, could you rebase this one, please? |
J-Son89
force-pushed
the
jc/counter-refactor
branch
from
78c12da
to
f44b000
Compare
|
@qoqobolo done! :) |
|
@J-Son89 we need another rebase after reverting that commit 😅 |
|
Oh yeah! Doing now :) |
J-Son89
force-pushed
the
jc/counter-refactor
branch
from
f44b000
to
0ea4e09
Compare
|
@qoqobolo, done! :) |
|
@J-Son89 q: should counters on the community itself (on the community home screen) handle the custom color? 
|
|
@qoqobolo, yes definitely. I'll fix! sorry about that :/ |
|
@J-Son89 ah no worries! I was not sure either since we have another issue for that #16784, and there are a couple more types of counters. So,
If this PR is supposed to fix all of these counters, could you please add the issue to the PR description so we can also close it when the PR is merged? |
|
Thanks @qoqobolo - this pr was focused on the quo2 counter component - https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=179-9536&mode=design&t=3m3BsbjGpxkWzybU-4 How about I handle all issues for that here? and for the notification dot I can do in a follow up pr? |
Gotcha! For some reason, we also call "dots" counters, although this is incorrect, sorry :)
Sure, then now we neef to fix only the
@alwx is also going to work on this dots/counters colors issue: #16784 You can decide here who would like to work on this and re-assign the issue if needed. In any case, I will update the task description so that it is only about notification dots. |
|
@qoqobolo - should be all sorted now: 
|
J-Son89
force-pushed
the
jc/counter-refactor
branch
from
0ea4e09
to
e455e6f
Compare
|
Yay, it's a feast for the eyes🎉 Thanks for your work @J-Son89! |
fixes: #16798
Counter component was using an override approach to set the colors, moved the custom color mechanism internal to the component and then updated it to best practices 👍
To test - I don't think anything is actually added here, mostly just look out for screens where the counter component is used 👍
Example:
