Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: category reorder component #16719

Merged
merged 14 commits into from
Jul 26, 2023
Merged

feat: category reorder component #16719

merged 14 commits into from
Jul 26, 2023

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented Jul 19, 2023 •
edited
Loading

fixes: #16712

This PR implements the category quo2 component -- list-type: reorder

Designs.

@OmarBasem OmarBasem self-assigned this Jul 19, 2023
@OmarBasem OmarBasem changed the title feat: reorder comp [WIP] feat: reorder comp Jul 19, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jul 19, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ e6784db #1 2023-07-19 10:22:39 ~4 min tests 📄log
✔️ e6784db #1 2023-07-19 10:25:25 ~6 min android-e2e 🤖apk 📲
✔️ e6784db #1 2023-07-19 10:25:32 ~6 min android 🤖apk 📲
✔️ e6784db #1 2023-07-19 10:31:37 ~13 min ios 📱ipa 📲
❌ cc45080 #2 2023-07-19 12:06:23 ~4 min tests 📄log
✔️ cc45080 #2 2023-07-19 12:08:11 ~6 min android 🤖apk 📲
✔️ cc45080 #2 2023-07-19 12:08:25 ~6 min android-e2e 🤖apk 📲
✔️ cc45080 #2 2023-07-19 12:23:42 ~21 min ios 📱ipa 📲
✔️ c96c8ea #4 2023-07-21 08:31:25 ~6 min ios 📱ipa 📲
✔️ c96c8ea #4 2023-07-21 08:31:26 ~6 min android-e2e 🤖apk 📲
✔️ c96c8ea #4 2023-07-21 08:31:28 ~6 min android 🤖apk 📲
❌ c96c8ea #4 2023-07-21 08:34:23 ~9 min tests 📄log
✔️ 3d1542f #5 2023-07-21 10:10:35 ~5 min android 🤖apk 📲
✔️ 3d1542f #5 2023-07-21 10:12:02 ~7 min android-e2e 🤖apk 📲
✔️ 3d1542f #5 2023-07-21 10:12:38 ~7 min ios 📱ipa 📲
❌ 3d1542f #5 2023-07-21 10:13:45 ~8 min tests 📄log
✔️ eac0ae8 #8 2023-07-21 11:57:21 ~5 min android 🤖apk 📲
✔️ eac0ae8 #8 2023-07-21 11:59:29 ~7 min ios 📱ipa 📲
✔️ eac0ae8 #8 2023-07-21 11:59:51 ~8 min android-e2e 🤖apk 📲
✔️ eac0ae8 #8 2023-07-21 12:00:23 ~8 min tests 📄log
✔️ 74afa75 #10 2023-07-24 05:39:59 ~5 min android-e2e 🤖apk 📲
✔️ 74afa75 #10 2023-07-24 05:41:01 ~6 min ios 📱ipa 📲
✔️ 74afa75 #10 2023-07-24 05:42:58 ~8 min android 🤖apk 📲
✔️ 74afa75 #10 2023-07-24 05:43:22 ~8 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3bab206 #11 2023-07-24 12:29:56 ~6 min android-e2e 🤖apk 📲
✔️ 3bab206 #11 2023-07-24 12:29:59 ~6 min android 🤖apk 📲
✔️ 3bab206 #11 2023-07-24 12:31:29 ~7 min ios 📱ipa 📲
✔️ 3bab206 #11 2023-07-24 12:31:49 ~7 min tests 📄log
✔️ 362e74a #12 2023-07-26 05:06:57 ~6 min android-e2e 🤖apk 📲
✔️ 362e74a #12 2023-07-26 05:07:00 ~6 min android 🤖apk 📲
✔️ 362e74a #12 2023-07-26 05:08:44 ~7 min tests 📄log
❌ 362e74a #12 2023-07-26 05:09:02 ~8 min ios 📄log
✔️ 362e74a #13 2023-07-26 06:13:20 ~8 min ios 📱ipa 📲

J-Son89
J-Son89 reviewed Jul 20, 2023
View reviewed changes
src/quo2/core.cljs Outdated Show resolved Hide resolved
@OmarBasem OmarBasem marked this pull request as ready for review July 21, 2023 08:27
@OmarBasem OmarBasem changed the title [WIP] feat: reorder comp feat: reorder comp Jul 21, 2023
@OmarBasem OmarBasem changed the title feat: reorder comp feat: category reorder component Jul 21, 2023
@OmarBasem
Copy link
Contributor Author

Hi @Francesca-G, can I get a design review on this one?

Component is under quo2 preview > settings > category-reorder

@J-Son89
Copy link
Contributor

J-Son89 commented Jul 21, 2023 •
edited
Loading

Hi @Francesca-G, can I get a design review on this one?

Component is under quo2 preview > settings > category-reorder

I think @Francesca-G should wait until this is dev reviewed first?

@OmarBasem
Copy link
Contributor Author

Hi @Francesca-G, can I get a design review on this one?
Component is under quo2 preview > settings > category-reorder

I think @Francesca-G should wait until this is dev reviewed first?

@J-Son89 What is the process we are following? What I remember is that John said devs can ask for design review when they feel the PR is ready design wise

@J-Son89
Copy link
Contributor

J-Son89 commented Jul 21, 2023

Hi @Francesca-G, can I get a design review on this one?
Component is under quo2 preview > settings > category-reorder

I think @Francesca-G should wait until this is dev reviewed first?

@J-Son89 What is the process we are following? What I remember is that John said devs can ask for design review when they feel the PR is ready design wise

yes but likely things change when devs review so it's better to wait for that. cc @churik @Francesca-G maybe it's better you clear up the process for us with design reviews :)

@Francesca-G
Copy link

Hi @Francesca-G, can I get a design review on this one?
Component is under quo2 preview > settings > category-reorder

I think @Francesca-G should wait until this is dev reviewed first?

@J-Son89 What is the process we are following? What I remember is that John said devs can ask for design review when they feel the PR is ready design wise

yes but likely things change when devs review so it's better to wait for that. cc @churik @Francesca-G maybe it's better you clear up the process for us with design reviews :)

As far as I know I should be reviewing PRs that are ready from a dev point of view, when you feel like there's nothing else to do and the PR is basically ready to merge I should come in and review from a design perspective.

So I agree with @J-Son89, if things are likely to change with dev reviews I should wait until that stage is complete.
@churik let me know if that sounds good to you :)

J-Son89
J-Son89 reviewed Jul 21, 2023
View reviewed changes
package.json Show resolved Hide resolved
@OmarBasem OmarBasem requested review from J-Son89 and smohamedjavid and removed request for smohamedjavid July 24, 2023 05:39
@OmarBasem OmarBasem requested a review from ibrkhalil July 24, 2023 08:04
J-Son89
J-Son89 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @OmarBasem!

@churik
Copy link
Member

churik commented Jul 24, 2023

@Francesca-G

So I agree with @J-Son89, if things are likely to change with dev reviews I should wait until that stage is complete.
@churik let me know if that sounds good to you :)

Yes, that's my understanding, and actually, I believe for components design review is enough - no need in manual testing if a component is still not used.

thanks!

@OmarBasem
Copy link
Contributor Author

Hi @Francesca-G, PR is ready for design review.

Francesca-G
Francesca-G reviewed Jul 24, 2023
View reviewed changes
Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the Figma frame with design comments :)

smohamedjavid
smohamedjavid approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! @OmarBasem!

@OmarBasem
Copy link
Contributor Author

Hi @Francesca-G, thanks for your review! I have replied to your comments on Figma and fixed the issues. Please let me know if all is ok now.

@OmarBasem OmarBasem merged commit e49a3ab into develop Jul 26, 2023
2 checks passed
@OmarBasem OmarBasem deleted the quo2/category-reorder branch July 26, 2023 07:11
andresceballosm pushed a commit to andresceballosm/status-mobile that referenced this pull request Aug 6, 2023
@OmarBasem @mmilad75 @andresceballosm
feat: category reorder component (status-im#16719)
95590be 
* feat: category reorder component

---------

Co-authored-by: Milad <mmilad.sanati@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francesca-G Francesca-G Francesca-G approved these changes

@J-Son89 J-Son89 J-Son89 approved these changes

@smohamedjavid smohamedjavid smohamedjavid approved these changes

@mmilad75 mmilad75 Awaiting requested review from mmilad75

@briansztamfater briansztamfater Awaiting requested review from briansztamfater

@rasom rasom Awaiting requested review from rasom

@ibrkhalil ibrkhalil Awaiting requested review from ibrkhalil

Assignees

@OmarBasem OmarBasem

Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement quo2 - Settings - Reorder component
7 participants
@OmarBasem @status-im-auto @J-Son89 @Francesca-G @churik @smohamedjavid @mmilad75