Refactor toast component to use theme context
#16711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (33)
|
smohamedjavid
force-pushed
the
refactor/toast-component
branch
from
028b2d1
to
ba6942d
Compare
J-Son89
reviewed
Jul 18, 2023
J-Son89
approved these changes
Jul 18, 2023
flexsurfer
approved these changes
Jul 18, 2023
89% of end-end tests have passedFailed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (32)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
|
yqrashawn
approved these changes
Jul 19, 2023
|
Marking as draft as we will need to update text, and icon components to use theme context (those styles are overriding from toast), and update toast with a theme provider. |
smohamedjavid
force-pushed
the
refactor/toast-component
branch
4 times, most recently
from
cdf2e54
to
8e457c1
Compare
smohamedjavid
changed the title
toast componenttoast component to use theme context
smohamedjavid
force-pushed
the
refactor/toast-component
branch
from
8e457c1
to
cdcfddb
Compare
86% of end-end tests have passedFailed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (31)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
|
|
hi @smohamedjavid thank you for PR. Take a look please, one issue if found ISSUE 1: [Android] The highlighted background around the text is shown on the toast when dark mode is usedSteps:
Actual result:The highlighted background around the text is shown (it is slightly visible) Expected result:Last nightly Devices:
|
smohamedjavid
force-pushed
the
refactor/toast-component
branch
2 times, most recently
from
2b2733a
to
1600135
Compare
|
@VolodLytvynenko - Thanks for testing the PR!
The issue is fixed. Kindly retest. |
✔️ status-mobile/prs/android/PR-16711#9 🔹 ~6 min 15 sec 🔹 2b2733a 🔹 📦 android package |
85% of end-end tests have passedFailed tests (6)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (33)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
|
Hi @smohamedjavid thank you for fixes. No issues from my side. PR is ready to be merged |
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
smohamedjavid
force-pushed
the
refactor/toast-component
branch
from
1600135
to
8f3693a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
Toastcomponent to use theme context for consistency across the codebase.Each toast will have its own
theme-providerwhich will help the children to use the context properly without interfering with other toast's context.Below is an example of providing a specific theme for toast.
Changes done:
Following components are refactored to use
with-theme/theme-context:textcomponentuser-avatarcomponenticoncomponentcircle-timercomponentThis PR also updates the icon keyword used in the
:toasts/upsertevent dispatch to respect icon guidelines.Testing notes
Please test whether all the Toasts across the application are working as expected on both light mode and dark mode.
Please test the Toasts in Syncing process as it is dark-themed. It should not change depending on the user's theme.
If any issue is encountered, kindly check whether the issue is reproducible with nightly or the latest
developbranch. This would help us to identify issues due to changes in this PR and resolve them.Platforms
status: ready