Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide mutual update's system messages #16674

Merged
merged 1 commit into from
Jul 14, 2023
Merged

hide mutual update's system messages #16674

merged 1 commit into from
Jul 14, 2023

Conversation

Parveshdhull
Copy link
Member

fixes: #16629

feature will be implemented in #16254

status: ready

@Parveshdhull Parveshdhull self-assigned this Jul 14, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jul 14, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d24abea #1 2023-07-14 12:30:41 ~6 min android 🤖apk 📲
✔️ d24abea #1 2023-07-14 12:30:51 ~6 min android-e2e 🤖apk 📲
✔️ d24abea #1 2023-07-14 12:32:26 ~8 min tests 📄log
✔️ d24abea #1 2023-07-14 12:33:45 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ ad28e10 #3 2023-07-14 12:40:06 ~3 min tests 📄log
✔️ ad28e10 #3 2023-07-14 12:42:30 ~6 min android 🤖apk 📲
✔️ ad28e10 #3 2023-07-14 12:42:41 ~6 min android-e2e 🤖apk 📲
✔️ ad28e10 #3 2023-07-14 12:46:22 ~10 min ios 📱ipa 📲
✔️ ad28e10 #4 2023-07-14 13:11:03 ~8 min tests 📄log
✔️ e2f32cf #4 2023-07-14 13:55:55 ~6 min android 🤖apk 📲
✔️ e2f32cf #4 2023-07-14 13:55:55 ~6 min ios 📱ipa 📲
✔️ e2f32cf #4 2023-07-14 13:56:43 ~7 min android-e2e 🤖apk 📲
✔️ e2f32cf #5 2023-07-14 13:59:08 ~9 min tests 📄log

@Parveshdhull Parveshdhull force-pushed the fix/mutual-update-system-messages branch from b6e4c1b to ad28e10 Compare July 14, 2023 12:35
@churik churik self-assigned this Jul 14, 2023
@status-im-auto
Copy link
Member

85% of end-end tests have passed

Total executed tests: 34
Failed tests: 5
Passed tests: 29
Not executed tests: 2

IDs of not executed tests: 703391,703297 

IDs of failed tests: 702731,702783,702732,703133,702845

Not executed tests (2)

Click to expand
  • Rerun not executed tests

    • Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1310: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_leave, id: 702845

    Device 2: Find Button by xpath: //*[@text="Leave community"]
    Device 2: Tap on found: Button 

    critical/test_public_chat_browsing.py:972: in test_community_leave
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community is still shown in the list after leave



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:433: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact(s) was (were) not restored from backup: MyCustomNickname!



    Device sessions

    Passed tests (29)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859
    Device sessions

    2. test_community_message_edit, id: 702843
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_several_images_send_reply, id: 703194
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    10. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    11. test_community_message_delete, id: 702839
    Device sessions

    @churik churik added this to the 1.24.0 - Alpha milestone Jul 14, 2023
    @siddarthkay
    Copy link
    Contributor

    @Parveshdhull : pls rebase and merge, I'll then cherry pick this one for release 1.24.x

    @Parveshdhull Parveshdhull force-pushed the fix/mutual-update-system-messages branch from ad28e10 to e2f32cf Compare July 14, 2023 13:49
    @Parveshdhull Parveshdhull merged commit c0e4653 into develop Jul 14, 2023
    @Parveshdhull Parveshdhull deleted the fix/mutual-update-system-messages branch July 14, 2023 13:59
    siddarthkay pushed a commit that referenced this pull request Jul 14, 2023
    @Parveshdhull @siddarthkay
    hide mutual update's system messages (#16674)
    4302079
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    Assignees

    @churik churik

    @Parveshdhull Parveshdhull

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    1.24.0 - Alpha
    Development

    Successfully merging this pull request may close these issues.

    System messages with keys are shown in 1-1 chat when accepting CR
    5 participants
    @Parveshdhull @status-im-auto @siddarthkay @ilmotta @churik