fix: onboarding carousel overflows causing navigation glitches #16514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
briansztamfater
force-pushed
the
fix/onboarding-intro-navigation-back
branch
from
3fa3878
to
eec4f38
Compare
briansztamfater
changed the title
briansztamfater
changed the title
briansztamfater
changed the title
briansztamfater
changed the title
ajayesivan
approved these changes
Jul 7, 2023
|
@briansztamfater thanx for the fix! PR will be ready for merge as soon as e2e run is finished. Will keep you updated. |
rahulpsingh
approved these changes
Jul 7, 2023
pavloburykh
force-pushed
the
fix/onboarding-intro-navigation-back
branch
from
eec4f38
to
b19a3dd
Compare
|
@briansztamfater thanx, PR is ready for merge. e2e were posted here #15614 (comment) by the mistake. Failed e2e are not PR related. |
Signed-off-by: Brian Sztamfater <brian@status.im>
briansztamfater
force-pushed
the
fix/onboarding-intro-navigation-back
branch
from
b19a3dd
to
a058399
Compare
codemaster115
pushed a commit
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Brian Sztamfater <brian@status.im>
andresceballosm
pushed a commit
to andresceballosm/status-mobile
that referenced
this pull request
Jul 11, 2023
…s-im#16514) Signed-off-by: Brian Sztamfater <brian@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16512
Summary
Hides overflow of background carousel, as it leads to navigation glitches within onboarding
Platforms
Functional
Steps to test
status: ready