Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key-storage cleanup #16427

Merged
merged 1 commit into from
Jun 29, 2023
Merged

key-storage cleanup #16427

merged 1 commit into from
Jun 29, 2023

Conversation

flexsurfer
Copy link
Member

key-storage cleanup

@flexsurfer flexsurfer self-assigned this Jun 28, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jun 28, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6e082c9 #1 2023-06-28 13:12:56 ~6 min ios 📱ipa 📲
✔️ 6e082c9 #1 2023-06-28 13:14:07 ~7 min android 🤖apk 📲
✔️ 6e082c9 #1 2023-06-28 13:15:15 ~8 min tests 📄log
✔️ 6e082c9 #1 2023-06-28 13:15:50 ~8 min android-e2e 🤖apk 📲

@status-im status-im deleted a comment from status-im-auto Jun 29, 2023
@status-im-auto
Copy link
Member

76% of end-end tests have passed

Total executed tests: 33
Failed tests: 8
Passed tests: 25

IDs of failed tests: 702732,702745,702851,702731,702958,703133,703086,702850

Failed tests (8)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Find Button by accessibility id: new-chat-button
    Device 2: Find Button by accessibility id: add-a-contact 

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_2.add_contact(self.public_key_1, remove_from_contacts=True)
../views/home_view.py:359: in add_contact
    self.add_a_contact_chat_bottom_sheet_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `add-a-contact` is not found on the screen



    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850

    Device 2: Tap on found: Button
    Device 2: Looking for activity center element: 'sender' 

    medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
    message_element.wait_for_element(30)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `Button` by` xpath`: `//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-message-body"]` is not found on the screen after wait_for_element



    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 1: Looking for activity center element: 'user2'
    Device 1: Find Button by xpath: //*[contains(@text, 'user2')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"] 

    medium/test_activity_center.py:331: in test_activity_center_admin_notification_accept_swipe
    if reply_element.title.text != 'Join request':
../views/base_element.py:209: in text
    return self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[contains(@text, 'user2')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"]` is not found on the screen



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 5.561882467830882 percents 

    critical/chats/test_1_1_public_chats.py:1076: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Tap on found: ProfileSendMessageButton
    Device 1: Find Text by xpath: //*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView 

    critical/test_public_chat_browsing.py:391: in test_restore_multiaccount_with_waku_backup_remove_switch
    shown_name_text = chat.user_name_text_new_UI.text
../views/base_element.py:391: in text
    text = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView` is not found on the screen



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Find Button by accessibility id: mark-as-read
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:837: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Commmunity element



    Device sessions

    Passed tests (25)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_edit_message, id: 702855
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_unread_messages_badge, id: 702841
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_several_images_send_reply, id: 703194
    Device sessions

    4. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_one_image_send_reply, id: 702859
    Device sessions

    8. test_community_mentions_push_notification, id: 702786
    Device sessions

    9. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    10. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    J-Son89
    J-Son89 reviewed Jun 29, 2023
    View reviewed changes
    src/status_im/keycard/unpair.cljs
    :t/profile-deleted-keycard
    :t/database-reset-content))
    :on-dismiss #(re-frame/dispatch [:logout])}}
    ;;should be reimplemented
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    can you create a TODO with an issue tracked for this aswell/instead? 🙏

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    there is not TODO and issue, we don't know when it will happen

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I'm a bit confused, for what reason can we not create a GH issue here?

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    also it's better to just remove the commented out code 👍

    Copy link
    Member Author

    @flexsurfer flexsurfer Jun 29, 2023 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    keycard is not supported in new design, when it will be supported we don't know, when it will be reimplemented someone who will be touching this code should be aware that this part needs to be reimplemented as well

    J-Son89
    J-Son89 reviewed Jun 29, 2023
    View reviewed changes
    src/status_im/multiaccounts/key_storage/core.cljs
    @@ -125,132 +19,3 @@
    (if-not (string/blank? error)
    (on-error error)
    (on-success))))))))

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    😎 !

    @flexsurfer flexsurfer merged commit d9f7510 into develop Jun 29, 2023
    @flexsurfer flexsurfer deleted the feature/multiaccounts-refactoring-part2 branch June 29, 2023 12:29
    codemaster115 pushed a commit that referenced this pull request Jul 7, 2023
    @flexsurfer @codemaster115
    key-storage cleanup (#16427)
    2ca1d4f
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @vkjr vkjr vkjr approved these changes

    @ibrkhalil ibrkhalil Awaiting requested review from ibrkhalil

    Assignees

    @flexsurfer flexsurfer

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @flexsurfer @status-im-auto @vkjr @J-Son89