nix: downgrade watchman to 4.9.0 #16406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakubgs, please have a look |
Closed
Jenkins BuildsClick to see older builds (18)
|
jakubgs
reviewed
Jun 27, 2023
jakubgs
requested changes
Jun 27, 2023
|
And you have context in the PR description but not in commit body. |
yakimant
force-pushed
the
nix_downgrade_watchman
branch
from
78d6983
to
8f4f413
Compare
jakubgs
approved these changes
Jun 27, 2023
jakubgs
approved these changes
Jun 29, 2023
|
Tested your branch with these settings A lot of files were open at the same time because i ran This PR does solve the problem I think. |
siddarthkay
approved these changes
Jun 29, 2023
yakimant
force-pushed
the
nix_downgrade_watchman
branch
2 times, most recently
from
98e62e9
to
c1026c2
Compare
jakubgs
force-pushed
the
nix_downgrade_watchman
branch
from
c1026c2
to
d280836
Compare
watchman was upgraded significantly during the last #14944 (4.9.0 (Aug 16, 2017) to 2023.01.30.00 - 6 years between): status-im/nixpkgs@4e9c02b Probably causing developers to have "too many files open" issue #16341 This PR is an attempt to fix the issue by downgrading the watchman Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
nix_downgrade_watchman
branch
from
d280836
to
07d037f
Compare
|
Notes for future upgrades:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16341
Summary
watchmanwas upgraded significantly during the last #14944 (4.9.0(Aug 16, 2017) to2023.01.30.00- 6 years between):status-im/nixpkgs@4e9c02b
Probably causing developers to have "too many files open" issue #16341
This PR is an attempt to fix the issue by downgrading the
watchmanTesting notes
"too many files open" issue of
watchmanmight be difficult to catch.So let's test, that the downgrade doesn't break the flow rather.
Steps to test
run-clojure/run-metro/run-...flow shouls continue to work and update the app as beforestatus: wip