Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init status-go logging once app start up #16325

Merged
merged 1 commit into from
Jun 21, 2023
Merged

init status-go logging once app start up #16325

merged 1 commit into from
Jun 21, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Jun 20, 2023 •
edited
Loading

It would be helpful if we could check the geth.log file to investigate any issues that might occur even if the user hasn't logged in yet. For example, local pairing may occur on the receiver side before login. If any problems arise during this process, we currently lack a log for status-go since logging for status-go is only configured after login.

Platforms

  • Android
  • iOS

Steps to test

  • Open Status , don't login
  • Check geth.log, there should be a line contains: lvl=info msg="logging initialised"

status: ready

@qfrank qfrank self-assigned this Jun 20, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jun 20, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (26)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a36ea18 #1 2023-06-20 11:20:00 ~7 min ios 📱ipa 📲
❌ a36ea18 #1 2023-06-20 11:32:33 ~20 min tests 📄log
✔️ a36ea18 #1 2023-06-20 11:38:05 ~25 min android 🤖apk 📲
✔️ a36ea18 #1 2023-06-20 11:39:53 ~27 min android-e2e 🤖apk 📲
❌ 5e7b5f5 #2 2023-06-20 13:13:41 ~3 min tests 📄log
✔️ 5e7b5f5 #2 2023-06-20 13:15:55 ~6 min android 🤖apk 📲
✔️ 5e7b5f5 #2 2023-06-20 13:16:06 ~6 min ios 📱ipa 📲
✔️ 5e7b5f5 #2 2023-06-20 13:18:16 ~8 min android-e2e 🤖apk 📲
❌ 21f6612 #3 2023-06-21 13:15:24 ~3 min tests 📄log
✔️ 21f6612 #3 2023-06-21 13:19:12 ~7 min ios 📱ipa 📲
✔️ 21f6612 #3 2023-06-21 13:20:19 ~8 min android-e2e 🤖apk 📲
✔️ 21f6612 #3 2023-06-21 13:22:52 ~11 min android 🤖apk 📲
❌ 21f6612 #4 2023-06-21 13:28:23 ~2 min tests 📄log
❌ 6829f55 #6 2023-06-21 14:13:09 ~3 min tests 📄log
✔️ 6829f55 #5 2023-06-21 14:18:40 ~8 min android-e2e 🤖apk 📲
✔️ 6829f55 #5 2023-06-21 14:18:49 ~9 min android 🤖apk 📲
✔️ 6829f55 #5 2023-06-21 14:19:29 ~9 min ios 📱ipa 📲
❌ 7262e0b #7 2023-06-21 14:29:51 ~4 min tests 📄log
✔️ 7262e0b #6 2023-06-21 14:33:09 ~7 min ios 📱ipa 📲
✔️ 7262e0b #6 2023-06-21 14:34:16 ~8 min android 🤖apk 📲
✔️ 7262e0b #6 2023-06-21 14:35:24 ~9 min android-e2e 🤖apk 📲
❌ 42c5ec4 #8 2023-06-21 22:51:37 ~1 min tests 📄log
❌ 57de3fd #9 2023-06-21 22:58:15 ~2 min tests 📄log
✔️ 57de3fd #8 2023-06-21 23:01:22 ~5 min ios 📱ipa 📲
✔️ 57de3fd #8 2023-06-21 23:01:23 ~5 min android-e2e 🤖apk 📲
✔️ 57de3fd #8 2023-06-21 23:01:27 ~5 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 22a920e #9 2023-06-21 23:34:39 ~5 min ios 📱ipa 📲
✔️ 22a920e #9 2023-06-21 23:34:53 ~5 min android-e2e 🤖apk 📲
✔️ 22a920e #9 2023-06-21 23:34:59 ~5 min android 🤖apk 📲
✔️ 22a920e #10 2023-06-21 23:36:42 ~7 min tests 📄log
✔️ a1923c4 #10 2023-06-21 23:43:33 ~5 min ios 📱ipa 📲
✔️ a1923c4 #10 2023-06-21 23:43:46 ~5 min android 🤖apk 📲
✔️ a1923c4 #10 2023-06-21 23:43:58 ~5 min android-e2e 🤖apk 📲
✔️ a1923c4 #11 2023-06-21 23:45:27 ~7 min tests 📄log

@qfrank qfrank requested a review from rasom June 20, 2023 11:31
@qfrank qfrank mentioned this pull request Jun 20, 2023
Merged
ilmotta
ilmotta approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @qfrank!

src/status_im2/common/log.cljs Outdated Show resolved Hide resolved
flexsurfer
flexsurfer approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've been waiting for you for years! thanks :)

@qfrank
Copy link
Contributor Author

qfrank commented Jun 20, 2023

we've been waiting for you for years! thanks :)

sorry, it was the lowest priority in my task list

@flexsurfer
Copy link
Member

sorry, it was the lowest priority in my task list

it was like a joke :) i mean we've been facing this problem a lot, but we never implemented it, so thank you :)

@churik churik self-assigned this Jun 20, 2023
@status-im-auto
Copy link
Member

82% of end-end tests have passed

Total executed tests: 33
Failed tests: 6
Passed tests: 27

IDs of failed tests: 702783,702732,702894,702731,702745,703133

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Looking for a message by text: Hurray! unblocked
    Device 1: Find ChatElementByText by xpath: //*[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/test_public_chat_browsing.py:751: in test_community_contact_block_unblock_offline
    chat_element.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1253: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!

    [[Issue with messages not being sent for a long time]]

    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 3.1901041666666665 percents 

    critical/chats/test_1_1_public_chats.py:1076: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message with text 'hello' was not received
E    Message with text 'ё, доброго вечерочка' was not received



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:399: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!
E    Contact Chu_QA was not restored from backup!
E    Contact my-custom-nickname was not restored from backup!



    Device sessions

    Passed tests (27)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    4. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    5. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_unread_messages_badge, id: 702841
    Device sessions

    8. test_community_mentions_push_notification, id: 702786
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_several_images_send_reply, id: 703194
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @churik
    Copy link
    Member

    churik commented Jun 21, 2023

    @qfrank works perfectly for Android, checked on different flows - creating users, relogin, and that logs are written when the user is logged out.

    FILE.2023-06-21.11.29.09.mp4

    However, on IOS there is no log attached when I shake phone > Share logs before logging in.

    If it requires too much time to fix, we can merge it as it is as it is an imrovement.

    @qfrank
    Copy link
    Contributor Author

    qfrank commented Jun 21, 2023 •
    edited
    Loading

    @qfrank works perfectly for Android, checked on different flows - creating users, relogin, and that logs are written when the user is logged out.

    FILE.2023-06-21.11.29.09.mp4
    However, on IOS there is no log attached when I shake phone > Share logs before logging in.

    If it requires too much time to fix, we can merge it as it is as it is an imrovement.

    interesting, just checked, we can share the log after login, and the shared log contains the line lvl=info msg="logging initialised" which means we can get the status-go log content wrote before login, proberbly has bug relate to report a bug/share logs , could you log it as an issue? then we can fix it in a separate PR, thank you! @churik

    @qfrank qfrank force-pushed the feat/init-statusgo-logging branch 3 times, most recently from 1f8a579 to 6829f55 Compare June 21, 2023 14:09
    @qfrank qfrank force-pushed the feat/init-statusgo-logging branch from 22a920e to a1923c4 Compare June 21, 2023 23:37
    @qfrank qfrank merged commit db44ee6 into develop Jun 21, 2023
    @qfrank qfrank deleted the feat/init-statusgo-logging branch June 21, 2023 23:45
    @qfrank qfrank mentioned this pull request Jun 26, 2023
    Merged
    codemaster115 pushed a commit that referenced this pull request Jul 7, 2023
    @qfrank @codemaster115
    init status-go logging once app start up (#16325)
    5ce5a6e 
    status-im/status-go@6705042...7da1ed3
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @siddarthkay siddarthkay siddarthkay approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    @rasom rasom Awaiting requested review from rasom

    Assignees

    @churik churik

    @qfrank qfrank

    Labels
    request-manual-qa
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @qfrank @status-im-auto @flexsurfer @churik @ilmotta @J-Son89 @siddarthkay